From b3c5a26f85d9d7b59248c28ff745a74bbf6491f2 Mon Sep 17 00:00:00 2001 From: Norbert Hartl Date: Thu, 10 Sep 2026 14:25:30 +0200 Subject: [PATCH] Drop dead remains: two ivars, five methods, two event classes Nothing in FluxBase or apptive-base sends them, checked across all packages including tests: - FBFlowExecutor's ivars state and otherExecutor, never read or written - FBActivation>>suspend (the wait path from before tokens) and #returnValue: (shouldBeImplemented), FBBaseActivation>>followAll:, FBNode>>hasOutgoing, FBFlowEvent>>logTrace (abstract, no implementor) - FBNodeActivationFinished and FBStringEvent, event classes nothing ever created Co-Authored-By: Claude Fable 5.1 --- source/FluxBase-Core/FBActivation.class.st | 11 ------- .../FluxBase-Core/FBBaseActivation.class.st | 6 ---- source/FluxBase-Core/FBFlowEvent.class.st | 6 ---- source/FluxBase-Core/FBFlowExecutor.class.st | 4 +-- source/FluxBase-Core/FBNode.class.st | 5 --- .../FBNodeActivationFinished.class.st | 19 ----------- source/FluxBase-Core/FBStringEvent.class.st | 33 ------------------- 7 files changed, 1 insertion(+), 83 deletions(-) delete mode 100644 source/FluxBase-Core/FBNodeActivationFinished.class.st delete mode 100644 source/FluxBase-Core/FBStringEvent.class.st diff --git a/source/FluxBase-Core/FBActivation.class.st b/source/FluxBase-Core/FBActivation.class.st index 1f7d415..c10c755 100644 --- a/source/FluxBase-Core/FBActivation.class.st +++ b/source/FluxBase-Core/FBActivation.class.st @@ -78,17 +78,6 @@ FBActivation >> printOn: aStream [ ] -{ #category : 'accessing' } -FBActivation >> returnValue: anInteger [ - self shouldBeImplemented. -] - -{ #category : 'as yet unclassified' } -FBActivation >> suspend [ - self waiting. - executor addWaiting: node -] - { #category : 'accessing' } FBActivation >> value [ diff --git a/source/FluxBase-Core/FBBaseActivation.class.st b/source/FluxBase-Core/FBBaseActivation.class.st index b6773c8..b7ae7ae 100644 --- a/source/FluxBase-Core/FBBaseActivation.class.st +++ b/source/FluxBase-Core/FBBaseActivation.class.st @@ -97,12 +97,6 @@ FBBaseActivation >> flowInstance [ ^ executor flowInstance ] -{ #category : 'as yet unclassified' } -FBBaseActivation >> followAll: aCollection [ - aCollection do: [ :transition | - self followTransition: transition ] -] - { #category : 'as yet unclassified' } FBBaseActivation >> followAllOutgoing [ self followAllOutgoingInSplit: self token split diff --git a/source/FluxBase-Core/FBFlowEvent.class.st b/source/FluxBase-Core/FBFlowEvent.class.st index 2deb95b..ad137f6 100644 --- a/source/FluxBase-Core/FBFlowEvent.class.st +++ b/source/FluxBase-Core/FBFlowEvent.class.st @@ -26,12 +26,6 @@ FBFlowEvent >> initialize [ timestamp := DateAndTime now ] -{ #category : 'accessing' } -FBFlowEvent >> logTrace [ - - ^ self subclassResponsibility -] - { #category : 'accessing' } FBFlowEvent >> message [ diff --git a/source/FluxBase-Core/FBFlowExecutor.class.st b/source/FluxBase-Core/FBFlowExecutor.class.st index e4ad973..08cb502 100644 --- a/source/FluxBase-Core/FBFlowExecutor.class.st +++ b/source/FluxBase-Core/FBFlowExecutor.class.st @@ -2,9 +2,7 @@ Class { #name : 'FBFlowExecutor', #superclass : 'FBBaseExecutor', #instVars : [ - 'initialValue', - 'state', - 'otherExecutor' + 'initialValue' ], #category : 'FluxBase-Core-Model', #package : 'FluxBase-Core', diff --git a/source/FluxBase-Core/FBNode.class.st b/source/FluxBase-Core/FBNode.class.st index ba0191d..5eb90b0 100644 --- a/source/FluxBase-Core/FBNode.class.st +++ b/source/FluxBase-Core/FBNode.class.st @@ -206,11 +206,6 @@ FBNode >> flow: aFBFlow [ ] -{ #category : 'testing' } -FBNode >> hasOutgoing [ - ^ outgoing notEmpty -] - { #category : 'accessing' } FBNode >> id [ ^ id diff --git a/source/FluxBase-Core/FBNodeActivationFinished.class.st b/source/FluxBase-Core/FBNodeActivationFinished.class.st deleted file mode 100644 index 762e450..0000000 --- a/source/FluxBase-Core/FBNodeActivationFinished.class.st +++ /dev/null @@ -1,19 +0,0 @@ -Class { - #name : 'FBNodeActivationFinished', - #superclass : 'FBNodeActivationEvent', - #category : 'FluxBase-Core-Event', - #package : 'FluxBase-Core', - #tag : 'Event' -} - -{ #category : 'printing' } -FBNodeActivationFinished >> printOn: aStream [ - super printOn: aStream. - aStream << ' finished' -] - -{ #category : 'accessing' } -FBNodeActivationFinished >> type [ - - ^ #activationFinished -] diff --git a/source/FluxBase-Core/FBStringEvent.class.st b/source/FluxBase-Core/FBStringEvent.class.st deleted file mode 100644 index 3ef0116..0000000 --- a/source/FluxBase-Core/FBStringEvent.class.st +++ /dev/null @@ -1,33 +0,0 @@ -Class { - #name : 'FBStringEvent', - #superclass : 'FBFlowEvent', - #instVars : [ - 'description' - ], - #category : 'FluxBase-Core-Event', - #package : 'FluxBase-Core', - #tag : 'Event' -} - -{ #category : 'accessing' } -FBStringEvent >> description: aString [ - description := aString -] - -{ #category : 'printing' } -FBStringEvent >> message [ - - ^ description -] - -{ #category : 'printing' } -FBStringEvent >> printOn: aStream [ - super printOn: aStream. - aStream << description -] - -{ #category : 'accessing' } -FBStringEvent >> type [ - - ^ #string -]