Area
Other
Question
Hi. it's me again. here to bother you about the performance of ritsulib!
i have been optimizing a mod i am working on and thought now is a great time to grab some more data for ritsulib while i am at it. on my chart ritsulib is sitting at about 12% total cpu usage. last time i contacted you so i was only new to using the visual studio profiler, but i have learnt my way around what is what now.
i can see that 5.75% cpu usage (about half the ritsulibs entire performance) is coming from
dynamicClass.STS2RitsuLib.Combat.SecondaryResources.NSecondaryResourceCardCostUi.Refresh_Patch1(00007FFA9C789558, 00007FFA9C78ED90, 00007FFA9C78E8F8)
which is making a TON of expensive godot engine calls using.
Godot.NativeCalls.godot_icall_2_110(int, int, Godot.NativeInterop.godot_string_name, Godot.Color*)
i have not dug into any of your code just yet. i would be more then happy to check it out. and try to provide some better information, or even provide some performance updates. but massive word of warning "i use allot of AI" and i would personalty not accept any of my work before you give it a look over, especially with a library mod that allot of other mods depend on, and especially considering that, i am extremely unfamiliar with ritsulibs code.
regardless i believe these functions would be the next best target for performance since you have the most to gain, from optimizing a single file. performance elsewhere is scattered and would likely require 10x more effort for marginal improvements.
please let me know if you require any further information. or would like any of my assistance in the future. as always love your work! you are a boon to the community!
Context
Area
Other
Question
Hi. it's me again. here to bother you about the performance of ritsulib!
i have been optimizing a mod i am working on and thought now is a great time to grab some more data for ritsulib while i am at it. on my chart ritsulib is sitting at about 12% total cpu usage. last time i contacted you so i was only new to using the visual studio profiler, but i have learnt my way around what is what now.
i can see that 5.75% cpu usage (about half the ritsulibs entire performance) is coming from
dynamicClass.STS2RitsuLib.Combat.SecondaryResources.NSecondaryResourceCardCostUi.Refresh_Patch1(00007FFA9C789558, 00007FFA9C78ED90, 00007FFA9C78E8F8)
which is making a TON of expensive godot engine calls using.
Godot.NativeCalls.godot_icall_2_110(int, int, Godot.NativeInterop.godot_string_name, Godot.Color*)
i have not dug into any of your code just yet. i would be more then happy to check it out. and try to provide some better information, or even provide some performance updates. but massive word of warning "i use allot of AI" and i would personalty not accept any of my work before you give it a look over, especially with a library mod that allot of other mods depend on, and especially considering that, i am extremely unfamiliar with ritsulibs code.
regardless i believe these functions would be the next best target for performance since you have the most to gain, from optimizing a single file. performance elsewhere is scattered and would likely require 10x more effort for marginal improvements.
please let me know if you require any further information. or would like any of my assistance in the future. as always love your work! you are a boon to the community!
Context