From fdad28731e67dfc25b28b2a64c52870f08599fa1 Mon Sep 17 00:00:00 2001 From: Drew Davis Date: Thu, 19 Nov 2026 08:39:36 -0500 Subject: [PATCH] feat: Remove adhoc filters feature toggle --- .changeset/adhoc-filters-ga.md | 5 +++++ packages/app/.env.development | 1 - packages/app/playwright.config.ts | 4 ++-- packages/app/src/__tests__/hdxDebug.test.ts | 1 - .../DashboardFiltersModal/DashboardFilterEditForm.tsx | 11 ++--------- packages/app/src/config.ts | 2 -- packages/app/src/hdxDebug.ts | 2 -- 7 files changed, 9 insertions(+), 17 deletions(-) create mode 100644 .changeset/adhoc-filters-ga.md diff --git a/.changeset/adhoc-filters-ga.md b/.changeset/adhoc-filters-ga.md new file mode 100644 index 0000000000..a8bdcaeb6c --- /dev/null +++ b/.changeset/adhoc-filters-ga.md @@ -0,0 +1,5 @@ +--- +'@hyperdx/app': patch +--- + +feat: Removing the NEXT_PUBLIC_ENABLE_ADHOC_FILTERS flag diff --git a/packages/app/.env.development b/packages/app/.env.development index 81ff15ce3b..af4a79ce0f 100644 --- a/packages/app/.env.development +++ b/packages/app/.env.development @@ -13,5 +13,4 @@ NEXT_PUBLIC_OTEL_EXPORTER_OTLP_ENDPOINT="http://localhost:${HDX_DEV_OTEL_HTTP_PO # NEXT_PUBLIC_OTEL_EXPORTER_OTLP_METRICS_ENDPOINT= # NEXT_PUBLIC_OTEL_EXPORTER_OTLP_LOGS_ENDPOINT= NEXT_PUBLIC_ENABLE_PROMQL=true -NEXT_PUBLIC_ENABLE_ADHOC_FILTERS=true NEXT_PUBLIC_ENABLE_ALERT_DETAILS=true diff --git a/packages/app/playwright.config.ts b/packages/app/playwright.config.ts index c5bca85edd..b0078376a8 100644 --- a/packages/app/playwright.config.ts +++ b/packages/app/playwright.config.ts @@ -114,8 +114,8 @@ export default defineConfig({ { // Full UI: Alerts + Dashboards. Not local mode; Alerts enabled; command: USE_DEV - ? `${NO_SELF_TELEMETRY} SERVER_URL=http://localhost:${API_PORT} PORT=${APP_PORT} NEXT_DIST_DIR=.next-e2e NEXT_PUBLIC_ENABLE_ALERT_DETAILS=true NEXT_PUBLIC_ENABLE_PROMQL=true NEXT_PUBLIC_ENABLE_ADHOC_FILTERS=true next dev --webpack` - : `${NO_SELF_TELEMETRY} SERVER_URL=http://localhost:${API_PORT} PORT=${APP_PORT} NEXT_DIST_DIR=.next-e2e NEXT_PUBLIC_ENABLE_ALERT_DETAILS=true NEXT_PUBLIC_ENABLE_PROMQL=true NEXT_PUBLIC_ENABLE_ADHOC_FILTERS=true yarn build && ${NO_SELF_TELEMETRY} SERVER_URL=http://localhost:${API_PORT} PORT=${APP_PORT} NEXT_DIST_DIR=.next-e2e NEXT_PUBLIC_ENABLE_ALERT_DETAILS=true NEXT_PUBLIC_ENABLE_PROMQL=true NEXT_PUBLIC_ENABLE_ADHOC_FILTERS=true yarn start`, + ? `${NO_SELF_TELEMETRY} SERVER_URL=http://localhost:${API_PORT} PORT=${APP_PORT} NEXT_DIST_DIR=.next-e2e NEXT_PUBLIC_ENABLE_ALERT_DETAILS=true NEXT_PUBLIC_ENABLE_PROMQL=true next dev --webpack` + : `${NO_SELF_TELEMETRY} SERVER_URL=http://localhost:${API_PORT} PORT=${APP_PORT} NEXT_DIST_DIR=.next-e2e NEXT_PUBLIC_ENABLE_ALERT_DETAILS=true NEXT_PUBLIC_ENABLE_PROMQL=true yarn build && ${NO_SELF_TELEMETRY} SERVER_URL=http://localhost:${API_PORT} PORT=${APP_PORT} NEXT_DIST_DIR=.next-e2e NEXT_PUBLIC_ENABLE_ALERT_DETAILS=true NEXT_PUBLIC_ENABLE_PROMQL=true yarn start`, port: parseInt(APP_PORT, 10), reuseExistingServer: !process.env.CI, timeout: APP_SERVER_STARTUP_TIMEOUT_MS, diff --git a/packages/app/src/__tests__/hdxDebug.test.ts b/packages/app/src/__tests__/hdxDebug.test.ts index a0900c111b..f6aa9b8107 100644 --- a/packages/app/src/__tests__/hdxDebug.test.ts +++ b/packages/app/src/__tests__/hdxDebug.test.ts @@ -4,7 +4,6 @@ const baseConfig = { APP_VERSION: '9.9.9', BASE_PATH: '', - IS_ADHOC_FILTERS_ENABLED: false, IS_ALERT_DETAILS_ENABLED: false, IS_CLICKHOUSE_BUILD: false, IS_LLM_COST_ENABLED: false, diff --git a/packages/app/src/components/DashboardFiltersModal/DashboardFilterEditForm.tsx b/packages/app/src/components/DashboardFiltersModal/DashboardFilterEditForm.tsx index 848a3c326d..43f9022460 100644 --- a/packages/app/src/components/DashboardFiltersModal/DashboardFilterEditForm.tsx +++ b/packages/app/src/components/DashboardFiltersModal/DashboardFilterEditForm.tsx @@ -28,7 +28,7 @@ import { ErrorBoundary } from '@/components/Error/ErrorBoundary'; import { CheckBoxControlled } from '@/components/InputControlled'; import SelectControlled from '@/components/SelectControlled'; import { SqlVariablesProvider } from '@/components/SQLEditor/variableCompletions'; -import { IS_ADHOC_FILTERS_ENABLED, IS_PROMQL_ENABLED } from '@/config'; +import { IS_PROMQL_ENABLED } from '@/config'; import { useConfirm } from '@/useConfirm'; import { useZIndex } from '@/zIndex'; @@ -62,14 +62,7 @@ const FILTER_TYPE_OPTIONS = [ }, ] : []), - ...(IS_ADHOC_FILTERS_ENABLED - ? [ - { - value: DashboardFilterType.enum.ADHOC, - label: 'Ad hoc keys and values', - }, - ] - : []), + { value: DashboardFilterType.enum.ADHOC, label: 'Ad hoc keys and values' }, { value: DashboardFilterType.enum.DATA_SOURCE, label: 'Data source' }, { value: DashboardFilterType.enum.CONNECTION, label: 'Connection' }, ]; diff --git a/packages/app/src/config.ts b/packages/app/src/config.ts index c0ce75adf6..c416d1e660 100644 --- a/packages/app/src/config.ts +++ b/packages/app/src/config.ts @@ -82,8 +82,6 @@ export const IS_METRICS_ENABLED = true; export const IS_MTVIEWS_ENABLED = false; export const IS_SESSIONS_ENABLED = true; export const IS_PROMQL_ENABLED = env('NEXT_PUBLIC_ENABLE_PROMQL') === 'true'; -export const IS_ADHOC_FILTERS_ENABLED = - env('NEXT_PUBLIC_ENABLE_ADHOC_FILTERS') === 'true'; // Suffix for the tab title/sidebar pill. Shown in full in the page title; // only truncated visually (via CSS ellipsis) in the sidebar, where space is // constrained. Internal whitespace is collapsed so it displays consistently diff --git a/packages/app/src/hdxDebug.ts b/packages/app/src/hdxDebug.ts index d2d3c5e5c2..4bacda758a 100644 --- a/packages/app/src/hdxDebug.ts +++ b/packages/app/src/hdxDebug.ts @@ -5,7 +5,6 @@ import { APP_VERSION, BASE_PATH, INSTANCE_LABEL, - IS_ADHOC_FILTERS_ENABLED, IS_ALERT_DETAILS_ENABLED, IS_CLICKHOUSE_BUILD, IS_DEV, @@ -86,7 +85,6 @@ const staticFeatures: Record = { promql: IS_PROMQL_ENABLED, llmCost: IS_LLM_COST_ENABLED, alertDetails: IS_ALERT_DETAILS_ENABLED, - adhocFilters: IS_ADHOC_FILTERS_ENABLED, instanceLabel: Boolean(INSTANCE_LABEL), };