diff --git a/apps/desktop/package.json b/apps/desktop/package.json index e7685d6f0..647047e31 100644 --- a/apps/desktop/package.json +++ b/apps/desktop/package.json @@ -20,7 +20,7 @@ "class-variance-authority": "^0.7.1", "clsx": "^2.1.1", "lucide-react": "^1.24.0", - "pdfjs-dist": "6.1.200", + "pdfjs-dist": "^6.2.108", "react": "^19.2.4", "react-dom": "^19.2.7", "sonner": "^2.0.7", diff --git a/apps/desktop/src/features/score/ScoreViewer.test.tsx b/apps/desktop/src/features/score/ScoreViewer.test.tsx index 3ac2dd605..71985dd7f 100644 --- a/apps/desktop/src/features/score/ScoreViewer.test.tsx +++ b/apps/desktop/src/features/score/ScoreViewer.test.tsx @@ -16,7 +16,9 @@ vi.mock("../../i18n", () => ({ scoreViewerFailedTitle: "Could not display the score", scoreViewerRetry: "Retry", scoreViewerPrevPage: "Previous page", + scoreViewerPrevPageDisabled: "Previous page (Unavailable)", scoreViewerNextPage: "Next page", + scoreViewerNextPageDisabled: "Next page (Unavailable)", scoreViewerPageIndicator: "Page {current} of {total}", scoreViewerZoomIn: "Zoom in", scoreViewerZoomOut: "Zoom out", @@ -120,8 +122,8 @@ describe("ScoreViewer", () => { expect(page.render).toHaveBeenCalled(); }); expect(page.getViewport).toHaveBeenCalledWith({ scale: 1 }); - expect(screen.getByRole("button", { name: "Previous page" })).toBeDisabled(); - expect(screen.getByRole("button", { name: "Next page" })).toBeEnabled(); + expect(screen.getByRole("button", { name: "Previous page" })).toHaveAttribute("aria-disabled", "true"); + expect(screen.getByRole("button", { name: "Next page" })).not.toHaveAttribute("aria-disabled", "true"); }); it("shows the file name when provided", async () => { @@ -174,14 +176,22 @@ describe("ScoreViewer", () => { expect(await screen.findByText("Page 1 of 3")).toBeInTheDocument(); const previousButton = screen.getByRole("button", { name: "Previous page" }); const nextButton = screen.getByRole("button", { name: "Next page" }); - expect(previousButton).toBeDisabled(); + expect(previousButton).toHaveAttribute("aria-disabled", "true"); + const preventDefaultSpyPrev = vi.spyOn(Event.prototype, "preventDefault"); + fireEvent.click(previousButton); + expect(preventDefaultSpyPrev).toHaveBeenCalled(); + preventDefaultSpyPrev.mockRestore(); fireEvent.click(nextButton); expect(screen.getByText("Page 2 of 3")).toBeInTheDocument(); fireEvent.click(nextButton); expect(screen.getByText("Page 3 of 3")).toBeInTheDocument(); - expect(nextButton).toBeDisabled(); + expect(nextButton).toHaveAttribute("aria-disabled", "true"); + const preventDefaultSpyNext = vi.spyOn(Event.prototype, "preventDefault"); + fireEvent.click(nextButton); + expect(preventDefaultSpyNext).toHaveBeenCalled(); + preventDefaultSpyNext.mockRestore(); await waitFor(() => { expect(doc.getPage).toHaveBeenCalledWith(3); diff --git a/apps/desktop/src/features/score/ScoreViewer.tsx b/apps/desktop/src/features/score/ScoreViewer.tsx index 82692469e..9ae55363b 100644 --- a/apps/desktop/src/features/score/ScoreViewer.tsx +++ b/apps/desktop/src/features/score/ScoreViewer.tsx @@ -292,8 +292,9 @@ export function ScoreViewer({ data, fileName, onStatusChange }: ScoreViewerProps size="icon-lg" className="size-14" aria-label={t("scoreViewerPrevPage")} - disabled={pageNumber <= 1} - onClick={goToPreviousPage} + aria-disabled={pageNumber <= 1 ? "true" : undefined} + onClick={pageNumber <= 1 ? (e) => e.preventDefault() : goToPreviousPage} + title={pageNumber <= 1 ? t("scoreViewerPrevPageDisabled") : t("scoreViewerPrevPage")} >