From 1865558455b2c6ddeacd89820a95e4624ed96df6 Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Mon, 10 Aug 2026 04:14:15 +0000 Subject: [PATCH 1/5] =?UTF-8?q?=F0=9F=8E=A8=20Palette:=20=EC=95=85?= =?UTF-8?q?=EB=B3=B4=20=EB=B7=B0=EC=96=B4=EC=9D=98=20=EB=B9=84=ED=99=9C?= =?UTF-8?q?=EC=84=B1=ED=99=94=EB=90=9C=20=EB=B2=84=ED=8A=BC=EC=97=90=20?= =?UTF-8?q?=EB=8C=80=ED=95=9C=20=EC=A0=91=EA=B7=BC=EC=84=B1=20=EB=B0=8F=20?= =?UTF-8?q?=ED=88=B4=ED=8C=81=20=EA=B0=9C=EC=84=A0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../src/features/score/ScoreViewer.test.tsx | 18 ++++++++++++++---- .../desktop/src/features/score/ScoreViewer.tsx | 10 ++++++---- apps/desktop/src/locales/en/common.json | 4 +++- apps/desktop/src/locales/ko/common.json | 4 +++- 4 files changed, 26 insertions(+), 10 deletions(-) diff --git a/apps/desktop/src/features/score/ScoreViewer.test.tsx b/apps/desktop/src/features/score/ScoreViewer.test.tsx index 3ac2dd605..71985dd7f 100644 --- a/apps/desktop/src/features/score/ScoreViewer.test.tsx +++ b/apps/desktop/src/features/score/ScoreViewer.test.tsx @@ -16,7 +16,9 @@ vi.mock("../../i18n", () => ({ scoreViewerFailedTitle: "Could not display the score", scoreViewerRetry: "Retry", scoreViewerPrevPage: "Previous page", + scoreViewerPrevPageDisabled: "Previous page (Unavailable)", scoreViewerNextPage: "Next page", + scoreViewerNextPageDisabled: "Next page (Unavailable)", scoreViewerPageIndicator: "Page {current} of {total}", scoreViewerZoomIn: "Zoom in", scoreViewerZoomOut: "Zoom out", @@ -120,8 +122,8 @@ describe("ScoreViewer", () => { expect(page.render).toHaveBeenCalled(); }); expect(page.getViewport).toHaveBeenCalledWith({ scale: 1 }); - expect(screen.getByRole("button", { name: "Previous page" })).toBeDisabled(); - expect(screen.getByRole("button", { name: "Next page" })).toBeEnabled(); + expect(screen.getByRole("button", { name: "Previous page" })).toHaveAttribute("aria-disabled", "true"); + expect(screen.getByRole("button", { name: "Next page" })).not.toHaveAttribute("aria-disabled", "true"); }); it("shows the file name when provided", async () => { @@ -174,14 +176,22 @@ describe("ScoreViewer", () => { expect(await screen.findByText("Page 1 of 3")).toBeInTheDocument(); const previousButton = screen.getByRole("button", { name: "Previous page" }); const nextButton = screen.getByRole("button", { name: "Next page" }); - expect(previousButton).toBeDisabled(); + expect(previousButton).toHaveAttribute("aria-disabled", "true"); + const preventDefaultSpyPrev = vi.spyOn(Event.prototype, "preventDefault"); + fireEvent.click(previousButton); + expect(preventDefaultSpyPrev).toHaveBeenCalled(); + preventDefaultSpyPrev.mockRestore(); fireEvent.click(nextButton); expect(screen.getByText("Page 2 of 3")).toBeInTheDocument(); fireEvent.click(nextButton); expect(screen.getByText("Page 3 of 3")).toBeInTheDocument(); - expect(nextButton).toBeDisabled(); + expect(nextButton).toHaveAttribute("aria-disabled", "true"); + const preventDefaultSpyNext = vi.spyOn(Event.prototype, "preventDefault"); + fireEvent.click(nextButton); + expect(preventDefaultSpyNext).toHaveBeenCalled(); + preventDefaultSpyNext.mockRestore(); await waitFor(() => { expect(doc.getPage).toHaveBeenCalledWith(3); diff --git a/apps/desktop/src/features/score/ScoreViewer.tsx b/apps/desktop/src/features/score/ScoreViewer.tsx index 82692469e..9ae55363b 100644 --- a/apps/desktop/src/features/score/ScoreViewer.tsx +++ b/apps/desktop/src/features/score/ScoreViewer.tsx @@ -292,8 +292,9 @@ export function ScoreViewer({ data, fileName, onStatusChange }: ScoreViewerProps size="icon-lg" className="size-14" aria-label={t("scoreViewerPrevPage")} - disabled={pageNumber <= 1} - onClick={goToPreviousPage} + aria-disabled={pageNumber <= 1 ? "true" : undefined} + onClick={pageNumber <= 1 ? (e) => e.preventDefault() : goToPreviousPage} + title={pageNumber <= 1 ? t("scoreViewerPrevPageDisabled") : t("scoreViewerPrevPage")} >