From 626bccf2f0120f2e427e6259892629a6b85c59e1 Mon Sep 17 00:00:00 2001 From: Matt Drozt Date: Mon, 20 Apr 2026 18:35:52 -0500 Subject: [PATCH 1/3] Remove implicit redefinition of variable --- smartsim/entity/model.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/smartsim/entity/model.py b/smartsim/entity/model.py index 0cd37b6a8..93ed9f3c5 100644 --- a/smartsim/entity/model.py +++ b/smartsim/entity/model.py @@ -460,8 +460,8 @@ def _stringify_id(_id: int) -> str: return ",".join(_stringify_id(i) for i in range(cpus)) if not pin_ids: return None - pin_ids = ((x,) if isinstance(x, int) else x for x in pin_ids) - to_fmt = itertools.chain.from_iterable(pin_ids) + pin_ids_ = ((x,) if isinstance(x, int) else x for x in pin_ids) + to_fmt = itertools.chain.from_iterable(pin_ids_) return ",".join(sorted({_stringify_id(x) for x in to_fmt})) def params_to_args(self) -> None: From d36943c389da5f214200badce28185173425dfd7 Mon Sep 17 00:00:00 2001 From: Matt Drozt Date: Mon, 20 Apr 2026 18:39:01 -0500 Subject: [PATCH 2/3] Remove unused suppression --- pyproject.toml | 1 - 1 file changed, 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index d5e797d42..19925ab9a 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -131,7 +131,6 @@ module = [ "keras", "torch", "smartsim.ml.torch.*", # must solve/ignore inheritance issues - "watchdog", "dragon.*", ] ignore_missing_imports = true From 1a47a2b68e0c27f1ae5eabd2782d73f284de54dd Mon Sep 17 00:00:00 2001 From: Matt Drozt Date: Mon, 20 Apr 2026 18:44:42 -0500 Subject: [PATCH 3/3] Add changelog entry --- doc/changelog.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/changelog.md b/doc/changelog.md index a1bca3ade..8ffc73c5e 100644 --- a/doc/changelog.md +++ b/doc/changelog.md @@ -97,6 +97,8 @@ Detailed Notes ([SmartSim-PR738](https://github.com/CrayLabs/SmartSim/pull/738)) - Removes an undocumented and unused dependency from the testing suite. ([SmartSim-PR792](https://github.com/CrayLabs/SmartSim/pull/792)) +- Address potential type errors in SmartSim. + ([SmartSim-PR798](https://github.com/CrayLabs/SmartSim/pull/798)) ### 0.8.0