From 418d18b24f747c2da81122ab8e889052a36cd431 Mon Sep 17 00:00:00 2001
From: Cylae <13425054+Cylae@users.noreply.github.com>
Date: Wed, 9 Sep 2026 00:52:03 +0000
Subject: [PATCH] Remove unused public function `validate_port_str`
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Remove `validate_port_str` from `server_manager/src/core/validate.rs` and its associated unit test assertions in `contract_input_validation.rs`.

- 🎯 What: Removed dead code `validate_port_str` function and cleaned up associated test code.
- 💡 Why: The function was unreferenced across the codebase; removing it reduces surface area and improves maintainability.
- ✅ Verification: Passed all unit/contract tests, clippy lints, and format checks (`cargo test`, `cargo clippy`, `cargo fmt`).
---
 server_manager/src/core/validate.rs               | 9 ---------
 server_manager/tests/contract_input_validation.rs | 9 ++-------
 2 files changed, 2 insertions(+), 16 deletions(-)

diff --git a/server_manager/src/core/validate.rs b/server_manager/src/core/validate.rs
index 9c4898e..c27b402 100644
--- a/server_manager/src/core/validate.rs
+++ b/server_manager/src/core/validate.rs
@@ -122,15 +122,6 @@ pub fn validate_port(port: u32) -> Result<u16> {
     }
 }
 
-/// Validates a port string slice (e.g. "8080").
-pub fn validate_port_str(port_str: &str) -> Result<u16> {
-    let port: u32 = port_str
-        .trim()
-        .parse()
-        .map_err(|_| anyhow::anyhow!("Validation error: invalid port format '{}'", port_str))?;
-    validate_port(port)
-}
-
 /// Validates an IPv4 or IPv6 address.
 pub fn validate_ip(ip_str: &str) -> Result<IpAddr> {
     ip_str
diff --git a/server_manager/tests/contract_input_validation.rs b/server_manager/tests/contract_input_validation.rs
index 7b9da2d..dac505c 100644
--- a/server_manager/tests/contract_input_validation.rs
+++ b/server_manager/tests/contract_input_validation.rs
@@ -1,6 +1,6 @@
 use server_manager::core::validate::{
-    validate_domain, validate_ip, validate_port, validate_port_str, validate_safe_path,
-    validate_service_name, validate_username,
+    validate_domain, validate_ip, validate_port, validate_safe_path, validate_service_name,
+    validate_username,
 };
 use std::path::Path;
 
@@ -80,11 +80,6 @@ fn test_validate_port() {
     assert!(validate_port(0).is_err());
     assert!(validate_port(65536).is_err());
     assert!(validate_port(100000).is_err());
-
-    // String parsing
-    assert_eq!(validate_port_str("8099").unwrap_or_default(), 8099);
-    assert!(validate_port_str("abc").is_err());
-    assert!(validate_port_str("80;rm -rf").is_err());
 }
 
 #[test]