PR #1333 introduced crates/fbuild-library/src/library/clearcore_core.rs implementing the shared crate::Package / core traits whose signatures are typed in std::path::PathBuf (e.g. fn ensure_installed(&self) -> fbuild_core::Result<PathBuf>). The new file therefore trips ban_std_pathbuf (11 deny errors), which has kept Dylint red for every PR merged since #1333.
Migrating just this file to fbuild_core::path::NormalizedPath is not possible without changing trait signatures shared by all library core files (sam_core.rs, apollo3_core.rs, …) — a repo-wide migration that belongs in its own effort.
Per the rollout strategy in dylints/ban_std_pathbuf/src/allowlist.txt, this files the issue for a justified entry:
- add
crates/fbuild-library/src/library/clearcore_core.rs to the allowlist with an inline justification comment referencing this issue
- remove the entry when the shared Package/core traits migrate to
NormalizedPath
Sibling precedent: every existing library core file is already allowlisted as legacy.
PR #1333 introduced
crates/fbuild-library/src/library/clearcore_core.rsimplementing the sharedcrate::Package/ core traits whose signatures are typed instd::path::PathBuf(e.g.fn ensure_installed(&self) -> fbuild_core::Result<PathBuf>). The new file therefore tripsban_std_pathbuf(11 deny errors), which has kept Dylint red for every PR merged since #1333.Migrating just this file to
fbuild_core::path::NormalizedPathis not possible without changing trait signatures shared by all library core files (sam_core.rs,apollo3_core.rs, …) — a repo-wide migration that belongs in its own effort.Per the rollout strategy in
dylints/ban_std_pathbuf/src/allowlist.txt, this files the issue for a justified entry:crates/fbuild-library/src/library/clearcore_core.rsto the allowlist with an inline justification comment referencing this issueNormalizedPathSibling precedent: every existing library core file is already allowlisted as legacy.