From b44baf45506c75e16a7598a80648785d87c1f265 Mon Sep 17 00:00:00 2001
From: Seungpyo1007 <rush94434@gmail.com>
Date: Wed, 16 Sep 2026 12:18:55 +0900
Subject: [PATCH 1/2] feat(seed): derive primary keys from the slug instead of
 a counter
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The dump exposes `id`, and an autoincrement counter renumbered every row
after an inserted record, so a regenerated dump rewrote pages whose data
had not changed. That is what made TechAPI #180 ~1M files: GitHub could
render neither its diff nor its merge (502), and the dump PR had to be
merged blind.

Ids are now blake2b(table:slug) truncated to 48 bits — deterministic,
independent of insertion order, and inside the JSON-safe integer range.
A collision rehashes with a suffix rather than falling back to a counter.

Refs #1
---
 app/seed.py                   | 53 +++++++++++++++++++++++++++--------
 tests/unit/test_stable_ids.py | 30 ++++++++++++++++++++
 2 files changed, 72 insertions(+), 11 deletions(-)
 create mode 100644 tests/unit/test_stable_ids.py

diff --git a/app/seed.py b/app/seed.py
index c11cae0..942d426 100644
--- a/app/seed.py
+++ b/app/seed.py
@@ -15,6 +15,7 @@
 
 from __future__ import annotations
 
+import hashlib
 import json
 from datetime import date
 from pathlib import Path
@@ -56,6 +57,31 @@ def _load_dir(subdir: Path) -> list[dict[str, Any]]:
     return items
 
 
+# Primary keys are derived from the slug instead of an autoincrement counter.
+# The dump exposes `id`, so with a counter one inserted record renumbered every
+# row after it and the regenerated dump rewrote pages whose data never changed
+# (TechAPI #180: ~1M files, GitHub could not even render the diff).
+_ID_BITS = 48  # < 2**53, so the value survives JSON round-trips intact
+
+
+def _stable_id(table: str, slug: str, taken: set[int]) -> int:
+    """Deterministic id for ``table``/``slug``, avoiding ids already assigned."""
+    attempt = 0
+    while True:
+        key = f"{table}:{slug}" if attempt == 0 else f"{table}:{slug}#{attempt}"
+        digest = hashlib.blake2b(key.encode("utf-8"), digest_size=8).digest()
+        value = int.from_bytes(digest, "big") % (1 << _ID_BITS) or 1
+        if value not in taken:
+            taken.add(value)
+            return value
+        attempt += 1  # collision: rehash rather than fall back to a counter
+
+
+def _with_id(obj: SQLModel, taken: set[int]) -> SQLModel:
+    obj.id = _stable_id(type(obj).__tablename__, obj.slug, taken)  # type: ignore[attr-defined]
+    return obj
+
+
 def _existing_slugs(session: Session, model: type[SQLModel]) -> set[str]:
     rows = session.exec(select(model)).all()
     return {row.slug for row in rows}  # type: ignore[attr-defined]  # all data models have slug
@@ -63,6 +89,8 @@ def _existing_slugs(session: Session, model: type[SQLModel]) -> set[str]:
 
 def seed(session: Session, data_dir: Path = DATA_DIR) -> dict[str, int]:
     """Idempotently insert seed data. Returns counts of newly inserted rows."""
+    # Ids assigned in this run; only used to break hash collisions.
+    taken: set[int] = set()
     counts = {
         "brands": 0,
         "socs": 0,
@@ -87,7 +115,7 @@ def seed(session: Session, data_dir: Path = DATA_DIR) -> dict[str, int]:
         # `categories` lives in the JSON for browsing/validation only — the Brand
         # table model does not (yet) carry it, so drop before construction.
         record.pop("categories", None)
-        session.add(Brand(**record))
+        session.add(_with_id(Brand(**record), taken))
         counts["brands"] += 1
     session.commit()
 
@@ -104,7 +132,7 @@ def seed(session: Session, data_dir: Path = DATA_DIR) -> dict[str, int]:
             raise ValueError(
                 f"SoC '{record['slug']}' references unknown brand '{manufacturer}'"
             )
-        session.add(SoC(manufacturer_id=manufacturer_id, **record))
+        session.add(_with_id(SoC(manufacturer_id=manufacturer_id, **record), taken))
         counts["socs"] += 1
     session.commit()
 
@@ -127,7 +155,8 @@ def seed(session: Session, data_dir: Path = DATA_DIR) -> dict[str, int]:
             raise ValueError(
                 f"Smartphone '{record['slug']}' references unknown SoC '{soc_slug}'"
             )
-        session.add(Smartphone(brand_id=brand_id, soc_id=soc_id, **record))
+        phone = Smartphone(brand_id=brand_id, soc_id=soc_id, **record)
+        session.add(_with_id(phone, taken))
         counts["smartphones"] += 1
     session.commit()
 
@@ -150,7 +179,8 @@ def seed_mobile_devices(subdir: str, model: type[SQLModel], count_key: str) -> N
                     f"{subdir.rstrip('s').title()} '{record['slug']}' "
                     f"references unknown SoC '{soc_slug}'"
                 )
-            session.add(model(brand_id=brand_id, soc_id=soc_id, **record))
+            device = model(brand_id=brand_id, soc_id=soc_id, **record)
+            session.add(_with_id(device, taken))
             counts[count_key] += 1
         session.commit()
 
@@ -169,7 +199,7 @@ def seed_mobile_devices(subdir: str, model: type[SQLModel], count_key: str) -> N
             raise ValueError(
                 f"GPU '{record['slug']}' references unknown brand '{manufacturer}'"
             )
-        session.add(DiscreteGPU(manufacturer_id=manufacturer_id, **record))
+        session.add(_with_id(DiscreteGPU(manufacturer_id=manufacturer_id, **record), taken))
         counts["gpus"] += 1
     session.commit()
 
@@ -184,7 +214,7 @@ def seed_mobile_devices(subdir: str, model: type[SQLModel], count_key: str) -> N
             raise ValueError(
                 f"CPU '{record['slug']}' references unknown brand '{manufacturer}'"
             )
-        session.add(CPU(manufacturer_id=manufacturer_id, **record))
+        session.add(_with_id(CPU(manufacturer_id=manufacturer_id, **record), taken))
         counts["cpus"] += 1
     session.commit()
 
@@ -213,7 +243,8 @@ def seed_mobile_devices(subdir: str, model: type[SQLModel], count_key: str) -> N
             raise ValueError(
                 f"Laptop '{record['slug']}' references unknown GPU '{gpu_slug}'"
             )
-        session.add(Laptop(brand_id=brand_id, cpu_id=cpu_id, gpu_id=gpu_id, **record))
+        laptop = Laptop(brand_id=brand_id, cpu_id=cpu_id, gpu_id=gpu_id, **record)
+        session.add(_with_id(laptop, taken))
         counts["laptops"] += 1
     session.commit()
 
@@ -228,7 +259,7 @@ def seed_mobile_devices(subdir: str, model: type[SQLModel], count_key: str) -> N
             raise ValueError(
                 f"Monitor '{record['slug']}' references unknown brand '{brand_slug}'"
             )
-        session.add(Monitor(brand_id=brand_id, **record))
+        session.add(_with_id(Monitor(brand_id=brand_id, **record), taken))
         counts["monitors"] += 1
     session.commit()
 
@@ -237,7 +268,7 @@ def seed_mobile_devices(subdir: str, model: type[SQLModel], count_key: str) -> N
     for record in _load_dir(data_dir / "game"):
         if record["slug"] in game_slugs:
             continue
-        session.add(Game(**record))
+        session.add(_with_id(Game(**record), taken))
         counts["games"] += 1
     session.commit()
 
@@ -246,7 +277,7 @@ def seed_mobile_devices(subdir: str, model: type[SQLModel], count_key: str) -> N
     for record in _load_dir(data_dir / "software"):
         if record["slug"] in software_slugs:
             continue
-        session.add(Software(**record))
+        session.add(_with_id(Software(**record), taken))
         counts["software"] += 1
     session.commit()
 
@@ -255,7 +286,7 @@ def seed_mobile_devices(subdir: str, model: type[SQLModel], count_key: str) -> N
     for record in _load_dir(data_dir / "website"):
         if record["slug"] in website_slugs:
             continue
-        session.add(Website(**record))
+        session.add(_with_id(Website(**record), taken))
         counts["websites"] += 1
     session.commit()
 
diff --git a/tests/unit/test_stable_ids.py b/tests/unit/test_stable_ids.py
new file mode 100644
index 0000000..a2bef13
--- /dev/null
+++ b/tests/unit/test_stable_ids.py
@@ -0,0 +1,30 @@
+"""Ids must depend only on table+slug, so a dump only changes what the data did."""
+
+from __future__ import annotations
+
+from app.seed import _stable_id
+
+
+def test_same_slug_same_id_regardless_of_insertion_order():
+    assert _stable_id("brands", "samsung", set()) == _stable_id("brands", "samsung", set())
+
+
+def test_inserting_a_record_does_not_renumber_the_others():
+    first_pass = {slug: _stable_id("cpus", slug, set()) for slug in ("a", "b", "c")}
+    taken: set[int] = set()
+    second_pass = {slug: _stable_id("cpus", slug, taken) for slug in ("a", "new", "b", "c")}
+    assert all(second_pass[slug] == first_pass[slug] for slug in first_pass)
+
+
+def test_same_slug_in_two_tables_gets_two_ids():
+    assert _stable_id("cpus", "a1", set()) != _stable_id("gpus", "a1", set())
+
+
+def test_collision_falls_back_to_a_rehash_not_a_duplicate():
+    first = _stable_id("brands", "samsung", set())
+    taken = {first}
+    assert _stable_id("brands", "samsung", taken) != first
+
+
+def test_id_fits_in_a_json_safe_integer():
+    assert 0 < _stable_id("games", "doom", set()) < 2**53

From e3bf18dfbeb478fa80739e699e5b81b526f51890 Mon Sep 17 00:00:00 2001
From: Seungpyo1007 <rush94434@gmail.com>
Date: Wed, 16 Sep 2026 12:29:51 +0900
Subject: [PATCH 2/2] fix(seed): type _with_id as Any so mypy sees the id
 assignment

Refs #1
---
 app/seed.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/seed.py b/app/seed.py
index 942d426..4febd15 100644
--- a/app/seed.py
+++ b/app/seed.py
@@ -77,8 +77,9 @@ def _stable_id(table: str, slug: str, taken: set[int]) -> int:
         attempt += 1  # collision: rehash rather than fall back to a counter
 
 
-def _with_id(obj: SQLModel, taken: set[int]) -> SQLModel:
-    obj.id = _stable_id(type(obj).__tablename__, obj.slug, taken)  # type: ignore[attr-defined]
+def _with_id(obj: Any, taken: set[int]) -> Any:
+    """Stamp a slug-derived id. Every data model has ``slug``; none are typed alike."""
+    obj.id = _stable_id(str(type(obj).__tablename__), obj.slug, taken)
     return obj