From 8a26f044f7fbb19b0df4077ab7c0b3ba30175968 Mon Sep 17 00:00:00 2001 From: Cody Ho Date: Mon, 16 Nov 2026 01:19:41 -0800 Subject: [PATCH] dart: poll the correct T8110 TLB command register It appears this is a typo in the original code that results in polling the wrong offset, 0x700 instead of 0x80. The value at 0x700 happens to also contain zero, and for most darts it appears that polling isn't required because by the time of the first poll the busy bit is already unset. The exception is the DCP on T8140 where this issue causes the DCP to fail to start. The Linux driver is already correct. Assisted-By: LLM Signed-off-by: Cody Ho --- src/dart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dart.c b/src/dart.c index 7401668a..44c1a108 100644 --- a/src/dart.c +++ b/src/dart.c @@ -141,7 +141,7 @@ static void dart_t8110_tlb_invalidate(dart_dev_t *dart) FIELD_PREP(DART_T8110_TLB_CMD_OP, DART_T8110_TLB_CMD_OP_FLUSH_SID) | FIELD_PREP(DART_T8110_TLB_CMD_STREAM, dart->device)); - if (poll32(dart->regs + DART_T8110_TLB_CMD_OP, DART_T8110_TLB_CMD_BUSY, 0, 100)) + if (poll32(dart->regs + DART_T8110_TLB_CMD, DART_T8110_TLB_CMD_BUSY, 0, 100)) printf("dart: DART_T8110_TLB_CMD_BUSY did not clear.\n"); }