diff --git a/.github/workflows/code-changelog-check.yml b/.github/workflows/code-changelog-check.yml index a2be5a7f..e2eeba26 100644 --- a/.github/workflows/code-changelog-check.yml +++ b/.github/workflows/code-changelog-check.yml @@ -22,7 +22,7 @@ env: # 'true' fails a PR that has no linked issue and no bypass. 'false' only # warns: flip it to 'true' in a follow-up PR once a release has run end to # end with the generated changelog. - CHANGELOG_LINK_ENFORCE: "false" + CHANGELOG_LINK_ENFORCE: "true" jobs: closing-issue: diff --git a/.github/workflows/docs/code-changelog-check.md b/.github/workflows/docs/code-changelog-check.md index d39e256f..1f74a9b1 100644 --- a/.github/workflows/docs/code-changelog-check.md +++ b/.github/workflows/docs/code-changelog-check.md @@ -16,7 +16,7 @@ Any pull request to `main` or `main-*` that is `opened`, `synchronize`d, `reopen - A maintainer can waive the rule with the `skip-release` label, which also skips the release on merge. The issues such a PR does close still get entries in the next release. - Dependabot PRs are exempt. - Issues labelled `kind/internal` or `kind/epic`, even together with a `kind/*` category, count as a link but get no entry, and an issue already listed in an earlier release is not listed again. Both are shown in the report. `skip-changelog` has no effect. -- The check is warn-only for now: `CHANGELOG_LINK_ENFORCE` is `'false'`. Setting it to `'true'` (a follow-up PR, once a release has run end to end) makes a PR with no linked issue and no bypass fail. +- The check is enforcing: `CHANGELOG_LINK_ENFORCE` is `'true'`, so a PR with no linked issue and no bypass fails. Set it back to `'false'` to make it warn-only. ## Jobs diff --git a/openspec/changes/generate-changelog-from-closing-issues/tasks.md b/openspec/changes/generate-changelog-from-closing-issues/tasks.md index c9389976..96e9e149 100644 --- a/openspec/changes/generate-changelog-from-closing-issues/tasks.md +++ b/openspec/changes/generate-changelog-from-closing-issues/tasks.md @@ -21,5 +21,5 @@ ## 4. End-to-end verification and rollout (tracked in #302 and #303) -- [ ] 4.1 Verify the check, the release preview comment, the empty-`[Unreleased]` bump and a real release run (InditexTech/docouture#302) -- [ ] 4.2 Add the check to branch protection, retire the `skip-changelog` label, update the `skip-release` label description, and flip `CHANGELOG_LINK_ENFORCE` after one release (InditexTech/docouture#303) +- [x] 4.1 Verify the check, the release preview comment, the empty-`[Unreleased]` bump and a real release run (InditexTech/docouture#302) +- [x] 4.2 Add the check to branch protection, retire the `skip-changelog` label, update the `skip-release` label description, and flip `CHANGELOG_LINK_ENFORCE` after one release (InditexTech/docouture#303)