From 13fd726f9e6c426259e33ce72afb11a03cecab9d Mon Sep 17 00:00:00 2001 From: domfournier Date: Thu, 1 Oct 2026 09:47:56 -0400 Subject: [PATCH 1/2] Add defaults to Options for version, icon and docs --- geoapps_utils/base.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/geoapps_utils/base.py b/geoapps_utils/base.py index 93a6fd4..3342a21 100644 --- a/geoapps_utils/base.py +++ b/geoapps_utils/base.py @@ -244,6 +244,12 @@ class Options(BaseModel): geoh5: Workspace monitoring_directory: str | Path | None = None out_group: UIJsonGroup | None = None + version: str | None = "0.0.0" + icon: str | None = "" + documentation: str | None = ( + "https://mirageoscience-geoh5py.readthedocs-hosted.com/en/latest/" + + "content/uijson_format/index.html" + ) _ui_json_class: ClassVar[type[UIJson]] = UIJson From 0ac65ba7074ce75eacf61dd36211177c4c182249 Mon Sep 17 00:00:00 2001 From: domfournier Date: Thu, 1 Oct 2026 11:02:02 -0400 Subject: [PATCH 2/2] Update unit test --- tests/dataclass_test.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/dataclass_test.py b/tests/dataclass_test.py index fb63982..fe94d27 100644 --- a/tests/dataclass_test.py +++ b/tests/dataclass_test.py @@ -62,10 +62,10 @@ def test_dataclass_valid_values(tmp_path): valid_parameters = get_params_dict(tmp_path / f"{__name__}.geoh5") model = Options(**valid_parameters) output_params = model.model_dump() - assert len(output_params) == len(valid_parameters) + assert len(output_params) == len(valid_parameters) + 3 - for k, v in output_params.items(): - assert valid_parameters[k] == v + for k, v in valid_parameters.items(): + assert output_params[k] == v def test_dataclass_invalid_values(tmp_path):