From 565ab1a3d98d45698d4a6a91c81b92d2de0dbcb4 Mon Sep 17 00:00:00 2001 From: Som Tripathi Date: Wed, 23 Sep 2026 18:36:31 -0500 Subject: [PATCH] docs(skills): use the services key in pair-github-pr The release-intent parser expects the keys in services/versions.json, where the suite version is "services". The skill still told agents to write "product", so both of its example blocks failed validate_pr.py. Signed-off-by: Som Tripathi --- .cursor/skills/pair-github-pr/SKILL.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.cursor/skills/pair-github-pr/SKILL.md b/.cursor/skills/pair-github-pr/SKILL.md index 71bcb9ce..2784d1dc 100644 --- a/.cursor/skills/pair-github-pr/SKILL.md +++ b/.cursor/skills/pair-github-pr/SKILL.md @@ -65,7 +65,7 @@ n/a n/a ### Bumps -- product: none +- services: none - nvpair-cluster-manager: none - nvpair-engine-manager: none - nvpair-errors: none @@ -83,21 +83,21 @@ n/a If `services/versions.json` gained or lost a component, edit that file in the pull request with ``, and -regenerate the bump key list (`product` + sorted component names). Extra or +regenerate the bump key list (`services` + sorted component names). Extra or missing keys fail the check. ## Shipping a product release 1. Set each touched component to `patch`, `minor`, or `major` (SemVer meaning in `VERSIONING.md`). Untouched components stay `none`. -2. Set `product` to a severity **≥** the highest component bump. UI-only - product notes may bump `product` while all components stay `none`. +2. Set `services` to a severity **≥** the highest component bump. UI-only + notes may bump `services` while all components stay `none`. 3. Replace changelog title/body with real **user-facing** prose (not `n/a`). Prefer bullets in the body. 4. Leave owned files alone — `release-intent-apply.yml` writes them after the pull request merges. -Example (engine-manager feature + product minor): +Example (engine-manager feature + services minor): ```markdown @@ -108,7 +108,7 @@ Model downloads show live progress - Pulling a model on this machine now shows a live percentage instead of a spinner. ### Bumps -- product: minor +- services: minor - nvpair-cluster-manager: none - nvpair-engine-manager: minor - nvpair-errors: none