diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index aec4c44..7b39b74 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -53,6 +53,14 @@ Fix Upload Size Check - Put types, constants and validation schemas used by both the client and the server in `shared/`. - Add or update tests for behavior changes (`test/unit/` for pure logic, `test/e2e/` for API behavior). +## Frontend Conventions + +- Dialogs use `` (focus trap, scroll lock, Escape) and destructive confirmations use ``. +- Close-on-Escape goes through `useEscapeKey(handler, isOpen)`, so only the top-most open layer reacts. +- Icons come from ``; add new ones to `app/utils/icons.ts` instead of inlining SVGs. +- Icon-only buttons need an `aria-label`, and inputs need a label (use `sr-only` if it shouldn't be visible). +- Note data lives in `useNotesList` (loading), `useNoteMutations` and `useNoteAttachments` (changes). + ## License By contributing, you agree that your contributions will be licensed under the [AGPL-3.0](./LICENSE) license. diff --git a/app/app.vue b/app/app.vue index 2269a54..a519209 100644 --- a/app/app.vue +++ b/app/app.vue @@ -1,6 +1,6 @@ diff --git a/app/components/app/SearchBar.vue b/app/components/app/SearchBar.vue index 2ad1cbe..de981b8 100644 --- a/app/components/app/SearchBar.vue +++ b/app/components/app/SearchBar.vue @@ -1,5 +1,5 @@