diff --git a/docs/nightly-on-the-queue.md b/docs/nightly-on-the-queue.md index 91bcbb1b0..e4fae4508 100644 --- a/docs/nightly-on-the-queue.md +++ b/docs/nightly-on-the-queue.md @@ -257,10 +257,10 @@ queue has (MI325X, MI350X, MI355X) is on them. branch, an artifact or log that cannot be downloaded or an import that fails never fails the nightly report: the page opens with a `Queue lanes` note saying that no queue lanes are in it tonight and why, and the rest is built as - before. The verdict does not take that absence for a failure, so the - `Release-Readiness` table says it too: its `E2E` row is marked "queue lanes - missing" and a warning under the table names the reason. Read it before - reading a `GO`: that `GO` does not cover the queue's GPUs. + before. A queue that never ran is not a pass, so the + release-readiness verdict is `NO-GO` with the failing gate `queue lanes + absent: `; its `E2E` row is marked "queue lanes missing" and a warning + under the table names the reason. What is public follows from the queue's own rules: the artifact is public and already scanned, only three of its files are used, and the log is the public job diff --git a/xtask/src/release_readiness.rs b/xtask/src/release_readiness.rs index a901474fb..9d8d47c79 100644 --- a/xtask/src/release_readiness.rs +++ b/xtask/src/release_readiness.rs @@ -107,7 +107,7 @@ pub fn run( windows_result, e2e_report_job_result, ); - facts.queue_absent = queue_absent_reason(&e2e_text); + facts.note_queue_absent(queue_absent_reason(&e2e_text)); // Trailing newline so the file ends like a text file. write_parented(out, &format!("{}\n", serde_json::to_string_pretty(&facts)?))?; @@ -176,6 +176,18 @@ fn assemble_facts( } } +impl Facts { + /// Record that the queue's lanes are not in the report. A queue that never + /// ran is not a pass, so this is a failing gate: the verdict is NO-GO. + fn note_queue_absent(&mut self, reason: Option) { + let Some(reason) = reason else { return }; + self.failing_gates + .push(format!("queue lanes absent: {reason}")); + self.verdict = Verdict::NoGo; + self.queue_absent = Some(reason); + } +} + fn write_parented(path: &Path, contents: &str) -> Result<()> { if let Some(parent) = path.parent() && !parent.as_os_str().is_empty() @@ -545,8 +557,8 @@ pub(crate) fn render_table(facts: &Facts) -> String { let _ = writeln!( out, "⚠️ **The shared queue's GPU lanes are not in tonight's report** ({}). The E2E row \ - above does not cover them, so a GO here does not cover R9700, MI350P, W7900 or the \ - queue's blocking lanes.\n", + above does not cover R9700, MI350P, W7900 or the queue's blocking lanes, and a queue \ + that did not run is not a pass: the verdict is NO-GO.\n", escape_markdown(reason) ); } @@ -901,11 +913,26 @@ mod tests { "success", "success", ); - facts.queue_absent = Some(reason); + assert_eq!(facts.verdict, Verdict::Go); + facts.note_queue_absent(Some(reason.clone())); let table = render_table(&facts); assert!(table.contains("queue lanes missing"), "{table}"); assert!(table.contains("not in tonight's report"), "{table}"); - // Not a failure: the verdict stays as the other gates decide it. + // A queue that never ran is not a pass. + assert_eq!(facts.verdict, Verdict::NoGo); + assert_eq!( + facts.failing_gates, + [format!("queue lanes absent: {reason}")] + ); + assert!(table.contains("NO-GO"), "{table}"); + assert!( + table.contains("queue lanes absent: no queue run"), + "{table}" + ); + // Nothing absent, nothing changed. + facts.verdict = Verdict::Go; + facts.failing_gates.clear(); + facts.note_queue_absent(None); assert_eq!(facts.verdict, Verdict::Go); }