From 08a69cc046ff04b3ed37f3df46df3649bec978b2 Mon Sep 17 00:00:00 2001 From: Roman Inflianskas Date: Fri, 23 Oct 2026 12:49:28 +0000 Subject: [PATCH] docs(testing): list untried optional-group combinations as a scanner gap The advised-command scanner tries each separate optional synopsis group on its own, never two together, so a command that only fails when flags from two such groups are combined is not caught. Say so in its Known gaps list. Signed-off-by: Roman Inflianskas --- docs/testing.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/testing.md b/docs/testing.md index 30b1486e47..508b2d534c 100644 --- a/docs/testing.md +++ b/docs/testing.md @@ -200,6 +200,10 @@ not checked as written: `service_hints.rs`, whose verb is `{action}`, and the `runtimes` retry line in `runtime_services.rs`, whose subcommand is `{command}`) is excluded and checked through the functions that build it instead +- separate optional groups are tried one at a time, never together (they can + be mutually exclusive, as in `rocm dash [--demo] [--replay ]`), so a + command that fails only when flags from two of them are combined is not + caught When it fails, fix the advice (or the CLI). Add text to `NOT_INVOCATIONS`, with a reason, only when the text starts with `rocm` but is not advice to run