From ba2764f204ea25511dc25477cd598c1e2a2b1685 Mon Sep 17 00:00:00 2001 From: FireDasher <150294350+FireDasher@users.noreply.github.com> Date: Mon, 21 Sep 2026 07:55:45 -0700 Subject: [PATCH 1/2] Make log_on_drop more convienient to disable --- src/stream.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/stream.rs b/src/stream.rs index fc0a45317..fa7575700 100644 --- a/src/stream.rs +++ b/src/stream.rs @@ -89,8 +89,9 @@ impl MixerDeviceSink { /// When [`MixerDeviceSink`] is dropped a message is logged to stderr or /// emitted through tracing if the tracing feature is enabled. - pub fn log_on_drop(&mut self, enabled: bool) { + pub fn log_on_drop(mut self, enabled: bool) -> Self { self.log_on_drop = enabled; + self } } From c55a3e06b87a2c34341b2d9c2c7d073e030f1268 Mon Sep 17 00:00:00 2001 From: FireDasher <150294350+FireDasher@users.noreply.github.com> Date: Mon, 21 Sep 2026 08:02:45 -0700 Subject: [PATCH 2/2] Fix backwards compatibility --- src/stream.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/stream.rs b/src/stream.rs index fa7575700..3f50342c7 100644 --- a/src/stream.rs +++ b/src/stream.rs @@ -89,8 +89,14 @@ impl MixerDeviceSink { /// When [`MixerDeviceSink`] is dropped a message is logged to stderr or /// emitted through tracing if the tracing feature is enabled. - pub fn log_on_drop(mut self, enabled: bool) -> Self { + /// Deprecated: Use disable_log_on_drop() instead + pub fn log_on_drop(&mut self, enabled: bool) { self.log_on_drop = enabled; + } + /// When [`MixerDeviceSink`] is dropped a message is logged to stderr or + /// emitted through tracing if the tracing feature is enabled. + pub fn disable_log_on_drop(mut self) -> Self { + self.log_on_drop = false; self } }