From 478488cdae45e5ebff342fc7ef32026d1c690b3c Mon Sep 17 00:00:00 2001 From: EliNaig Date: Fri, 9 Oct 2026 21:04:49 -0500 Subject: [PATCH] ml-kem: avoid unstable name collisions --- ml-kem/src/algebra.rs | 4 ++-- ml-kem/src/compress.rs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ml-kem/src/algebra.rs b/ml-kem/src/algebra.rs index 4d5f8bb..3eaaff0 100644 --- a/ml-kem/src/algebra.rs +++ b/ml-kem/src/algebra.rs @@ -119,9 +119,9 @@ where Eta: CbdSamplingSize, K: ArraySize, { - #[allow(unstable_name_collisions, reason = "TODO")] Vector::new(Array::from_fn(|i| { - let N = start_n + u8::truncate(i); + let i: u8 = Truncate::truncate(i); + let N = start_n + i; let prf_output = PRF::(sigma, N); sample_poly_cbd::(&prf_output) })) diff --git a/ml-kem/src/compress.rs b/ml-kem/src/compress.rs index 7a70299..ee98960 100644 --- a/ml-kem/src/compress.rs +++ b/ml-kem/src/compress.rs @@ -35,12 +35,12 @@ impl Compress for Elem { // // round(a / b) = floor((a + b/2) / b) // a / q ~= (a * x) >> s where x >> s ~= 1/q - #[allow(unstable_name_collisions, reason = "TODO")] fn compress(&mut self) -> &Self { const Q_HALF: u64 = (BaseField::QLL + 1) >> 1; let x = u64::from(self.0); let y = (((x << D::USIZE) + Q_HALF) * D::DIV_MUL) >> D::DIV_SHIFT; - self.0 = u16::truncate(y) & D::MASK; + let y: u16 = Truncate::truncate(y); + self.0 = y & D::MASK; self }