Problem
PLANNING.md's GOALS list has exactly one entry:
GOALS
- FISH LOADING BAIT PRICE BUG
I can't reproduce a bait-price loading problem against the current code, and the paths that note would cover are now implemented and tested:
Player.priceForBait is written by PlayerJsonReaderWriter.createJsonFromPlayer and read back by createPlayerFromJson (src/player/playerJsonReaderWriter.py:15, :36).
- It is declared in
schemas/player.json ("priceForBait": {"type": "number", "minimum": 0}) and is one of that schema's required fields.
- Round-tripping is covered:
tests/player/test_playerJsonReaderWriter.py:119-138 loads a save with "priceForBait": 60 and asserts player.priceForBait == 60, and :161 asserts a save missing the field falls back to the default rather than raising.
- The escalation itself (
priceForBait * 1.25 per bait purchase, src/location/shop.py:210) is covered by tests/location/test_shop.py:204-212.
What I'm unsure about
I don't know what the original symptom was, so I can't tell whether this is a stale note to delete or a bug that still reproduces in some way I haven't found — which is why this is an issue rather than a PR deleting the line.
If you remember the symptom, it's worth either writing it down here (so it can be reproduced and fixed) or dropping the line, since as the sole GOALS entry it currently reads as the project's one outstanding bug.
Problem
PLANNING.md's GOALS list has exactly one entry:I can't reproduce a bait-price loading problem against the current code, and the paths that note would cover are now implemented and tested:
Player.priceForBaitis written byPlayerJsonReaderWriter.createJsonFromPlayerand read back bycreatePlayerFromJson(src/player/playerJsonReaderWriter.py:15,:36).schemas/player.json("priceForBait": {"type": "number", "minimum": 0}) and is one of that schema'srequiredfields.tests/player/test_playerJsonReaderWriter.py:119-138loads a save with"priceForBait": 60and assertsplayer.priceForBait == 60, and:161asserts a save missing the field falls back to the default rather than raising.priceForBait * 1.25per bait purchase,src/location/shop.py:210) is covered bytests/location/test_shop.py:204-212.What I'm unsure about
I don't know what the original symptom was, so I can't tell whether this is a stale note to delete or a bug that still reproduces in some way I haven't found — which is why this is an issue rather than a PR deleting the line.
If you remember the symptom, it's worth either writing it down here (so it can be reproduced and fixed) or dropping the line, since as the sole GOALS entry it currently reads as the project's one outstanding bug.