From 228c51ecfc496464d841cf569a4c2447cae1437d Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Tue, 15 Sep 2026 08:29:49 +0000
Subject: [PATCH] Refactor stdlib web server to remove unnecessary clone and
 fix lock starvation

This commit refactors the `web.rs` server implementations (lines 401 and 469) to acquire the `PAGE_CONTENT` mutex lock *after* waiting for an incoming request instead of holding it beforehand. This resolves an underlying bug where the server would serve stale content and block other threads while waiting for network I/O, while simultaneously avoiding an unnecessary string clone by dereferencing the mutex guard instead.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
---
 stdlib/src/web.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/stdlib/src/web.rs b/stdlib/src/web.rs
index 500b9235..55063e01 100644
--- a/stdlib/src/web.rs
+++ b/stdlib/src/web.rs
@@ -398,9 +398,9 @@ impl StdlibRegistry {
                         Mutex::new(tiny_http::Server::http(format!("0.0.0.0:{}", port)).unwrap());
                     thread::spawn(move || {
                         while SERVER_RUNNING.load(Ordering::SeqCst) {
-                            let page = PAGE_CONTENT.lock().unwrap().clone();
                             if let Ok(mut req) = server.lock().unwrap().recv() {
-                                let r = tiny_http::Response::from_string(&page).with_header(
+                                let page = PAGE_CONTENT.lock().unwrap();
+                                let r = tiny_http::Response::from_string(&*page).with_header(
                                     tiny_http::Header::from_bytes(
                                         &b"Content-Type"[..],
                                         &b"text/html; charset=utf-8"[..],
@@ -466,9 +466,9 @@ impl StdlibRegistry {
                         Mutex::new(tiny_http::Server::http(format!("0.0.0.0:{}", port)).unwrap());
                     thread::spawn(move || {
                         while SERVER_RUNNING.load(Ordering::SeqCst) {
-                            let page = PAGE_CONTENT.lock().unwrap().clone();
                             if let Ok(mut req) = server.lock().unwrap().recv() {
-                                let r = tiny_http::Response::from_string(&page).with_header(
+                                let page = PAGE_CONTENT.lock().unwrap();
+                                let r = tiny_http::Response::from_string(&*page).with_header(
                                     tiny_http::Header::from_bytes(
                                         &b"Content-Type"[..],
                                         &b"text/html; charset=utf-8"[..],