diff --git a/changelog.d/2052-decisiondir-card-binding.fixed.md b/changelog.d/2052-decisiondir-card-binding.fixed.md new file mode 100644 index 000000000..f113c768b --- /dev/null +++ b/changelog.d/2052-decisiondir-card-binding.fixed.md @@ -0,0 +1 @@ +A decided meeting that saved no folder keeps the cards it decided, so its decision text is open to the same readers as one that saved a folder ([#2052](https://github.com/ThinkFlowLab/FlyBot/issues/2052)): before this a record written with an empty `decisionDir` was listed from the Project's own `decisions/` folder with no cards behind it, and a member of the same Project who could not see the meeting's card could still read the text, while the same file saved into a folder was refused as `not listed`. A record that decided no card still answers through the role list, and a name the folder did not list still opens nothing. diff --git a/core/src/host/project-board.js b/core/src/host/project-board.js index c6f55608d..7fdaac217 100644 --- a/core/src/host/project-board.js +++ b/core/src/host/project-board.js @@ -286,13 +286,23 @@ export function install(rt) { // #2041: a name that came from a meeting keeps that meeting's own cards, because opening the // file is checked against the same rule the board paints those cards with. const cardsOf = new Map() + const named = new Map() for (const meeting of Object.values(rt.state?.meetings ?? {})) { if (meeting === null || typeof meeting !== 'object' || meeting.status !== 'decided') continue if (!inProject(meeting, project)) continue const archivedDir = text(meeting.decisionDir) if (archivedDir !== '' && !folders.includes(archivedDir)) folders.push(archivedDir) const archived = await archivedOf(meeting) - if (archived === undefined) continue + if (archived === undefined) { + // A record written before the archive slice names no folder: its file is one of the rows of + // the Project's own listing, and the meeting still names the cards it decided. Kept aside + // until that listing is deduped, so only a name this read really listed carries the cards. + const path = text(meeting.decisionFile) + if (isDecisionPath(path) && !named.has(path)) { + named.set(path, Array.isArray(meeting.taskIds) ? meeting.taskIds.map(id => text(id)).filter(id => id !== '') : []) + } + continue + } found.push(archived) if (!cardsOf.has(archived.path)) { cardsOf.set(archived.path, Array.isArray(meeting.taskIds) ? meeting.taskIds.map(id => text(id)).filter(id => id !== '') : []) @@ -307,6 +317,13 @@ export function install(rt) { return true }) .sort((a, b) => (a.path < b.path ? -1 : a.path > b.path ? 1 : 0)) + // A record that saved no folder keeps the cards it decided, on the row this read listed for it + // and only that row: a name the folder did not list stays a ghost and opens nothing. A record + // that saved a folder wins over one that saved none for the same name, and an empty list still + // answers through the role list in `decisionVisible`. + for (const [path, ids] of named) { + if (!cardsOf.has(path) && deduped.some(file => file.path === path)) cardsOf.set(path, ids) + } // #2021: a `decisions/YYYY-MM-DD-….md` name sorts oldest first, so the cut has to take the tail. // Taking the head kept the 200 oldest files and dropped the ones just written — the wrong end of // the list. The order on screen stays ascending; only which rows survive at the cap changes. diff --git a/core/test/project-board.test.js b/core/test/project-board.test.js index 0ebc93df5..4b2c5185e 100644 --- a/core/test/project-board.test.js +++ b/core/test/project-board.test.js @@ -1370,3 +1370,179 @@ test('#2041: revoking a card closes the name a board read already cached', async rmSync(base, { recursive: true, force: true }) } }) + + +// A decided meeting written before the archive slice saved no folder, so its file is a row of the +// Project's own listing rather than one a meeting recorded. It still names the cards it decided, +// and the name has to keep them: with no card the role list answers, and a member who sees none of +// those cards reads the text. The two shapes must read the same, name by name. +const decisionFolder = (prefix) => { + const base = mkdtempSync(join(tmpdir(), prefix)) + const dir = join(base, 'project') + mkdirSync(join(dir, '.git'), { recursive: true }) + mkdirSync(join(dir, 'decisions')) + return { base, dir } +} + +// The owner the Project names is not a member record here, so a Bot's owner is card-affine and +// carries no Project role: the card door and the role list cannot be mistaken for each other. +const legacyFolderSeed = (dir, meetings) => { + const team = crossSeed() + team.projects['project-p1'].ownerUserIds = ['owner-9'] + team.projects['project-p1'].ownerUserId = 'owner-9' + team.projects['project-p1'].workDir = dir + team.projects['project-p1'].roles = { maintainers: [], members: ['owner-3'] } + team.members['owner-3'] = { id: 'owner-3', createdAt: 4, designatedChiefId: null } + team.meetings = meetings + return team +} + +const legacyMeeting = (id, overrides = {}) => ({ + id, status: 'decided', question: 'What shipped?', owner: 'Chief', project: 'project-p1', + decisionDir: '', decisionFile: `decisions/2026-10-29-${id}.md`, taskIds: ['task-group'], + createdAt: 1, updatedAt: 2, decidedAt: 3, ...overrides, +}) + +const signIn = (rt) => { + const members = { 'tok-1': 'owner-1', 'tok-2': 'owner-2', 'tok-3': 'owner-3' } + rt.authenticate = async token => (members[token] ? { memberId: members[token] } : null) + rt.state.authSessions = Object.fromEntries(Object.keys(members) + .map((token, at) => [`s-${at + 1}`, { memberId: members[token], tokenHash: token }])) +} + +const refused = (answer) => { + assert.equal(answer.ok, true, JSON.stringify(answer)) + assert.equal(answer.value.ok, false, 'a caller who sees none of the cards reads no text') + assert.equal('text' in answer.value, false) +} + +test('#2052: a record that saved no folder keeps the cards it decided, like one that saved a folder', async () => { + const { base, dir } = decisionFolder('ds-bot-decisions-record-') + writeFileSync(join(dir, 'decisions', '2026-10-29-nofolder.md'), '# decided with no folder\n') + writeFileSync(join(dir, 'decisions', '2026-10-29-folder.md'), '# decided with a folder\n') + const team = legacyFolderSeed(dir, { + 'm-nofolder': legacyMeeting('nofolder'), + 'm-folder': legacyMeeting('folder', { decisionDir: dir }), + }) + const { rt, callAs, stop } = await start(undefined, team) + try { + signIn(rt) + const board = await callAs('project-board', { id: 'project-p1' }, 'tok-3') + assert.equal(board.ok, true, JSON.stringify(board)) + assert.deepEqual(board.value.tasks ?? [], [], 'the member sees none of the cards this Project decides on') + for (const name of ['2026-10-29-nofolder.md', '2026-10-29-folder.md']) { + const path = `decisions/${name}` + assert.equal(board.value.decisions.files.some(file => file.path === path), true, `${path} is listed`) + const member = await callAs('project-decision', { id: 'project-p1', path }, 'tok-3') + refused(member) + assert.equal(member.value.reason, `not listed: ${path} is not in this board's decision list`) + } + // Card-affine and holding no Project role: the room's own admin reads both through the card door. + const noFolder = await callAs('project-decision', { id: 'project-p1', path: 'decisions/2026-10-29-nofolder.md' }, 'tok-1') + assert.equal(noFolder.value.ok, true, JSON.stringify(noFolder)) + assert.equal(noFolder.value.text, '# decided with no folder\n') + const folder = await callAs('project-decision', { id: 'project-p1', path: 'decisions/2026-10-29-folder.md' }, 'tok-1') + assert.equal(folder.value.ok, true, JSON.stringify(folder)) + assert.equal(folder.value.text, '# decided with a folder\n') + } finally { + await stop() + rmSync(base, { recursive: true, force: true }) + } +}) + +test('#2052: a record that decided no card still answers through the role list', async () => { + const { base, dir } = decisionFolder('ds-bot-decisions-nocard-') + writeFileSync(join(dir, 'decisions', '2026-10-29-nocard.md'), '# a record with no card\n') + const team = legacyFolderSeed(dir, { 'm-nocard': legacyMeeting('nocard', { taskIds: [] }) }) + const { rt, callAs, stop } = await start(undefined, team) + try { + signIn(rt) + await callAs('project-board', { id: 'project-p1' }, 'tok-3') + const member = await callAs('project-decision', { id: 'project-p1', path: 'decisions/2026-10-29-nocard.md' }, 'tok-3') + assert.equal(member.value.ok, true, JSON.stringify(member)) + assert.equal(member.value.text, '# a record with no card\n', 'a name no card binds follows the role list') + // The same name is still a name, not a list: a caller outside both doors reads nothing. + await callAs('project-board', { id: 'project-p1' }, 'tok-2') + const outsider = await callAs('project-decision', { id: 'project-p1', path: 'decisions/2026-10-29-nocard.md' }, 'tok-2') + refused(outsider) + assert.equal(outsider.value.reason, "not listed: decisions/2026-10-29-nocard.md is not in this board's decision list") + } finally { + await stop() + rmSync(base, { recursive: true, force: true }) + } +}) + +test('#2052: a record naming a file the folder did not list opens nothing', async () => { + const { base, dir } = decisionFolder('ds-bot-decisions-ghost-') + const team = legacyFolderSeed(dir, { 'm-ghost': legacyMeeting('ghost') }) + const { rt, callAs, stop } = await start(undefined, team) + try { + signIn(rt) + await callAs('project-board', { id: 'project-p1' }, 'tok-1') + for (const token of ['tok-1', 'tok-3']) { + const answer = await callAs('project-decision', { id: 'project-p1', path: 'decisions/2026-10-29-ghost.md' }, token) + refused(answer) + assert.equal(answer.value.reason, "not listed: decisions/2026-10-29-ghost.md is not in this board's decision list", + 'a name the listing never had stays a ghost') + } + } finally { + await stop() + rmSync(base, { recursive: true, force: true }) + } +}) + +test('#2052: a record of one Project puts no cards on another Project name', async () => { + const { base, dir } = decisionFolder('ds-bot-decisions-cross-') + writeFileSync(join(dir, 'decisions', '2026-11-01-shared.md'), '# read through the other Project\n') + const team = legacyFolderSeed(dir, { 'm-shared': legacyMeeting('shared', { decisionFile: 'decisions/2026-11-01-shared.md' }) }) + // The second Project lists the same relative name in the same folder and has a role for owner-1. + team.projects['project-p2'].ownerUserId = 'owner-9' + team.projects['project-p2'].workDir = dir + team.projects['project-p2'].roles = { maintainers: [], members: ['owner-1'] } + const { rt, callAs, stop } = await start(undefined, team) + try { + signIn(rt) + // The first Project's record binds its own card to its own read: its member still reads nothing. + await callAs('project-board', { id: 'project-p1' }, 'tok-3') + const mine = await callAs('project-decision', { id: 'project-p1', path: 'decisions/2026-11-01-shared.md' }, 'tok-3') + refused(mine) + // The second Project has no record for the name: its role list decides, and owner-1 reaches it. + await callAs('project-board', { id: 'project-p2' }, 'tok-1') + const theirs = await callAs('project-decision', { id: 'project-p2', path: 'decisions/2026-11-01-shared.md' }, 'tok-1') + assert.equal(theirs.value.ok, true, JSON.stringify(theirs)) + assert.equal(theirs.value.text, '# read through the other Project\n', 'a record of one Project gates only its own names') + } finally { + await stop() + rmSync(base, { recursive: true, force: true }) + } +}) + +test('#2052: two records naming one file keep the cards the first one decided', async () => { + const { base, dir } = decisionFolder('ds-bot-decisions-twice-') + const archive = join(base, 'archive') + mkdirSync(join(archive, 'decisions'), { recursive: true }) + writeFileSync(join(archive, 'decisions', '2026-11-02-twice.md'), '# the first record decided it\n') + const team = legacyFolderSeed(dir, { + 'm-first': legacyMeeting('first', { decisionDir: archive, decisionFile: 'decisions/2026-11-02-twice.md' }), + 'm-second': legacyMeeting('second', { decisionDir: archive, decisionFile: 'decisions/2026-11-02-twice.md', taskIds: [] }), + }) + const { rt, callAs, stop } = await start(undefined, team) + try { + signIn(rt) + for (const round of ['first read', 'second read']) { + const board = await callAs('project-board', { id: 'project-p1' }, 'tok-3') + assert.equal(board.value.decisions.files.some(file => file.path === 'decisions/2026-11-02-twice.md'), true, + `${round}: one row per name`) + const member = await callAs('project-decision', { id: 'project-p1', path: 'decisions/2026-11-02-twice.md' }, 'tok-3') + refused(member) + assert.equal(member.value.reason, "not listed: decisions/2026-11-02-twice.md is not in this board's decision list", + `${round}: the first record supplies the cards`) + } + const own = await callAs('project-decision', { id: 'project-p1', path: 'decisions/2026-11-02-twice.md' }, 'tok-1') + assert.equal(own.value.ok, true, JSON.stringify(own)) + assert.equal(own.value.text, '# the first record decided it\n') + } finally { + await stop() + rmSync(base, { recursive: true, force: true }) + } +}) diff --git a/docs/subsystems/core-host.md b/docs/subsystems/core-host.md index 50db96f01..474ff047f 100644 --- a/docs/subsystems/core-host.md +++ b/docs/subsystems/core-host.md @@ -211,7 +211,7 @@ An admin's `@` used to be the room's control plane: every `@Dev #1234 rebase and ### Team state and access -- The saved team (`state.json`) is versioned. Version 2 (#47) carries the identity schema — `members` records, a per-Bot `ownerId`, the owner's `designatedChiefId`. A legacy version-1 file is migrated on load with a one-time `state.json.v1` backup; an existing backup counts only when it is a readable file holding a parseable version-1 state, and anything else (or any malformed ownership) fails closed (read-only). An older binary refuses a newer version read-only. This is schema foundation only — team mode stays disabled, see [team](team.md). On top of it, a durable **Project** record (#1691): `state.projects` holds `{id, name, repository, defaultBranch, ownerUserId, createdAt, updatedAt, status}`, `bot.projectId` / `room.projectId` and `state.projectRuns[runId]` bind a member (a group, a Bot or a workflow run) to at most one Project, and the `api/bot` endpoints `projects`, `project-create`, `project-read`, `project-bind`, `project-of` and `project-board` sit in the task allow list. An unbound member resolves `null`, so an install with zero Projects behaves exactly as before. The read-only board over those bindings is `project-board` (#1696): Project id in, `{ tasks: [...] }` out, one row per core task id with `source` (`bot`/`group`/`workflow`), `column`, `assignee`, `updatedAt` and `runId`/`nodeId` when a run holds it. `core/src/host/project-board.js` reads `state.tasks` and the bindings and asks the registered providers through `rt.projectRunRefs` (`flybot.tasks.onProjectProvider`); it never reads `workflows.json` and writes nothing. Since #2021 the board's record halves say what their caps left out and cut the right end of the list: the decision read answers `total` — the files left after the one-row-per-path dedup, before the cut — and takes `.slice(-DECISIONS_MAX)` over the still-ascending sort, so a Project past 200 decisions keeps the newest instead of dropping the ones just written and the order on screen does not change, while the meetings read answers `decidedTotal`/`pendingTotal` per list beside the 100 rows it already kept newest; a list at or under its cap answers the same rows as before, plus the count ([#2021](https://github.com/ThinkFlowLab/FlyBot/issues/2021)). Since #2033 the lookup a decided meeting uses for its own file falls back to the un-truncated dedupe set of that same read when the name is not among the kept rows, so a file that fell off the oldest end of the cut is still named by the meeting (`path` set, and no `sha256`, because only the kept rows carry one) while a name the folder no longer holds still answers `path: ''`; the fallback reads names from that dedupe set and never asks the filesystem, so a crafted `../outside.md` yields no path either ([#2033](https://github.com/ThinkFlowLab/FlyBot/issues/2033)). Since #2037 the name is also checked where the listing is produced, by the same `isDecisionPath` the reader uses: a name with a `..` segment, an absolute path, a symlink standing in for the file, or a name this read never listed yields no row and no meeting `path` (and no `sha256`), so the fallback past the cut cannot bring one back — `archivedOf` reads through `describeFile`, the reader's own `lstat`, never `stat` ([#2037](https://github.com/ThinkFlowLab/FlyBot/issues/2037)). Since #2041 a decision row can be opened: `rt.projectDecision(projectId, name)` reads one name through `readListedFile` and answers the reader's own three states (`text`, `absent`, `too large`), but only for a name the last `projectBoard` read of that Project produced — that read's un-truncated dedupe set is kept per Project, each name with the folder it was read from, so a name past the 200-row cut still opens while `decisions/../outside.md`, an absolute path, a name one level down or a symlink answers `not listed` without a `stat`, an open or a byte of content; the endpoint is `project-decision`, dispatched in `channel.js` beside `project-board` and listed in `authz.js`'s `TASK_ENDPOINTS` ([#2041](https://github.com/ThinkFlowLab/FlyBot/issues/2041)). Since [#2029](https://github.com/ThinkFlowLab/FlyBot/issues/2029) a blocked card also carries the age of its own question: `blockedOf(task, now)` answers `since` (the `inputRequest.requestedAt` stamp `tasks.js` wrote, preserved across a re-ask) and `waitedMs` (`now - since`, the same shape `waitingOf` answers), both `null` when the ask wrote no stamp — never derived from `createdAt`/`updatedAt` — and `buildQueues` sorts `blocked` oldest-first with the comparator `waiting.sort` already uses, so an undated card sorts last; the Waiting group's own output is unchanged. Tests: `core/test/project-board.test.js`. On top of the record and the board sits the **Project Assistant** (#1712, Stage 2.5): `project-delete` removes the Project, its bindings and its memory; the assistant's digest is one stored note plus one `deliver()` to the owner, idempotent per Asia/Shanghai day, and its identity is the connector account and never the shared app — no connector signed in, or a multi-member host whose Project owner is not this host's own user, refuses and escalates with nothing written. Per-owner memory (#1733) keys those three fields by `(Project, owner)` under `projectMemory[id].owners`, mirrors the primary owner onto the row itself so a single-owner Project reads as before, and migrates a pre-#1733 record onto its primary owner on the first write instead of replacing it; the boundary a memory read is checked against is the Project's own owner list, so an owner asking for another owner's entries is refused naming that list, while the assistant's own render walks every owner. A card needs an owner's decision when the Bot that owns the card belongs to that owner, never from the board's `assignee` (a Bot name or null); the ask names the card's own title, at most `MAX_ACTIONABLE` (5) per owner. A quiet window on the assistant record holds a due digest and releases it once, labelled, when the window ends; a window covering 09:00 delivers nothing that day; an owner's opt-out stops generation and pauses the shared 09:00 task once every owner is off, and a re-enable resumes it; delivery goes to each owner's own Session and falls back to the main Bot only for the primary owner. A held digest is released by the next `digest()` call, not by the 09:00 task, which does not make one after a window ends. On top of it, member auth (#48) adds host module `src/host/member-auth.js`, installed after `store` in `MODULES` (`core/index.js`): `invitations` and `authSessions` maps live on state (no `STATE_VERSION` bump), the channel resolves the actor from the `x-flybot-member-session` header, and endpoints are `auth-invite` / `auth-redeem` / `auth-revoke` / `auth-whoami` / `auth-remove-member` / `auth-revoke-invite` with `body.actorId` ignored; `auth-invite` alone also opens for an anonymous caller on a host with no sessions yet (bootstrap first invite), `auth-revoke-invite` kills an unredeemed invitation (redeeming it afterwards fails with `revoked`), `removeMember` refuses a member that still owns a Bot (`has_bots`), and the auth mutations are serialized behind an in-process lock so concurrent `removeMember` calls cannot both pass the last-owner check. Sign-in surface only — still not team mode; details in [team](team.md). On top of it, owner-scoped access (#49) adds host module `src/host/authz.js`, installed after member-auth: when any `authSessions` exist, the channel `authorize()` default-denies cross-owner Bot/room/session access, blocks shared non-isolatable resources (secrets, connectors, folder picks, browser bridge, update-install, diagnostics, set-prefs, `add-agent` — the DSH Agent is one per deployment and carries no owner) with `bot/blocked-shared` when more than one member exists, stamps `create-bot` with `actor.memberId`, and filters `view()`/`live()` to the actor; with no sessions the single-human behavior is unchanged. Session targets resolve through the store's owner maps — a Bot id via `botOf`, current chats and group Sessions and earlier parts via `selfOf`/`groupOwners`/`pastOwners` (a shared room Session also resolves for its current participants, #50) — and unresolvable ids deny. `approval-answer` gates on the approval's own Bot or room (resolved by approval id), never on caller-supplied session fields. `flybot/*` plugin endpoints (src/host/hooks.js) reach any signed-in actor for reads — except a Bot Social read naming a `body.botId` the actor does not own, which `bot/forbidden` refuses before the plugin handler registers that Bot's identity or syncs its grants (#1788, an owner-decided tightening); plugin writes follow the shared rule. `view()`/`live()` narrowing (`rt.ownedView`/`rt.ownedLive` in authz.js) keeps per-session entries (`questions`, `exchangeTurns`) the actor owns, and deployment-wide surfaces (agents, secrets, connectors, memory reviews) only while a single member exists — the same rule as the shared writes; rooms the actor belongs to and the Bots in them (#50) stay visible. `create-room` refuses a request with neither a member Bot nor any participant. On top of it, room membership (#50) adds host module `src/host/room-membership.js`, installed after groups: a room may carry typed `participants` (`human` / local `bot` / granted remote `bot` with `handle` + owner fields, roles `admin` / `member`, `joinedSeq` / `leftSeq`); log lines carry `authorId` + `authorKind`; history is the membership window (current members and the owner of an invited Bot see `seq >=` their interval; leave withdraws access; rejoin starts a new interval); local cross-owner rooms accept each side's *granted* Bots (#90: default deny, Chief included); a friend's Bot from `social/remote-bots` (`cleanRemote`) may be added and ungranted Bots stay private, and a room with a friend's Bot holds only granted local Bots (a Bot that joined by room code, `viaCode`, only for that room); `view()` labels remotes with an owner badge and shows an invited owner **Shared room from \**. Face-to-face rooms (#83) reuse the same `participants` / membership-window / owner-badge presentation with `origin: 'face-to-face'`: room-only remotes may sit in the room without a person-grant or a friendship, `presentRoom` treats the viewer as a member (not Shared room from), leave skips the two-Bot floor, and `fanoutRoomLine` goes to `rt.faceRoomFanout` instead of friend `flybotSend`. Still not team mode — see [team](team.md). Per-Bot grants (#90) add host module `src/host/reach.js`, installed after room-membership: `state.grants[botId]` is the list of independent grants (one Bot → one grantee, optionally room-scoped); default deny, Chief included; a Bot whose owner is not a member has none. Grants are set with `rt.setGrants`, exposed as `BotView.granted`, `flybot.bot.hasGrant` / `hasAnyGrant`, `flybot.grants` and the `bot.grants` event. `reach()` is the owner policy: a friend's Bot may reach only local Bots granted to that sender, only a granted Bot (or one code-joined in that room) may message a friend's Bot, another owner's Bot is reached only if both sides have matching grants or both are members of the room the message belongs to. It is not a middleware: hooks.js runs it before the `bot.send` chain, again on approval release, and on every deliver with a sender or remote origin (resumed, retried, deferred, re-sent), so no verdict or `bypass` can skip it and a queued message is judged by what is true when it is delivered. Revoking a grant, or replacing its Chief, removes it from rooms that have friends' Bots or several owners at once (`rt.evictUnshared`). Approval binding (#52) completes the held-send half of this: `state.flybot.approvals` records carry `requestId`, a sha256 `version` over the request content, server-derived `ownerId` and `origin` (`via`/`hop`/audience) — claims in the message (`meta`, text) never confer authority. `flybot/decide` is allowed through authz for any signed-in actor and the per-record check happens in hooks (`decide` requires the sender Bot's owner's session, `bot/forbidden` otherwise, `bot/unauthorized` without a session); `release()` revalidates before dispatch and marks the record `stale` when the request changed, the sender or target Bot is gone (also invalidated eagerly on `deleteBot`), or the Bot changed owners; a demoted Chief's sender-side holds are invalidated eagerly on `setMain` (not inside `staleReason`), and `release()` re-checks immediately before dispatch so an in-flight approve cannot go out after a concurrent invalidation. Unknown `invalidateFor` field values throw. `flybot/approvals` lists only the actor's own holds while enforcement is on; decided stale records keep their attribution in state but appear in no member's list. Which statuses still wait for that decision is one rule in `src/shared/approval-waiting.js` (#754): `decide()`, `heldOf()` in the chat view, the in-flight filter that invalidates holds, `PENDING_MAX` and the `APPROVALS_KEPT` cleanup all ask `isApprovalWaiting()`, and `channel.js` counts a row's waiting replies with it, so a `pending_approval` hold (Bot Social's own spelling) is decidable, drawn as waiting and never dropped mid-wait. +- The saved team (`state.json`) is versioned. Version 2 (#47) carries the identity schema — `members` records, a per-Bot `ownerId`, the owner's `designatedChiefId`. A legacy version-1 file is migrated on load with a one-time `state.json.v1` backup; an existing backup counts only when it is a readable file holding a parseable version-1 state, and anything else (or any malformed ownership) fails closed (read-only). An older binary refuses a newer version read-only. This is schema foundation only — team mode stays disabled, see [team](team.md). On top of it, a durable **Project** record (#1691): `state.projects` holds `{id, name, repository, defaultBranch, ownerUserId, createdAt, updatedAt, status}`, `bot.projectId` / `room.projectId` and `state.projectRuns[runId]` bind a member (a group, a Bot or a workflow run) to at most one Project, and the `api/bot` endpoints `projects`, `project-create`, `project-read`, `project-bind`, `project-of` and `project-board` sit in the task allow list. An unbound member resolves `null`, so an install with zero Projects behaves exactly as before. The read-only board over those bindings is `project-board` (#1696): Project id in, `{ tasks: [...] }` out, one row per core task id with `source` (`bot`/`group`/`workflow`), `column`, `assignee`, `updatedAt` and `runId`/`nodeId` when a run holds it. `core/src/host/project-board.js` reads `state.tasks` and the bindings and asks the registered providers through `rt.projectRunRefs` (`flybot.tasks.onProjectProvider`); it never reads `workflows.json` and writes nothing. Since #2021 the board's record halves say what their caps left out and cut the right end of the list: the decision read answers `total` — the files left after the one-row-per-path dedup, before the cut — and takes `.slice(-DECISIONS_MAX)` over the still-ascending sort, so a Project past 200 decisions keeps the newest instead of dropping the ones just written and the order on screen does not change, while the meetings read answers `decidedTotal`/`pendingTotal` per list beside the 100 rows it already kept newest; a list at or under its cap answers the same rows as before, plus the count ([#2021](https://github.com/ThinkFlowLab/FlyBot/issues/2021)). Since #2033 the lookup a decided meeting uses for its own file falls back to the un-truncated dedupe set of that same read when the name is not among the kept rows, so a file that fell off the oldest end of the cut is still named by the meeting (`path` set, and no `sha256`, because only the kept rows carry one) while a name the folder no longer holds still answers `path: ''`; the fallback reads names from that dedupe set and never asks the filesystem, so a crafted `../outside.md` yields no path either ([#2033](https://github.com/ThinkFlowLab/FlyBot/issues/2033)). Since #2037 the name is also checked where the listing is produced, by the same `isDecisionPath` the reader uses: a name with a `..` segment, an absolute path, a symlink standing in for the file, or a name this read never listed yields no row and no meeting `path` (and no `sha256`), so the fallback past the cut cannot bring one back — `archivedOf` reads through `describeFile`, the reader's own `lstat`, never `stat` ([#2037](https://github.com/ThinkFlowLab/FlyBot/issues/2037)). Since #2041 a decision row can be opened: `rt.projectDecision(projectId, name)` reads one name through `readListedFile` and answers the reader's own three states (`text`, `absent`, `too large`), but only for a name the last `projectBoard` read of that Project produced — that read's un-truncated dedupe set is kept per Project, each name with the folder it was read from, so a name past the 200-row cut still opens while `decisions/../outside.md`, an absolute path, a name one level down or a symlink answers `not listed` without a `stat`, an open or a byte of content; the endpoint is `project-decision`, dispatched in `channel.js` beside `project-board` and listed in `authz.js`'s `TASK_ENDPOINTS` ([#2041](https://github.com/ThinkFlowLab/FlyBot/issues/2041)). A decided meeting that saved no folder keeps the cards it decided: its file is one of the Project folder's own rows, and binding those cards to that row is what keeps the name behind the same door as the cards, while a meeting that decided no card still answers through the role list ([#2052](https://github.com/ThinkFlowLab/FlyBot/issues/2052)). Since [#2029](https://github.com/ThinkFlowLab/FlyBot/issues/2029) a blocked card also carries the age of its own question: `blockedOf(task, now)` answers `since` (the `inputRequest.requestedAt` stamp `tasks.js` wrote, preserved across a re-ask) and `waitedMs` (`now - since`, the same shape `waitingOf` answers), both `null` when the ask wrote no stamp — never derived from `createdAt`/`updatedAt` — and `buildQueues` sorts `blocked` oldest-first with the comparator `waiting.sort` already uses, so an undated card sorts last; the Waiting group's own output is unchanged. Tests: `core/test/project-board.test.js`. On top of the record and the board sits the **Project Assistant** (#1712, Stage 2.5): `project-delete` removes the Project, its bindings and its memory; the assistant's digest is one stored note plus one `deliver()` to the owner, idempotent per Asia/Shanghai day, and its identity is the connector account and never the shared app — no connector signed in, or a multi-member host whose Project owner is not this host's own user, refuses and escalates with nothing written. Per-owner memory (#1733) keys those three fields by `(Project, owner)` under `projectMemory[id].owners`, mirrors the primary owner onto the row itself so a single-owner Project reads as before, and migrates a pre-#1733 record onto its primary owner on the first write instead of replacing it; the boundary a memory read is checked against is the Project's own owner list, so an owner asking for another owner's entries is refused naming that list, while the assistant's own render walks every owner. A card needs an owner's decision when the Bot that owns the card belongs to that owner, never from the board's `assignee` (a Bot name or null); the ask names the card's own title, at most `MAX_ACTIONABLE` (5) per owner. A quiet window on the assistant record holds a due digest and releases it once, labelled, when the window ends; a window covering 09:00 delivers nothing that day; an owner's opt-out stops generation and pauses the shared 09:00 task once every owner is off, and a re-enable resumes it; delivery goes to each owner's own Session and falls back to the main Bot only for the primary owner. A held digest is released by the next `digest()` call, not by the 09:00 task, which does not make one after a window ends. On top of it, member auth (#48) adds host module `src/host/member-auth.js`, installed after `store` in `MODULES` (`core/index.js`): `invitations` and `authSessions` maps live on state (no `STATE_VERSION` bump), the channel resolves the actor from the `x-flybot-member-session` header, and endpoints are `auth-invite` / `auth-redeem` / `auth-revoke` / `auth-whoami` / `auth-remove-member` / `auth-revoke-invite` with `body.actorId` ignored; `auth-invite` alone also opens for an anonymous caller on a host with no sessions yet (bootstrap first invite), `auth-revoke-invite` kills an unredeemed invitation (redeeming it afterwards fails with `revoked`), `removeMember` refuses a member that still owns a Bot (`has_bots`), and the auth mutations are serialized behind an in-process lock so concurrent `removeMember` calls cannot both pass the last-owner check. Sign-in surface only — still not team mode; details in [team](team.md). On top of it, owner-scoped access (#49) adds host module `src/host/authz.js`, installed after member-auth: when any `authSessions` exist, the channel `authorize()` default-denies cross-owner Bot/room/session access, blocks shared non-isolatable resources (secrets, connectors, folder picks, browser bridge, update-install, diagnostics, set-prefs, `add-agent` — the DSH Agent is one per deployment and carries no owner) with `bot/blocked-shared` when more than one member exists, stamps `create-bot` with `actor.memberId`, and filters `view()`/`live()` to the actor; with no sessions the single-human behavior is unchanged. Session targets resolve through the store's owner maps — a Bot id via `botOf`, current chats and group Sessions and earlier parts via `selfOf`/`groupOwners`/`pastOwners` (a shared room Session also resolves for its current participants, #50) — and unresolvable ids deny. `approval-answer` gates on the approval's own Bot or room (resolved by approval id), never on caller-supplied session fields. `flybot/*` plugin endpoints (src/host/hooks.js) reach any signed-in actor for reads — except a Bot Social read naming a `body.botId` the actor does not own, which `bot/forbidden` refuses before the plugin handler registers that Bot's identity or syncs its grants (#1788, an owner-decided tightening); plugin writes follow the shared rule. `view()`/`live()` narrowing (`rt.ownedView`/`rt.ownedLive` in authz.js) keeps per-session entries (`questions`, `exchangeTurns`) the actor owns, and deployment-wide surfaces (agents, secrets, connectors, memory reviews) only while a single member exists — the same rule as the shared writes; rooms the actor belongs to and the Bots in them (#50) stay visible. `create-room` refuses a request with neither a member Bot nor any participant. On top of it, room membership (#50) adds host module `src/host/room-membership.js`, installed after groups: a room may carry typed `participants` (`human` / local `bot` / granted remote `bot` with `handle` + owner fields, roles `admin` / `member`, `joinedSeq` / `leftSeq`); log lines carry `authorId` + `authorKind`; history is the membership window (current members and the owner of an invited Bot see `seq >=` their interval; leave withdraws access; rejoin starts a new interval); local cross-owner rooms accept each side's *granted* Bots (#90: default deny, Chief included); a friend's Bot from `social/remote-bots` (`cleanRemote`) may be added and ungranted Bots stay private, and a room with a friend's Bot holds only granted local Bots (a Bot that joined by room code, `viaCode`, only for that room); `view()` labels remotes with an owner badge and shows an invited owner **Shared room from \**. Face-to-face rooms (#83) reuse the same `participants` / membership-window / owner-badge presentation with `origin: 'face-to-face'`: room-only remotes may sit in the room without a person-grant or a friendship, `presentRoom` treats the viewer as a member (not Shared room from), leave skips the two-Bot floor, and `fanoutRoomLine` goes to `rt.faceRoomFanout` instead of friend `flybotSend`. Still not team mode — see [team](team.md). Per-Bot grants (#90) add host module `src/host/reach.js`, installed after room-membership: `state.grants[botId]` is the list of independent grants (one Bot → one grantee, optionally room-scoped); default deny, Chief included; a Bot whose owner is not a member has none. Grants are set with `rt.setGrants`, exposed as `BotView.granted`, `flybot.bot.hasGrant` / `hasAnyGrant`, `flybot.grants` and the `bot.grants` event. `reach()` is the owner policy: a friend's Bot may reach only local Bots granted to that sender, only a granted Bot (or one code-joined in that room) may message a friend's Bot, another owner's Bot is reached only if both sides have matching grants or both are members of the room the message belongs to. It is not a middleware: hooks.js runs it before the `bot.send` chain, again on approval release, and on every deliver with a sender or remote origin (resumed, retried, deferred, re-sent), so no verdict or `bypass` can skip it and a queued message is judged by what is true when it is delivered. Revoking a grant, or replacing its Chief, removes it from rooms that have friends' Bots or several owners at once (`rt.evictUnshared`). Approval binding (#52) completes the held-send half of this: `state.flybot.approvals` records carry `requestId`, a sha256 `version` over the request content, server-derived `ownerId` and `origin` (`via`/`hop`/audience) — claims in the message (`meta`, text) never confer authority. `flybot/decide` is allowed through authz for any signed-in actor and the per-record check happens in hooks (`decide` requires the sender Bot's owner's session, `bot/forbidden` otherwise, `bot/unauthorized` without a session); `release()` revalidates before dispatch and marks the record `stale` when the request changed, the sender or target Bot is gone (also invalidated eagerly on `deleteBot`), or the Bot changed owners; a demoted Chief's sender-side holds are invalidated eagerly on `setMain` (not inside `staleReason`), and `release()` re-checks immediately before dispatch so an in-flight approve cannot go out after a concurrent invalidation. Unknown `invalidateFor` field values throw. `flybot/approvals` lists only the actor's own holds while enforcement is on; decided stale records keep their attribution in state but appear in no member's list. Which statuses still wait for that decision is one rule in `src/shared/approval-waiting.js` (#754): `decide()`, `heldOf()` in the chat view, the in-flight filter that invalidates holds, `PENDING_MAX` and the `APPROVALS_KEPT` cleanup all ask `isApprovalWaiting()`, and `channel.js` counts a row's waiting replies with it, so a `pending_approval` hold (Bot Social's own spelling) is decidable, drawn as waiting and never dropped mid-wait. - One writer per home (`src/host/home-lock.js`): the first dsh to load `~/.dsh` takes `state.lock` (pid, host, a random token in the file, its mtime bumped on a timer) and a second window on the same data only reads, answering `bot/read-only` and naming the other host. Takeover is **on the next write**, not on a poll (#1027): a window that was read-only claims the free lock inside `save()` too, and a change made outside a request (a plugin, a scheduled task, a delivery) belongs in `rt.mutate(fn)`, which takes over and adopts what the other host left *before* the change is made and written. The writers that changed `rt.state` inline and then called `save()` are gone (#1048): `delivery.js` (a friend's first line and its unread mark, a team exchange) and `agents.js` (add, adopt, archive and remove of the DSH Agent) take the free lock and adopt first, re-resolving their records inside the change, so a write from a window that was read-only keeps what the other host left instead of replacing it with its older copy. `save()` itself never adopts: `adopt()` replaces `rt.state` whole, so adopting there would discard a change the caller has already made (`#1032`). Either takeover prints one line — `the other dsh has closed; this one now saves the Bot team (was pid on )` — from `refresh()` and from `save()` alike, so a window that writes over the file another host left leaves a trace (#1041). A lock file still naming a live holder on this host (its pid answers) keeps the window read-only, which is the #14 rule. A write that fails does not decide the delivery (#1096): the friend-line mark and the exchange record both land before the agent has the line, so a rejected `mutate()` (the lock was taken away, or the disk refused) prints one warning naming what was not recorded and the line is still handed over — a throw there would drop a message that exists nowhere else. The write chain is also readable: `rt.savesQueued()` is a monotonic watermark — every save this host has accepted since it started, never decremented — and `rt.savesSettled()` resolves once the chain is empty, so a caller that must read `state.json` after a save it did not await — a rollback's own write, in the tests — waits on the store instead of on a delay, where a wait long enough on an idle machine reads a half-written team on a busy one (#1368). diff --git a/patches/ds-bot/files/src/host/project-board.js b/patches/ds-bot/files/src/host/project-board.js index c6f55608d..7fdaac217 100644 --- a/patches/ds-bot/files/src/host/project-board.js +++ b/patches/ds-bot/files/src/host/project-board.js @@ -286,13 +286,23 @@ export function install(rt) { // #2041: a name that came from a meeting keeps that meeting's own cards, because opening the // file is checked against the same rule the board paints those cards with. const cardsOf = new Map() + const named = new Map() for (const meeting of Object.values(rt.state?.meetings ?? {})) { if (meeting === null || typeof meeting !== 'object' || meeting.status !== 'decided') continue if (!inProject(meeting, project)) continue const archivedDir = text(meeting.decisionDir) if (archivedDir !== '' && !folders.includes(archivedDir)) folders.push(archivedDir) const archived = await archivedOf(meeting) - if (archived === undefined) continue + if (archived === undefined) { + // A record written before the archive slice names no folder: its file is one of the rows of + // the Project's own listing, and the meeting still names the cards it decided. Kept aside + // until that listing is deduped, so only a name this read really listed carries the cards. + const path = text(meeting.decisionFile) + if (isDecisionPath(path) && !named.has(path)) { + named.set(path, Array.isArray(meeting.taskIds) ? meeting.taskIds.map(id => text(id)).filter(id => id !== '') : []) + } + continue + } found.push(archived) if (!cardsOf.has(archived.path)) { cardsOf.set(archived.path, Array.isArray(meeting.taskIds) ? meeting.taskIds.map(id => text(id)).filter(id => id !== '') : []) @@ -307,6 +317,13 @@ export function install(rt) { return true }) .sort((a, b) => (a.path < b.path ? -1 : a.path > b.path ? 1 : 0)) + // A record that saved no folder keeps the cards it decided, on the row this read listed for it + // and only that row: a name the folder did not list stays a ghost and opens nothing. A record + // that saved a folder wins over one that saved none for the same name, and an empty list still + // answers through the role list in `decisionVisible`. + for (const [path, ids] of named) { + if (!cardsOf.has(path) && deduped.some(file => file.path === path)) cardsOf.set(path, ids) + } // #2021: a `decisions/YYYY-MM-DD-….md` name sorts oldest first, so the cut has to take the tail. // Taking the head kept the 200 oldest files and dropped the ones just written — the wrong end of // the list. The order on screen stays ascending; only which rows survive at the cap changes. diff --git a/patches/ds-bot/files/test/project-board.test.js b/patches/ds-bot/files/test/project-board.test.js index 0ebc93df5..4b2c5185e 100644 --- a/patches/ds-bot/files/test/project-board.test.js +++ b/patches/ds-bot/files/test/project-board.test.js @@ -1370,3 +1370,179 @@ test('#2041: revoking a card closes the name a board read already cached', async rmSync(base, { recursive: true, force: true }) } }) + + +// A decided meeting written before the archive slice saved no folder, so its file is a row of the +// Project's own listing rather than one a meeting recorded. It still names the cards it decided, +// and the name has to keep them: with no card the role list answers, and a member who sees none of +// those cards reads the text. The two shapes must read the same, name by name. +const decisionFolder = (prefix) => { + const base = mkdtempSync(join(tmpdir(), prefix)) + const dir = join(base, 'project') + mkdirSync(join(dir, '.git'), { recursive: true }) + mkdirSync(join(dir, 'decisions')) + return { base, dir } +} + +// The owner the Project names is not a member record here, so a Bot's owner is card-affine and +// carries no Project role: the card door and the role list cannot be mistaken for each other. +const legacyFolderSeed = (dir, meetings) => { + const team = crossSeed() + team.projects['project-p1'].ownerUserIds = ['owner-9'] + team.projects['project-p1'].ownerUserId = 'owner-9' + team.projects['project-p1'].workDir = dir + team.projects['project-p1'].roles = { maintainers: [], members: ['owner-3'] } + team.members['owner-3'] = { id: 'owner-3', createdAt: 4, designatedChiefId: null } + team.meetings = meetings + return team +} + +const legacyMeeting = (id, overrides = {}) => ({ + id, status: 'decided', question: 'What shipped?', owner: 'Chief', project: 'project-p1', + decisionDir: '', decisionFile: `decisions/2026-10-29-${id}.md`, taskIds: ['task-group'], + createdAt: 1, updatedAt: 2, decidedAt: 3, ...overrides, +}) + +const signIn = (rt) => { + const members = { 'tok-1': 'owner-1', 'tok-2': 'owner-2', 'tok-3': 'owner-3' } + rt.authenticate = async token => (members[token] ? { memberId: members[token] } : null) + rt.state.authSessions = Object.fromEntries(Object.keys(members) + .map((token, at) => [`s-${at + 1}`, { memberId: members[token], tokenHash: token }])) +} + +const refused = (answer) => { + assert.equal(answer.ok, true, JSON.stringify(answer)) + assert.equal(answer.value.ok, false, 'a caller who sees none of the cards reads no text') + assert.equal('text' in answer.value, false) +} + +test('#2052: a record that saved no folder keeps the cards it decided, like one that saved a folder', async () => { + const { base, dir } = decisionFolder('ds-bot-decisions-record-') + writeFileSync(join(dir, 'decisions', '2026-10-29-nofolder.md'), '# decided with no folder\n') + writeFileSync(join(dir, 'decisions', '2026-10-29-folder.md'), '# decided with a folder\n') + const team = legacyFolderSeed(dir, { + 'm-nofolder': legacyMeeting('nofolder'), + 'm-folder': legacyMeeting('folder', { decisionDir: dir }), + }) + const { rt, callAs, stop } = await start(undefined, team) + try { + signIn(rt) + const board = await callAs('project-board', { id: 'project-p1' }, 'tok-3') + assert.equal(board.ok, true, JSON.stringify(board)) + assert.deepEqual(board.value.tasks ?? [], [], 'the member sees none of the cards this Project decides on') + for (const name of ['2026-10-29-nofolder.md', '2026-10-29-folder.md']) { + const path = `decisions/${name}` + assert.equal(board.value.decisions.files.some(file => file.path === path), true, `${path} is listed`) + const member = await callAs('project-decision', { id: 'project-p1', path }, 'tok-3') + refused(member) + assert.equal(member.value.reason, `not listed: ${path} is not in this board's decision list`) + } + // Card-affine and holding no Project role: the room's own admin reads both through the card door. + const noFolder = await callAs('project-decision', { id: 'project-p1', path: 'decisions/2026-10-29-nofolder.md' }, 'tok-1') + assert.equal(noFolder.value.ok, true, JSON.stringify(noFolder)) + assert.equal(noFolder.value.text, '# decided with no folder\n') + const folder = await callAs('project-decision', { id: 'project-p1', path: 'decisions/2026-10-29-folder.md' }, 'tok-1') + assert.equal(folder.value.ok, true, JSON.stringify(folder)) + assert.equal(folder.value.text, '# decided with a folder\n') + } finally { + await stop() + rmSync(base, { recursive: true, force: true }) + } +}) + +test('#2052: a record that decided no card still answers through the role list', async () => { + const { base, dir } = decisionFolder('ds-bot-decisions-nocard-') + writeFileSync(join(dir, 'decisions', '2026-10-29-nocard.md'), '# a record with no card\n') + const team = legacyFolderSeed(dir, { 'm-nocard': legacyMeeting('nocard', { taskIds: [] }) }) + const { rt, callAs, stop } = await start(undefined, team) + try { + signIn(rt) + await callAs('project-board', { id: 'project-p1' }, 'tok-3') + const member = await callAs('project-decision', { id: 'project-p1', path: 'decisions/2026-10-29-nocard.md' }, 'tok-3') + assert.equal(member.value.ok, true, JSON.stringify(member)) + assert.equal(member.value.text, '# a record with no card\n', 'a name no card binds follows the role list') + // The same name is still a name, not a list: a caller outside both doors reads nothing. + await callAs('project-board', { id: 'project-p1' }, 'tok-2') + const outsider = await callAs('project-decision', { id: 'project-p1', path: 'decisions/2026-10-29-nocard.md' }, 'tok-2') + refused(outsider) + assert.equal(outsider.value.reason, "not listed: decisions/2026-10-29-nocard.md is not in this board's decision list") + } finally { + await stop() + rmSync(base, { recursive: true, force: true }) + } +}) + +test('#2052: a record naming a file the folder did not list opens nothing', async () => { + const { base, dir } = decisionFolder('ds-bot-decisions-ghost-') + const team = legacyFolderSeed(dir, { 'm-ghost': legacyMeeting('ghost') }) + const { rt, callAs, stop } = await start(undefined, team) + try { + signIn(rt) + await callAs('project-board', { id: 'project-p1' }, 'tok-1') + for (const token of ['tok-1', 'tok-3']) { + const answer = await callAs('project-decision', { id: 'project-p1', path: 'decisions/2026-10-29-ghost.md' }, token) + refused(answer) + assert.equal(answer.value.reason, "not listed: decisions/2026-10-29-ghost.md is not in this board's decision list", + 'a name the listing never had stays a ghost') + } + } finally { + await stop() + rmSync(base, { recursive: true, force: true }) + } +}) + +test('#2052: a record of one Project puts no cards on another Project name', async () => { + const { base, dir } = decisionFolder('ds-bot-decisions-cross-') + writeFileSync(join(dir, 'decisions', '2026-11-01-shared.md'), '# read through the other Project\n') + const team = legacyFolderSeed(dir, { 'm-shared': legacyMeeting('shared', { decisionFile: 'decisions/2026-11-01-shared.md' }) }) + // The second Project lists the same relative name in the same folder and has a role for owner-1. + team.projects['project-p2'].ownerUserId = 'owner-9' + team.projects['project-p2'].workDir = dir + team.projects['project-p2'].roles = { maintainers: [], members: ['owner-1'] } + const { rt, callAs, stop } = await start(undefined, team) + try { + signIn(rt) + // The first Project's record binds its own card to its own read: its member still reads nothing. + await callAs('project-board', { id: 'project-p1' }, 'tok-3') + const mine = await callAs('project-decision', { id: 'project-p1', path: 'decisions/2026-11-01-shared.md' }, 'tok-3') + refused(mine) + // The second Project has no record for the name: its role list decides, and owner-1 reaches it. + await callAs('project-board', { id: 'project-p2' }, 'tok-1') + const theirs = await callAs('project-decision', { id: 'project-p2', path: 'decisions/2026-11-01-shared.md' }, 'tok-1') + assert.equal(theirs.value.ok, true, JSON.stringify(theirs)) + assert.equal(theirs.value.text, '# read through the other Project\n', 'a record of one Project gates only its own names') + } finally { + await stop() + rmSync(base, { recursive: true, force: true }) + } +}) + +test('#2052: two records naming one file keep the cards the first one decided', async () => { + const { base, dir } = decisionFolder('ds-bot-decisions-twice-') + const archive = join(base, 'archive') + mkdirSync(join(archive, 'decisions'), { recursive: true }) + writeFileSync(join(archive, 'decisions', '2026-11-02-twice.md'), '# the first record decided it\n') + const team = legacyFolderSeed(dir, { + 'm-first': legacyMeeting('first', { decisionDir: archive, decisionFile: 'decisions/2026-11-02-twice.md' }), + 'm-second': legacyMeeting('second', { decisionDir: archive, decisionFile: 'decisions/2026-11-02-twice.md', taskIds: [] }), + }) + const { rt, callAs, stop } = await start(undefined, team) + try { + signIn(rt) + for (const round of ['first read', 'second read']) { + const board = await callAs('project-board', { id: 'project-p1' }, 'tok-3') + assert.equal(board.value.decisions.files.some(file => file.path === 'decisions/2026-11-02-twice.md'), true, + `${round}: one row per name`) + const member = await callAs('project-decision', { id: 'project-p1', path: 'decisions/2026-11-02-twice.md' }, 'tok-3') + refused(member) + assert.equal(member.value.reason, "not listed: decisions/2026-11-02-twice.md is not in this board's decision list", + `${round}: the first record supplies the cards`) + } + const own = await callAs('project-decision', { id: 'project-p1', path: 'decisions/2026-11-02-twice.md' }, 'tok-1') + assert.equal(own.value.ok, true, JSON.stringify(own)) + assert.equal(own.value.text, '# the first record decided it\n') + } finally { + await stop() + rmSync(base, { recursive: true, force: true }) + } +})