Skip to content

dectime determination when loading metadata - minutes conversion might be false #132

Description

@luise-wei

In util/SEBESOLWEIGCommonFiles/Solweig_v2015_metdata_noload.py the dectime is loaded in this way:

dectime = met[:, 1] + met[:, 2] / 24 + met[:, 3] / (60 * 24.0)

The columns of the metadata used are column 1, 2 and 3, i.e. id, it and imin respectively.
I understand the columns as follows:

  • id: Day of Year
  • it: hour of day (integer in the range 0-23)
  • imin: minute of hour (integer in the range 0-59)

This is at least given in the manual as well

The last part of the dectime calculation implies that imin is giving minutes of day independently from the current hour (so integer in the range 0-60*24).

I think it should be corrected to:
dectime = met[:, 1] + met[:, 2] / 24 + met[:, 3] / 60

I guess, often metfiles with imin=0 are used, i.e. hourly timesteps. Hence, this issue never showed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions