SendCommand and sensPositionData not used

[Pascal66]

Hello, seems the code isnt complete as it never send command to the serial openened

image-processing/RCJ_2014/RCJ_2014.cpp

Line 539 in b942be8

void sendPositionData( void ){

image-processing/RCJ_2014/RCJ_2014.cpp

Line 567 in b942be8

void sendCommand( char command_1, char command_2 ){

[abaeyens]

Hi Pascal,

Thank you for your interest in the code!
Indeed, the function wasn't invoked in the main loop. The measurements were done, yet no actual data was sent out over the serial port.

I've added the function invocations in the main loop. They are currently commented out.

image-processing/RCJ_2014/RCJ_2014.cpp

Lines 245 to 249 in 771d8aa

	// Copy I error to variable for serial transmission.
	I_Error=lineangle();
	// Send the course errors (P_Error and I_Error over the serial port.
	// Uncomment to enable.
	//sendPositionData();

As I currently can't build the code, the edit is under a new branch (testing). Could you report back whether the code still compiles and works?

[Pascal66]

Thank you for answering :)
you send the PID result then, ok.
As i'm not using a raspi, i've to do many work before trying that, but I do my best :)

[webbrain-one]

Thanks for catching this! I’ve opened a pull request to address it: #3. It updates the code to properly use SendCommand and sensPositionData so that the expected commands are actually sent over the serial connection. Please take a look when you have a moment and let me know if you have any feedback. Thanks again!