diff --git a/README.md b/README.md index c071733..dd38ea3 100644 --- a/README.md +++ b/README.md @@ -350,8 +350,9 @@ BSP Z2UI5_HOST_FE the Fiori elements app - One frontend per page: the first control that starts decides where it comes from; every control still sends its roundtrips to its own endpoint. -- Embedding is still page-wide in places - busy indicator, title, the - `sap.m.App` root - until abap2UI5's embedded mode covers them +- Embedding is still page-wide in places up to abap2UI5 1.147.0 - busy + indicator, title, the full-screen `sap.m.App` root; the release after + 1.147.0 leaves them to the host, with a `sap.m.NavContainer` as the root ([backlog item](https://github.com/abap2UI5/abap2UI5/blob/main/backlog/items/embed-as-reuse-component.md)); the URL hash is the host's from abap2UI5 1.146.0 on. - Custom controls from `Z2UI5_CCI`/`Z2UI5_CCC`: the bundle hands over their diff --git a/test/e2e/card.spec.mjs b/test/e2e/card.spec.mjs index d296433..74a3f34 100644 --- a/test/e2e/card.spec.mjs +++ b/test/e2e/card.spec.mjs @@ -113,9 +113,9 @@ test( }, ); -// The app takes the room the card gives it and no more: sap.m.App and -// sap.m.Shell set height:100% on every ancestor up to , unless the -// control marks its area as their root. +// The app takes the room the card gives it and no more: sap.m.App (the +// root up to abap2UI5 1.147.0) and sap.m.Shell set height:100% on every +// ancestor up to , unless the control marks its area as their root. test("the card keeps the height of its content", async ({ page }) => { const box = await card(page, "hello").boundingBox(); const app = await card(page, "hello") diff --git a/test/e2e/freestyle.spec.mjs b/test/e2e/freestyle.spec.mjs index a629e90..88e2b96 100644 --- a/test/e2e/freestyle.spec.mjs +++ b/test/e2e/freestyle.spec.mjs @@ -53,10 +53,10 @@ test("the embedded app stays inside its container", async ({ page }) => { } }); -// sap.m.App - the frontend's root - and sap.m.Shell set height:100% on every -// ancestor that has no height, up to , unless they meet an element -// marked as root content. The control marks its area, so the host's layout -// above it stays the way the host made it. +// sap.m.App - the frontend's root up to abap2UI5 1.147.0 - and sap.m.Shell +// set height:100% on every ancestor that has no height, up to , +// unless they meet an element marked as root content. The control marks +// its area, so the host's layout above it stays the way the host made it. test("the embedded app leaves the host's layout alone", async ({ page }) => { const heights = await container(page, "single").evaluate((el) => { const set = [];