From aaf02866aefe647cd55076702f43f44e79ec840c Mon Sep 17 00:00:00 2001 From: Jiang Tian Date: Mon, 16 Jun 2025 11:40:53 +0800 Subject: [PATCH] Fix npe when closing a last reader that have not been used (#513) * fix npe when closing a last reader that have not been used * spotless --- .../org/apache/tsfile/read/reader/TsFileLastReader.java | 2 +- .../org/apache/tsfile/read/reader/TsFileLastReaderTest.java | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/java/tsfile/src/main/java/org/apache/tsfile/read/reader/TsFileLastReader.java b/java/tsfile/src/main/java/org/apache/tsfile/read/reader/TsFileLastReader.java index f89b30df6b..312b73ddeb 100644 --- a/java/tsfile/src/main/java/org/apache/tsfile/read/reader/TsFileLastReader.java +++ b/java/tsfile/src/main/java/org/apache/tsfile/read/reader/TsFileLastReader.java @@ -305,7 +305,7 @@ private void init() throws IOException { @Override public void close() throws Exception { - if (asyncIO) { + if (asyncIO && asyncTask != null) { asyncTask.cancel(true); } sequenceReader.close(); diff --git a/java/tsfile/src/test/java/org/apache/tsfile/read/reader/TsFileLastReaderTest.java b/java/tsfile/src/test/java/org/apache/tsfile/read/reader/TsFileLastReaderTest.java index b9211a56c3..19a2fcd043 100644 --- a/java/tsfile/src/test/java/org/apache/tsfile/read/reader/TsFileLastReaderTest.java +++ b/java/tsfile/src/test/java/org/apache/tsfile/read/reader/TsFileLastReaderTest.java @@ -368,4 +368,10 @@ public void testManyRead() throws Exception { } file.delete(); } + + @Test + public void testCreateButNotRead() throws Exception { + createFile(10, 10, 10); + try (TsFileLastReader ignored = new TsFileLastReader(filePath)) {} + } }