From 967fecf35496a526c031ff58d720403817a71751 Mon Sep 17 00:00:00 2001 From: Bradley Hilton Date: Mon, 16 Nov 2026 14:00:20 -0800 Subject: [PATCH] fix: require VS Code 1.101 for Puppeteer runtime compatibility --- CHANGELOG.md | 1 + README.md | 4 +++- package-lock.json | 46 +++++++++++++++++++++++----------------------- package.json | 2 +- 4 files changed, 28 insertions(+), 25 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2d3c81c..3fe2e47 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ - Fix release preparation on the `release` branch, synchronize and commit lockfile versions, and accept dated changelog headings without requiring a horizontal-rule separator. - Use an empty regular Git configuration file for release regression fixtures instead of an OS null-device path, which Git for Windows rejects. - Remove the built-in spellchecker, bundled cspell dependencies, spelling toolbar/setting, and background checks; retain external diagnostics and replacement quick fixes from optional extensions such as Code Spell Checker. +- Raise the minimum VS Code version to 1.101.0 (Node 22.15.1) for Puppeteer 25's Node 22.12+ requirement; retain the ESM export runtime and verify packaged HTML/PDF commands in that minimum editor on macOS ARM64. ## 0.2.12 - Package one universal, JavaScript-only VSIX; Atomic's platform library is supplied by the separate Atomic installation on the extension host. diff --git a/README.md b/README.md index 5599e6f..06fba84 100644 --- a/README.md +++ b/README.md @@ -20,7 +20,7 @@ Local packages are written to `releases/`. Use the version confirmed by the buil **Do not choose Markdown Preview.** It is the editor's generic read-only Markdown renderer and cannot display Atomic ticket fields. -The extension package is `atomic-sherpa` (extension ID `atomicdotdev.atomic-sherpa`) and requires VS Code API 1.97+. Editor commands, settings, and custom-editor IDs use the `sherpaIntent.*` namespace; version-control commands use `sherpaAtomic.*`. These do not collide with the original MEO extension. Ordinary Markdown keeps its current editor unless you explicitly choose Atomic Sherpa Intent Editor. +The extension package is `atomic-sherpa` (extension ID `atomicdotdev.atomic-sherpa`) and requires VS Code 1.101.0+. Editor commands, settings, and custom-editor IDs use the `sherpaIntent.*` namespace; version-control commands use `sherpaAtomic.*`. These do not collide with the original MEO extension. Ordinary Markdown keeps its current editor unless you explicitly choose Atomic Sherpa Intent Editor. ## Ticket layout @@ -96,6 +96,8 @@ There is no CLI subprocess, daemon startup, socket, direct database access, or w Build requirements: Node.js 22+/npm (for VSCE 4), Bun, and a VS Code-compatible editor. The universal nodeatomic JavaScript consumer and its generated codecs are vendored at `vendor/nodeatomic`; its NOTICE records the source revision. A clean checkout builds without a sibling repository. Refresh that directory from the nodeatomic producer when its descriptor, API, or runtime loader changes. Its compiled codecs/fingerprint are bundled, so the resulting VSIX does not need the vendor directory. Atomic Sherpa never builds Rust or searches for Atomic producer sources. Building/packaging does not require a native library unless an explicit runtime override requests the native smoke. +The minimum editor, VS Code 1.101.0, bundles Electron 35.5.1 and Node 22.15.1. Puppeteer 25 requires Node 22.12+; VS Code 1.100.x still uses Node 20 and is not supported. Keep Puppeteer's separate ESM export bundle. Packaged HTML/PDF export commands were verified in the actual VS Code 1.101.0 extension host on macOS ARM64 with Chrome, including Mermaid, inline/block math, highlighting, and embedded local images. Windows/Linux minimum-version extension-host validation remains required. + The vendored codecs and compatibility fingerprint are generated from the published Atomic v0.22.0 library, not from a development checkout. To adopt another runtime contract, regenerate the upstream nodeatomic package against that complete release, then refresh its built package and provenance notice here. Never change only the expected fingerprint or weaken the loader's contract checks. ```sh diff --git a/package-lock.json b/package-lock.json index e4dc5c0..df1258a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -61,7 +61,7 @@ "typescript": "^5.9.3" }, "engines": { - "vscode": "^1.97.0" + "vscode": "^1.101.0" } }, "../nodeatomic": { @@ -944,9 +944,9 @@ } }, "node_modules/@puppeteer/browsers": { - "version": "3.2.6", - "resolved": "https://registry.npmjs.org/@puppeteer/browsers/-/browsers-3.2.6.tgz", - "integrity": "sha512-MJP29gVoHznmqmwhH1tlZqzfeQ3aylTpSSa6WKZXtkwYUH02i9imBmWGTyZrbnAou5paX78SE4jMAUqnEPf8ug==", + "version": "3.2.7", + "resolved": "https://registry.npmjs.org/@puppeteer/browsers/-/browsers-3.2.7.tgz", + "integrity": "sha512-B3C/v8OEEaJYcN1IzzgbPmt+GbFANr4Mf/NrqNuGk/dIchrv6quNqxgT+A6qE0Ge0MN95NjKUddcR1JMpYRMWA==", "license": "Apache-2.0", "dependencies": { "modern-tar": "^0.8.6", @@ -1766,9 +1766,9 @@ } }, "node_modules/ansi-regex": { - "version": "6.5.0", - "resolved": "https://registry.npmjs.org/ansi-regex/-/ansi-regex-6.5.0.tgz", - "integrity": "sha512-zhvbbbdt1kbw7EJ9OQoxmQcuaNR9P5kTj7e/YdmOSU10aHWbycofJxA6jKfoEy3vlLdctOF9ZHaxLtmSm998wQ==", + "version": "6.6.0", + "resolved": "https://registry.npmjs.org/ansi-regex/-/ansi-regex-6.6.0.tgz", + "integrity": "sha512-XZ5apbzreCbXSKwPjJstu8R0zOi247w3XYwWxtwBXgpZrCyc1Ka7p9/xY0A9/diMewmHbEKz+FIraWaEWjlN5g==", "license": "MIT", "engines": { "node": ">=12" @@ -2750,9 +2750,9 @@ } }, "node_modules/devtools-protocol": { - "version": "0.0.1704951", - "resolved": "https://registry.npmjs.org/devtools-protocol/-/devtools-protocol-0.0.1704951.tgz", - "integrity": "sha512-GQhQOs9u/Mvm1zMtJIH872JS4AskuZdUSsPNPk4ChahtWAUqgz6atEtIsMt+nO7MqF1Ic4HxII/k8Cu36JivNg==", + "version": "0.0.1717327", + "resolved": "https://registry.npmjs.org/devtools-protocol/-/devtools-protocol-0.0.1717327.tgz", + "integrity": "sha512-3RDLDzyvv8XAYf1L+TL1og0EEk0eOW1Jn0yi88uG6Bj8fUKO1ZKfgNtwbJkqf5SWdPDS4VGEPxwdUWz78V6Xcg==", "license": "BSD-3-Clause" }, "node_modules/dom-serializer": { @@ -4965,17 +4965,17 @@ } }, "node_modules/puppeteer-core": { - "version": "25.16.0", - "resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-25.16.0.tgz", - "integrity": "sha512-VA5Pf54N8shfopNkZZXCdiiwfnnY8ZJYAMqFQRhlH5mGUhfwf53Ar770GPtdpTDLUqvQeYpIBtC9/G2Jij2IJw==", + "version": "25.17.0", + "resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-25.17.0.tgz", + "integrity": "sha512-YAgBitkd+K9gxRt+wzBAFTTkGjkC8aC2o4OxofsU8JUy2nnK/RflTCJ9bRCvCMNbq9TPhqFk4Phz98otN9FrGg==", "license": "Apache-2.0", "dependencies": { - "@puppeteer/browsers": "3.2.6", + "@puppeteer/browsers": "3.2.7", "chromium-bidi": "157.0.8090-0", - "devtools-protocol": "0.0.1704951", + "devtools-protocol": "0.0.1717327", "typed-query-selector": "^2.12.3", - "webdriver-bidi-protocol": "1.0.1", - "ws": "^8.22.0" + "webdriver-bidi-protocol": "1.0.2", + "ws": "^8.22.1" }, "engines": { "node": ">=22.12.0" @@ -5817,9 +5817,9 @@ "license": "MIT" }, "node_modules/webdriver-bidi-protocol": { - "version": "1.0.1", - "resolved": "https://registry.npmjs.org/webdriver-bidi-protocol/-/webdriver-bidi-protocol-1.0.1.tgz", - "integrity": "sha512-WXWs/aXF2a6Al1Z2/V/7Gp2oPZOAAmHjJOTmv4KCXRJ122IMj3tSSMc6a4q3K4QOmhQbse/Ahr+oTVJOU2dUiw==", + "version": "1.0.2", + "resolved": "https://registry.npmjs.org/webdriver-bidi-protocol/-/webdriver-bidi-protocol-1.0.2.tgz", + "integrity": "sha512-nghazPI+J5RrLZ+qb6vMjC6l1/tnwqr2muVEax4Ufd6eIdcjeqNnhLsAxTG9s+7Zf4umgf0DrEwDC8CoU91nAA==", "license": "Apache-2.0" }, "node_modules/whatwg-mimetype": { @@ -5874,9 +5874,9 @@ "license": "ISC" }, "node_modules/ws": { - "version": "8.22.0", - "resolved": "https://registry.npmjs.org/ws/-/ws-8.22.0.tgz", - "integrity": "sha512-Ydggc987+RO0AnWtZ/7Wq9FtNvcrL1b/RO0ud9mWjUPgDrsAAwQSF51sm2hm1XofbU/4jkpGEsLFsZZxU+1DOg==", + "version": "8.23.0", + "resolved": "https://registry.npmjs.org/ws/-/ws-8.23.0.tgz", + "integrity": "sha512-wCkmX8QMOrKjgO8HW2WyDbTSGeqkocxgDzS9iR79rEAexty6/2qzilx3Ag8Tqf9ykop3irLKle0MtVn5qjVnoQ==", "license": "MIT", "engines": { "node": ">=10.0.0" diff --git a/package.json b/package.json index b7e4a4b..087c932 100644 --- a/package.json +++ b/package.json @@ -7,7 +7,7 @@ "license": "MIT", "icon": "backpack.png", "engines": { - "vscode": "^1.97.0" + "vscode": "^1.101.0" }, "categories": [ "SCM Providers",