From 66f18008593a24f5894e83d5f0f185ce6ecbb5f0 Mon Sep 17 00:00:00 2001 From: Mason Wheeler Date: Fri, 31 Jul 2026 10:51:56 -0700 Subject: [PATCH 1/2] fix(sfcompute): report H100 memory as 80 GiB --- v1/providers/sfcomputev2/instancetype.go | 2 +- v1/providers/sfcomputev2/instancetype_test.go | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 v1/providers/sfcomputev2/instancetype_test.go diff --git a/v1/providers/sfcomputev2/instancetype.go b/v1/providers/sfcomputev2/instancetype.go index bda56e4..79ebe5e 100644 --- a/v1/providers/sfcomputev2/instancetype.go +++ b/v1/providers/sfcomputev2/instancetype.go @@ -44,7 +44,7 @@ var h100InstanceTypeMetadata = func() sfcInstanceTypeMetadata { m := sfcInstanceTypeMetadata{ diskBytes: v1.NewBytes(1500, v1.Gigabyte), memoryBytes: v1.NewBytes(960, v1.Gigabyte), - gpuVRAM: v1.NewBytes(80, v1.Gigabyte), + gpuVRAM: v1.NewBytes(80, v1.Gibibyte), vcpu: sfcVCPU, gpuCount: sfcGPUCount, gpuManufacturer: v1.ManufacturerNVIDIA, diff --git a/v1/providers/sfcomputev2/instancetype_test.go b/v1/providers/sfcomputev2/instancetype_test.go new file mode 100644 index 0000000..a1584b0 --- /dev/null +++ b/v1/providers/sfcomputev2/instancetype_test.go @@ -0,0 +1,18 @@ +package v2 + +import ( + "testing" + + "github.com/alecthomas/units" + v1 "github.com/brevdev/cloud/v1" + "github.com/stretchr/testify/require" +) + +func TestH100InstanceTypeReports80GiBGPUVRAM(t *testing.T) { + instanceType := buildInstanceType(h100InstanceTypeMetadata, true) + require.Len(t, instanceType.SupportedGPUs, 1) + + gpu := instanceType.SupportedGPUs[0] + require.Equal(t, 80*units.Gibibyte, gpu.Memory) + require.True(t, gpu.MemoryBytes.Equal(v1.NewBytes(80, v1.Gibibyte))) +} From fd82e43eac0cf352957696268d3d2c36eec3164d Mon Sep 17 00:00:00 2001 From: Mason Wheeler Date: Fri, 31 Jul 2026 13:16:28 -0700 Subject: [PATCH 2/2] test(sfcompute): remove GPU memory regression test --- v1/providers/sfcomputev2/instancetype_test.go | 18 ------------------ 1 file changed, 18 deletions(-) delete mode 100644 v1/providers/sfcomputev2/instancetype_test.go diff --git a/v1/providers/sfcomputev2/instancetype_test.go b/v1/providers/sfcomputev2/instancetype_test.go deleted file mode 100644 index a1584b0..0000000 --- a/v1/providers/sfcomputev2/instancetype_test.go +++ /dev/null @@ -1,18 +0,0 @@ -package v2 - -import ( - "testing" - - "github.com/alecthomas/units" - v1 "github.com/brevdev/cloud/v1" - "github.com/stretchr/testify/require" -) - -func TestH100InstanceTypeReports80GiBGPUVRAM(t *testing.T) { - instanceType := buildInstanceType(h100InstanceTypeMetadata, true) - require.Len(t, instanceType.SupportedGPUs, 1) - - gpu := instanceType.SupportedGPUs[0] - require.Equal(t, 80*units.Gibibyte, gpu.Memory) - require.True(t, gpu.MemoryBytes.Equal(v1.NewBytes(80, v1.Gibibyte))) -}