From 7e4fec91bce2a68778a60be6bf57bff18aef9c43 Mon Sep 17 00:00:00 2001 From: priyam0k Date: Mon, 9 Nov 2026 19:39:25 +0530 Subject: [PATCH 1/3] Guard zero case reserve --- chainladder/core/pandas.py | 33 +++++++++---------- chainladder/development/outstanding.py | 30 +++++++---------- .../development/tests/test_outstanding.py | 27 +++++++++++++++ 3 files changed, 54 insertions(+), 36 deletions(-) diff --git a/chainladder/core/pandas.py b/chainladder/core/pandas.py index cd0defa5f..ed63c467e 100644 --- a/chainladder/core/pandas.py +++ b/chainladder/core/pandas.py @@ -1321,24 +1321,21 @@ def agg_func( func: Callable = getattr(xp, v) kwargs.update({"keepdims": True}) # Apply the function on the requested axis. - if axis in [0, 1] and not obj.is_full: - with warnings.catch_warnings(): - # the lower right half of an undeveloped triangle will always emit an - # empty or All-NaN slice warning when aggregating by index or column - # (depending on `func`; e.g. nanmean warns "empty slice", - # nanmax warns All-NaN slice - warnings.filterwarnings( - "ignore", - category=RuntimeWarning, - message=".*empty slice.*", - ) - warnings.filterwarnings( - "ignore", - category=RuntimeWarning, - message=".*All-NaN slice.*", - ) - obj.values = func(obj.values, axis=axis, *args, **kwargs) - else: + with warnings.catch_warnings(): + # Undeveloped triangles or all-NaN slices can emit an + # empty or All-NaN slice warning when aggregating + # (depending on `func`; e.g. nanmean warns "empty slice", + # nanmax warns "All-NaN slice") + warnings.filterwarnings( + "ignore", + category=RuntimeWarning, + message=".*empty slice.*", + ) + warnings.filterwarnings( + "ignore", + category=RuntimeWarning, + message=".*All-NaN slice.*", + ) obj.values = func(obj.values, axis=axis, *args, **kwargs) # Aggregation function will collapse a dimension, so diff --git a/chainladder/development/outstanding.py b/chainladder/development/outstanding.py index cc76ae231..ce670386c 100644 --- a/chainladder/development/outstanding.py +++ b/chainladder/development/outstanding.py @@ -169,16 +169,16 @@ def fit(self, X, y=None, sample_weight=None): ) case_to_prior_case_naned = self.case_to_prior_case_ - case_to_prior_case_naned.values = num_to_nan(self.case_to_prior_case_.values) - - self.case_ldf_ = self.case_to_prior_case_.mean(2) # this has the wrong value - self.case_ldf_.values = case_to_prior_case_naned.mean(axis=2).values + case_to_prior_case_naned.values = num_to_nan(case_to_prior_case_naned.values) + self.case_ldf_ = case_to_prior_case_naned.mean(axis=2) + xp = self.case_ldf_.get_array_module() + self.case_ldf_.values[xp.isnan(self.case_ldf_.values)] = 1.0 paid_to_prior_case_naned = self.paid_to_prior_case_ - paid_to_prior_case_naned.values = num_to_nan(self.paid_to_prior_case_.values) - - self.paid_ldf_ = self.paid_to_prior_case_.mean(2) # this has the wrong value - self.paid_ldf_.values = paid_to_prior_case_naned.mean(axis=2).values + paid_to_prior_case_naned.values = num_to_nan(paid_to_prior_case_naned.values) + self.paid_ldf_ = paid_to_prior_case_naned.mean(axis=2) + xp = self.paid_ldf_.get_array_module() + self.paid_ldf_.values[xp.isnan(self.paid_ldf_.values)] = 0.0 self.ldf_ = self._set_ldf(self.X_).set_backend(backend) @@ -271,11 +271,8 @@ def case_to_prior_case_(self): paid_tri = paid_tri.groupby(self.groupby).sum() incurred_tri = incurred_tri.groupby(self.groupby).sum() - out = ( - (incurred_tri - paid_tri).iloc[..., 1:] - * self.case_w_ - / (incurred_tri - paid_tri).iloc[..., :-1].values - ) + prior_case = num_to_nan((incurred_tri - paid_tri).iloc[..., :-1].values) + out = (incurred_tri - paid_tri).iloc[..., 1:] * self.case_w_ / prior_case out.is_pattern = True out.is_cumulative = False @@ -290,11 +287,8 @@ def paid_to_prior_case_(self): paid_tri = paid_tri.groupby(self.groupby).sum() incurred_tri = incurred_tri.groupby(self.groupby).sum() - out = ( - paid_tri.cum_to_incr().iloc[..., 1:] - * self.paid_w_ - / (incurred_tri - paid_tri).iloc[..., :-1].values - ) + prior_case = num_to_nan((incurred_tri - paid_tri).iloc[..., :-1].values) + out = paid_tri.cum_to_incr().iloc[..., 1:] * self.paid_w_ / prior_case out.is_pattern = True return out diff --git a/chainladder/development/tests/test_outstanding.py b/chainladder/development/tests/test_outstanding.py index c177d70a5..599851d8c 100644 --- a/chainladder/development/tests/test_outstanding.py +++ b/chainladder/development/tests/test_outstanding.py @@ -320,3 +320,30 @@ def test_approach_2_single_channel_case_triangle_and_transform(): ).fit(tri_grouped) assert m_grp.case_to_prior_case_ is not None assert m_grp.paid_to_prior_case_ is not None + + +def test_case_outstanding_zero_case_reserve_warning(): + import warnings + + xyz = cl.load_sample("friedland_xyz_auto_bi") + with warnings.catch_warnings(): + warnings.filterwarnings("error", category=RuntimeWarning) + model = cl.CaseOutstanding( + paid_to_incurred=("Paid Claims", "Reported Claims") + ).fit(xyz) + assert model.paid_ldf_ is not None + assert not model.case_ldf_.to_frame().isna().any().any() + + # Synthetic triangle with zero prior case + p = cl.load_sample("genins") + p.columns = ["paid"] + i = p.copy() + i.columns = ["incurred"] + i.values = p.values + 100 + # Force case to zero at earlier development maturity + i.values[..., 2] = p.values[..., 2] + tri = cl.concat((p, i), 1) + with warnings.catch_warnings(): + warnings.filterwarnings("error", category=RuntimeWarning) + m_zero = cl.CaseOutstanding(paid_to_incurred=("paid", "incurred")).fit(tri) + assert not m_zero.case_ldf_.to_frame().isna().any().any() From 841a1acfdaec1e423fc6348af29e3316913234cc Mon Sep 17 00:00:00 2001 From: priyam0k Date: Wed, 11 Nov 2026 00:27:53 +0530 Subject: [PATCH 2/3] Address PR review comments --- chainladder/core/pandas.py | 33 ++++++++++-------- chainladder/development/outstanding.py | 34 +++++++++++++------ .../development/tests/test_outstanding.py | 5 ++- 3 files changed, 45 insertions(+), 27 deletions(-) diff --git a/chainladder/core/pandas.py b/chainladder/core/pandas.py index ed63c467e..cd0defa5f 100644 --- a/chainladder/core/pandas.py +++ b/chainladder/core/pandas.py @@ -1321,21 +1321,24 @@ def agg_func( func: Callable = getattr(xp, v) kwargs.update({"keepdims": True}) # Apply the function on the requested axis. - with warnings.catch_warnings(): - # Undeveloped triangles or all-NaN slices can emit an - # empty or All-NaN slice warning when aggregating - # (depending on `func`; e.g. nanmean warns "empty slice", - # nanmax warns "All-NaN slice") - warnings.filterwarnings( - "ignore", - category=RuntimeWarning, - message=".*empty slice.*", - ) - warnings.filterwarnings( - "ignore", - category=RuntimeWarning, - message=".*All-NaN slice.*", - ) + if axis in [0, 1] and not obj.is_full: + with warnings.catch_warnings(): + # the lower right half of an undeveloped triangle will always emit an + # empty or All-NaN slice warning when aggregating by index or column + # (depending on `func`; e.g. nanmean warns "empty slice", + # nanmax warns All-NaN slice + warnings.filterwarnings( + "ignore", + category=RuntimeWarning, + message=".*empty slice.*", + ) + warnings.filterwarnings( + "ignore", + category=RuntimeWarning, + message=".*All-NaN slice.*", + ) + obj.values = func(obj.values, axis=axis, *args, **kwargs) + else: obj.values = func(obj.values, axis=axis, *args, **kwargs) # Aggregation function will collapse a dimension, so diff --git a/chainladder/development/outstanding.py b/chainladder/development/outstanding.py index 5f4953c63..2cbb57311 100644 --- a/chainladder/development/outstanding.py +++ b/chainladder/development/outstanding.py @@ -12,6 +12,7 @@ import numpy as np import pandas as pd +import warnings if TYPE_CHECKING: from chainladder.core import Triangle @@ -168,17 +169,28 @@ def fit(self, X, y=None, sample_weight=None): Development(n_periods=self.case_n_periods).fit(self.X_.sum(0).sum(1)).w_ ) - case_to_prior_case_naned = self.case_to_prior_case_ * self.case_w_ - case_to_prior_case_naned.values = num_to_nan(case_to_prior_case_naned.values) - self.case_ldf_ = case_to_prior_case_naned.mean(axis=2) - xp = self.case_ldf_.get_array_module() - self.case_ldf_.values[xp.isnan(self.case_ldf_.values)] = 1.0 - - paid_to_prior_case_naned = self.paid_to_prior_case_ * self.paid_w_ - paid_to_prior_case_naned.values = num_to_nan(paid_to_prior_case_naned.values) - self.paid_ldf_ = paid_to_prior_case_naned.mean(axis=2) - xp = self.paid_ldf_.get_array_module() - self.paid_ldf_.values[xp.isnan(self.paid_ldf_.values)] = 0.0 + with warnings.catch_warnings(): + warnings.filterwarnings( + "ignore", + category=RuntimeWarning, + message=".*empty slice.*", + ) + warnings.filterwarnings( + "ignore", + category=RuntimeWarning, + message=".*All-NaN slice.*", + ) + case_to_prior_case_naned = self.case_to_prior_case_ * self.case_w_ + case_to_prior_case_naned.values = num_to_nan( + case_to_prior_case_naned.values + ) + self.case_ldf_ = case_to_prior_case_naned.mean(axis=2).fillna(1.0) + + paid_to_prior_case_naned = self.paid_to_prior_case_ * self.paid_w_ + paid_to_prior_case_naned.values = num_to_nan( + paid_to_prior_case_naned.values + ) + self.paid_ldf_ = paid_to_prior_case_naned.mean(axis=2).fillzero() self.ldf_ = self._set_ldf(self.X_).set_backend(backend) diff --git a/chainladder/development/tests/test_outstanding.py b/chainladder/development/tests/test_outstanding.py index 1b5cda2e8..0a3ecfb17 100644 --- a/chainladder/development/tests/test_outstanding.py +++ b/chainladder/development/tests/test_outstanding.py @@ -359,7 +359,10 @@ def test_case_outstanding_zero_case_reserve_warning(): assert model.paid_ldf_ is not None assert not model.case_ldf_.to_frame().isna().any().any() - # Synthetic triangle with zero prior case + +def test_case_outstanding_synthetic_zero_prior_case_warning(): + import warnings + p = cl.load_sample("genins") p.columns = ["paid"] i = p.copy() From c1fe126b13a0ff139afb49e9aefa8fc6b6031ee9 Mon Sep 17 00:00:00 2001 From: priyam0k Date: Thu, 19 Nov 2026 13:04:44 +0530 Subject: [PATCH 3/3] Use genins test fixture --- chainladder/development/tests/test_outstanding.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/chainladder/development/tests/test_outstanding.py b/chainladder/development/tests/test_outstanding.py index 0a3ecfb17..37f7fb76c 100644 --- a/chainladder/development/tests/test_outstanding.py +++ b/chainladder/development/tests/test_outstanding.py @@ -360,10 +360,10 @@ def test_case_outstanding_zero_case_reserve_warning(): assert not model.case_ldf_.to_frame().isna().any().any() -def test_case_outstanding_synthetic_zero_prior_case_warning(): +def test_case_outstanding_synthetic_zero_prior_case_warning(genins): import warnings - p = cl.load_sample("genins") + p = genins.set_backend("numpy").copy() p.columns = ["paid"] i = p.copy() i.columns = ["incurred"]