diff --git a/chainladder/methods/mack.py b/chainladder/methods/mack.py index 0af8a48ce..cbf9ac9d2 100644 --- a/chainladder/methods/mack.py +++ b/chainladder/methods/mack.py @@ -164,17 +164,21 @@ def fit(self, X, y=None, sample_weight=None): 2012 7162.2 693.2 2013 14396.9 901.4 """ + from chainladder.core.common import _get_full_triangle + super().fit(X, y, sample_weight) if "sigma_" not in self.X_: raise ValueError("Triangle not compatible with MackChainladder") + # The Mack recursion multiplies cumulative amounts, so the risk + # estimates use a cumulative copy of X_. + X_cum = self.X_.incr_to_cum() # Caching full_triangle_ for fit as it is called a lot - self.X_._full_triangle_ = self.full_triangle_ - self.parameter_risk_ = self._mack_recursion("parameter_risk_", self.X_) - self.process_risk_ = self._mack_recursion("process_risk_", self.X_) + X_cum._full_triangle_ = _get_full_triangle(X_cum, self.ultimate_) + self.parameter_risk_ = self._mack_recursion("parameter_risk_", X_cum) + self.process_risk_ = self._mack_recursion("process_risk_", X_cum) self.total_parameter_risk_ = self._mack_recursion( - "total_parameter_risk_", self.X_ + "total_parameter_risk_", X_cum ) - del self.X_._full_triangle_ self.process_variance_ = self._include_process_variance() return self @@ -238,17 +242,19 @@ def predict(self, X, sample_weight=None): X_new.std_err_ = getattr(X_new, "std_err_", self.X_.std_err_) X_new.average_ = getattr(X_new, "average_", self.X_.average_) X_new.w_ = getattr(X_new, "w_", self.X_.w_) - X_new._full_triangle_ = X_new.full_triangle_ - X_new.parameter_risk_ = self._mack_recursion("parameter_risk_", X_new) - X_new.process_risk_ = self._mack_recursion("process_risk_", X_new) + # The Mack recursion multiplies cumulative amounts, so the risk + # estimates use a cumulative copy of X_new. + X_cum = X_new.incr_to_cum() + X_cum._full_triangle_ = X_cum.full_triangle_ + X_new.parameter_risk_ = self._mack_recursion("parameter_risk_", X_cum) + X_new.process_risk_ = self._mack_recursion("process_risk_", X_cum) X_new.total_process_risk_ = (X_new.process_risk_**2).sum(axis="origin").sqrt() X_new.total_parameter_risk_ = self._mack_recursion( - "total_parameter_risk_", X_new + "total_parameter_risk_", X_cum ) - X_new.full_std_err_ = self._get_full_std_err_(X_new) + X_new.full_std_err_ = self._get_full_std_err_(X_cum) X_new.total_mack_std_err_ = self._get_total_mack_std_err_(X_new) X_new.mack_std_err_ = (X_new.parameter_risk_**2 + X_new.process_risk_**2).sqrt() - del X_new._full_triangle_ return X_new @property @@ -288,7 +294,12 @@ def full_std_err_(self): 2012 0.039675 0.034017 0.026776 0.008976 0.001243 0.001324 0.0 2013 0.035752 0.030671 0.024143 0.008094 0.001121 0.001193 0.0 """ - return self._get_full_std_err_(self.X_) + from chainladder.core.common import _get_full_triangle + + # The weights use cumulative amounts. + X = self.X_.incr_to_cum() + X._full_triangle_ = _get_full_triangle(X, self.ultimate_) + return self._get_full_std_err_(X) def _get_full_std_err_(self, X=None): from chainladder.utils.utility_functions import num_to_nan @@ -296,7 +307,8 @@ def _get_full_std_err_(self, X=None): obj = X.copy() xp = obj.get_array_module() lxp = X.ldf_.get_array_module() - full = getattr(X, "_full_triangle_", self.full_triangle_) + # fit, predict and full_std_err_ cache the full triangle on X first. + full = X._full_triangle_ avg = {"regression": 0, "volume": 1, "simple": 2} avg = [avg.get(item, item) for item in X.average_] val = xp.broadcast_to(xp.array(avg + [avg[-1]]), X.shape) @@ -704,7 +716,7 @@ def summary_(self): backend = obj.array_backend # forcing these four triangles to the same backend cols = ( - self.X_.latest_diagonal.set_backend(backend).values, + self.latest_diagonal.set_backend(backend).values, self.ibnr_.set_backend(backend).values, self.ultimate_.set_backend(backend).values, self.mack_std_err_.set_backend(backend).values[..., -1:], diff --git a/chainladder/methods/tests/test_mack.py b/chainladder/methods/tests/test_mack.py index e9ada0036..f87679e9f 100644 --- a/chainladder/methods/tests/test_mack.py +++ b/chainladder/methods/tests/test_mack.py @@ -122,6 +122,51 @@ def test_mack1999_hardcode(): assert np.allclose(ibnr_se, np.nan_to_num(ibnr_rhs, nan=0), atol=1, equal_nan=True) +def _assert_incremental_matches_cumulative(cum): + """An incremental triangle gives the same Mack estimates as its cumulative form.""" + attrs = [ + "parameter_risk_", + "process_risk_", + "total_parameter_risk_", + "total_process_risk_", + "mack_std_err_", + "full_std_err_", + ] + incr = cum.cum_to_incr() + model_cum = cl.MackChainladder().fit(cum) + model_incr = cl.MackChainladder().fit(incr) + assert not model_incr.X_.is_cumulative + pairs = [ + (model_cum, model_incr), + (model_cum.predict(cum), model_cum.predict(incr)), + ] + for a, b in pairs: + for attr in attrs: + assert np.allclose( + getattr(a, attr).set_backend("numpy").values, + getattr(b, attr).set_backend("numpy").values, + equal_nan=True, + ), attr + assert np.allclose(a.total_mack_std_err_.values, b.total_mack_std_err_.values) + assert np.allclose( + model_cum.summary_.set_backend("numpy").values, + model_incr.summary_.set_backend("numpy").values, + equal_nan=True, + ) + + +def test_mack_incremental_matches_cumulative_raa(raa): + _assert_incremental_matches_cumulative(raa) + + +def test_mack_incremental_matches_cumulative_mw2008(mw2008): + _assert_incremental_matches_cumulative(mw2008) + + +def test_mack_incremental_matches_cumulative_genins(genins): + _assert_incremental_matches_cumulative(genins) + + def test_mack1994_hardcode(raa): """ Reconciles key MackChainladder statistics to values provided in the paper