diff --git a/chainladder/tails/bondy.py b/chainladder/tails/bondy.py index 5c1072d88..9c97fefa3 100644 --- a/chainladder/tails/bondy.py +++ b/chainladder/tails/bondy.py @@ -162,7 +162,7 @@ def fit(self, X, y=None, sample_weight=None): b_optimized = [] initial = xp.where(obj.ddims == earliest_age)[0][0] if earliest_age else 0 for num in range(len(obj.columns)): - b0 = (xp.ones(obj.shape[0]) * 0.5)[:, None] + b0 = (xp.ones(obj.ldf_.shape[0]) * 0.5)[:, None] data = xp.log(obj.ldf_.values[:, num, 0, initial:]) b0 = xp.concatenate((b0, data[..., 0:1]), axis=1) b_optimized.append( @@ -191,7 +191,7 @@ def fit(self, X, y=None, sample_weight=None): (fitted, fitted[..., -1:] ** (self.b_ / (1 - self.b_))), axis=-1 ) fitted = xp.repeat(fitted, self.ldf_.shape[2], axis=2) - rows = X.index.set_index(X.key_labels).index + rows = self.ldf_.index.set_index(self.ldf_.key_labels).index self.b_ = pd.DataFrame( self.b_[..., 0, 0], index=rows, columns=X.columns.to_list() ) diff --git a/chainladder/tails/tests/test_bondy.py b/chainladder/tails/tests/test_bondy.py index b14239787..9f981f39e 100644 --- a/chainladder/tails/tests/test_bondy.py +++ b/chainladder/tails/tests/test_bondy.py @@ -1,6 +1,7 @@ from __future__ import annotations import chainladder as cl +import numpy as np from typing import TYPE_CHECKING @@ -15,3 +16,33 @@ def test_bondy1(tail_sample: Triangle) -> None: round(float(cl.TailBondy(earliest_age=12).fit(dev).cdf_.values[0, 0, 0, -2]), 3) == 1.028 ) + + +def test_bondy_fits_grouped_development_pattern(clrd: Triangle) -> None: + """ + ``TailBondy`` fits a pattern from ``Development(groupby=...)``. + + The grouped pattern has one row per line while the triangle keeps one row + per company, so ``TailBondy`` sizes its starting values and labels ``b_`` + from ``ldf_``. The result matches summing by line before the fit. See + #1599. + + Parameters + ---------- + clrd: Triangle + The clrd sample data set. + + Returns + ------- + None + """ + triangle = clrd["CumPaidLoss"] + grouped = cl.TailBondy().fit(cl.Development(groupby="LOB").fit_transform(triangle)) + summed = cl.TailBondy().fit( + cl.Development().fit_transform(triangle.groupby("LOB").sum()) + ) + + assert grouped.ldf_.shape == summed.ldf_.shape + assert list(grouped.b_.index) == list(summed.b_.index) + assert np.allclose(grouped.b_.values, summed.b_.values, equal_nan=True) + assert np.allclose(grouped.ldf_.values, summed.ldf_.values, equal_nan=True)