From d5eb8e06c658f2499f5956c92edfd7b04c044e3c Mon Sep 17 00:00:00 2001 From: cheerfulnut <91607869+cheerfulnut@users.noreply.github.com> Date: Sun, 20 Sep 2026 11:26:01 +0900 Subject: [PATCH 1/2] Upgrade to .NET 10 (LTS) .NET 8 reaches end of support on 2026-11-10. .NET 10 is the current LTS release, supported until November 2028. - global.json: SDK 8.0 -> 10.0 - All five projects: net8.0 / net8.0-windows -> net10.0 / net10.0-windows - README: update the required Desktop Runtime and its download link No code or dependency changes. The CI workflows need no edits because they already resolve the SDK via global-json-file. Co-Authored-By: Claude Opus 5 --- README.md | 6 +++--- .../SOTFEdit.Companion.Shared.Tests.csproj | 2 +- SOTFEdit.Companion.Shared/SOTFEdit.Companion.Shared.csproj | 2 +- SOTFEdit.Tests/SOTFEdit.Tests.csproj | 2 +- SOTFEdit/SOTFEdit.csproj | 2 +- ZoomControl/ZoomControl.csproj | 2 +- global.json | 2 +- 7 files changed, 9 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index dbda425..4ce97f8 100644 --- a/README.md +++ b/README.md @@ -75,7 +75,7 @@ nothing more, nothing less. ## Requirements - Windows 8+ -- [.net 8.0 Desktop Runtime](https://dotnet.microsoft.com/en-us/download/dotnet/8.0) +- [.net 10.0 Desktop Runtime](https://dotnet.microsoft.com/en-us/download/dotnet/10.0) ## Usage @@ -252,7 +252,7 @@ I can not change "IsRobbyDead" or "IsVirginiaDead" The program does not start -- Make sure that .net 8.0 Desktop Runtime is installed. Also make sure to extract all files from the archive if you +- Make sure that .net 10.0 Desktop Runtime is installed. Also make sure to extract all files from the archive if you downloaded the zip archive manually. Lastly, check if any antivirus is blocking the editor Antivirus (Windows Defender for example, Smartscreen) is complaining @@ -262,7 +262,7 @@ Antivirus (Windows Defender for example, Smartscreen) is complaining "Could not load file or assembly" -- Make sure to have .net 8.0 Desktop Runtime installed (either x86 or x64) +- Make sure to have .net 10.0 Desktop Runtime installed (either x86 or x64) My changes are not applied or reverted diff --git a/SOTFEdit.Companion.Shared.Tests/SOTFEdit.Companion.Shared.Tests.csproj b/SOTFEdit.Companion.Shared.Tests/SOTFEdit.Companion.Shared.Tests.csproj index 631443b..d73c77e 100644 --- a/SOTFEdit.Companion.Shared.Tests/SOTFEdit.Companion.Shared.Tests.csproj +++ b/SOTFEdit.Companion.Shared.Tests/SOTFEdit.Companion.Shared.Tests.csproj @@ -3,7 +3,7 @@ enable enable - net8.0 + net10.0 diff --git a/SOTFEdit.Companion.Shared/SOTFEdit.Companion.Shared.csproj b/SOTFEdit.Companion.Shared/SOTFEdit.Companion.Shared.csproj index 4b61737..72bf041 100644 --- a/SOTFEdit.Companion.Shared/SOTFEdit.Companion.Shared.csproj +++ b/SOTFEdit.Companion.Shared/SOTFEdit.Companion.Shared.csproj @@ -3,7 +3,7 @@ enable enable - net8.0 + net10.0 Release;Debug AnyCPU NU1701;CS8618 diff --git a/SOTFEdit.Tests/SOTFEdit.Tests.csproj b/SOTFEdit.Tests/SOTFEdit.Tests.csproj index 1a35be4..03cbe79 100644 --- a/SOTFEdit.Tests/SOTFEdit.Tests.csproj +++ b/SOTFEdit.Tests/SOTFEdit.Tests.csproj @@ -4,7 +4,7 @@ enable false enable - net8.0-windows + net10.0-windows diff --git a/SOTFEdit/SOTFEdit.csproj b/SOTFEdit/SOTFEdit.csproj index 89047cb..ee64efd 100644 --- a/SOTFEdit/SOTFEdit.csproj +++ b/SOTFEdit/SOTFEdit.csproj @@ -2,7 +2,7 @@ WinExe - net8.0-windows + net10.0-windows enable true False diff --git a/ZoomControl/ZoomControl.csproj b/ZoomControl/ZoomControl.csproj index cdfaa7d..36834e6 100644 --- a/ZoomControl/ZoomControl.csproj +++ b/ZoomControl/ZoomControl.csproj @@ -1,7 +1,7 @@  - net8.0-windows + net10.0-windows enable true diff --git a/global.json b/global.json index b33c905..e78829f 100644 --- a/global.json +++ b/global.json @@ -1,6 +1,6 @@ { "sdk": { - "version": "8.0", + "version": "10.0", "rollForward": "latestMinor", "allowPrerelease": false } From 257fce746b50cf3393db6581034febcc7650b181 Mon Sep 17 00:00:00 2001 From: cheerfulnut <91607869+cheerfulnut@users.noreply.github.com> Date: Sun, 20 Sep 2026 12:35:12 +0900 Subject: [PATCH 2/2] Use a full SDK version in global.json actions/setup-dotnet rejects a two-part version when rollForward is specified: "When 'rollForward' is specified, a full SDK version is required." This also affects the existing "8.0" value on master, so CI fails there too. setup-dotnet@v5 is a moving tag and has tightened this validation since the last push to master in December 2025. rollForward is left as latestMinor, so any 10.0.x SDK still satisfies it. Co-Authored-By: Claude Opus 5 --- global.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/global.json b/global.json index e78829f..e563601 100644 --- a/global.json +++ b/global.json @@ -1,6 +1,6 @@ { "sdk": { - "version": "10.0", + "version": "10.0.100", "rollForward": "latestMinor", "allowPrerelease": false }