From 4a64fbbcb4aaa18d0ed96dfff42d44a856bf56ef Mon Sep 17 00:00:00 2001
From: Nguyen Thanh Dat <ntdat812@gmail.com>
Date: Wed, 12 Aug 2026 14:40:52 +0700
Subject: [PATCH] Retarget test project to net8.0 so the suite runs on current
 SDKs

netcoreapp3.1 went out of support in December 2022 and no shipping SDK can
run it, so that leg of the test matrix aborted before executing anything.
On non-Windows machines that left no runnable tests at all.

Moves the framework leg to net462, the lowest supported .NET Framework and
the floor required by xunit.runner.visualstudio 2.8.2. The library still
targets net461 and the net462 test assembly binds that same output, so
coverage is unchanged.

Also keys PLATFORM_DOTNET off "not .NET Framework" rather than the
netcoreapp prefix, which would otherwise stop being defined.

684 tests pass on both net462 and net8.0. No test code or library
targets were changed.
---
 tests/CommandLine.Tests/CommandLine.Tests.csproj | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/CommandLine.Tests/CommandLine.Tests.csproj b/tests/CommandLine.Tests/CommandLine.Tests.csproj
index d4dbcab0..c7dbffdc 100644
--- a/tests/CommandLine.Tests/CommandLine.Tests.csproj
+++ b/tests/CommandLine.Tests/CommandLine.Tests.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Library</OutputType>
-    <TargetFrameworks>net461;netcoreapp3.1</TargetFrameworks>
+    <TargetFrameworks>net462;net8.0</TargetFrameworks>
     <DefineConstants Condition="'$(BuildTarget)' != 'fsharp'">$(DefineConstants);SKIP_FSHARP</DefineConstants>
     <AssemblyOriginatorKeyFile>..\..\CommandLine.snk</AssemblyOriginatorKeyFile>
     <SignAssembly>true</SignAssembly>
@@ -17,7 +17,7 @@
     <Compile Remove="Fakes\Options_With_FSharpOption.cs" />
     <Compile Remove="Unit\Infrastructure\FSharpOptionHelperTests.cs" />
   </ItemGroup>
-  <PropertyGroup Condition="$(TargetFramework.StartsWith('netcoreapp'))">
+  <PropertyGroup Condition="!$(TargetFramework.StartsWith('net4'))">
     <DefineConstants>$(DefineConstants);PLATFORM_DOTNET</DefineConstants>
   </PropertyGroup>
   <ItemGroup>
@@ -28,9 +28,9 @@
     <PackageReference Include="FluentAssertions" Version="5.4.1" />
     <PackageReference Include="FsCheck" Version="2.11.0" />
     <PackageReference Include="FSharp.Core" Version="4.5.1" Condition="'$(BuildTarget)' == 'fsharp'" />
-    <PackageReference Include="xunit" Version="2.4.1" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.0.1" />
+    <PackageReference Include="xunit" Version="2.9.2" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.8.2" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
 
   </ItemGroup>