Skip to content

Quality mode SMOOTH cannot be set for small images #37

Description

@ilonachan

Shadow's default behavior, unless the user specifies otherwise, is to upscale image components smoothly. However if the image is very small (<=256 pixels in any dimension) this behavior is overridden. While a good idea in principle, the way this is implemented means it's impossible for the user to manually set smooth upscaling for those images, the argument would be silently ignored. For what reason they might want to do this is not for me to decide, it's a limitation either way.

The proper way to decide between complex default behaviors vs explicit user choice is to have a marker setting for the default. This could just mean a new entry DEFAULT in the QualityMode enum (or simply None), and at the usage site, for this to be handled the same as SMOOTH unless the image is small. Any explicitly user-specified selection would be used as-is.

Super low priority though, obviously.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions