From 107ce7b71258952aa216d44132b8637e10d6ed93 Mon Sep 17 00:00:00 2001 From: dayfine Date: Sat, 14 Nov 2026 15:17:51 -0800 Subject: [PATCH 1/2] Game languages: say why FRLG lists six languages and Gen 8-9 one Spanish Answers the #312 review: the Switch FireRed/LeafGreen are the GBA releases reissued, one version per language with no in-game option, so all six languages stay (as in upstream's FRLG programs). Gen 8-9 games have one Spanish, so one "es". Code that reads text takes the language option. --- .../Pokemon/Options/Pokemon_GameLanguages.h | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/SerialPrograms/Source/Pokemon/Options/Pokemon_GameLanguages.h b/SerialPrograms/Source/Pokemon/Options/Pokemon_GameLanguages.h index eec094dfaf..b2f53a0839 100644 --- a/SerialPrograms/Source/Pokemon/Options/Pokemon_GameLanguages.h +++ b/SerialPrograms/Source/Pokemon/Options/Pokemon_GameLanguages.h @@ -4,7 +4,10 @@ * * The languages each game can be played in, as dropdown databases for a * program's language option. A program offers its game's set, so a user - * can't pick a language the game doesn't have. + * can't pick a language the game doesn't have. Every language a game ships + * in is listed, tested on console or not: code that needs the language + * (reading text) takes this option, never assumes one, and says so where + * it has no reader for a language. * */ @@ -21,11 +24,16 @@ namespace Pokemon{ // The nine languages of the Switch games of generations 8 and 9: Sword and // Shield, Brilliant Diamond and Shining Pearl, Legends: Arceus, Scarlet and // Violet, Legends: Z-A. Japanese, English, French, Italian, German, -// Spanish, Korean, Chinese (Simplified and Traditional). +// Spanish, Korean, Chinese (Simplified and Traditional). The games have one +// Spanish (Spain), hence one "es". const EnumDropdownDatabase& Gen8ToGen9Languages_Database(); -// The six languages of FireRed and LeafGreen: Japanese, English, French, -// Italian, German, Spanish. +// The six languages of FireRed and LeafGreen, the Game Boy Advance +// releases the Switch versions reissue: Japanese, English, French, Italian, +// German, Spanish. On Switch each language is a separate version with no +// in-game language option (Nintendo of America sells English, French and +// Spanish, the latter two in their European form), so the user picks the +// version they own. The same six as upstream's FRLG programs. const EnumDropdownDatabase& FireRedLeafGreenLanguages_Database(); From fe8fe0c53d60664a6b3968eab66eadaaa9ec4235 Mon Sep 17 00:00:00 2001 From: dayfine Date: Sat, 14 Nov 2026 15:46:24 -0800 Subject: [PATCH 2/2] Game languages: say what a missing reader gives; drop the upstream mention --- .../Source/Pokemon/Options/Pokemon_GameLanguages.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/SerialPrograms/Source/Pokemon/Options/Pokemon_GameLanguages.h b/SerialPrograms/Source/Pokemon/Options/Pokemon_GameLanguages.h index b2f53a0839..003767c870 100644 --- a/SerialPrograms/Source/Pokemon/Options/Pokemon_GameLanguages.h +++ b/SerialPrograms/Source/Pokemon/Options/Pokemon_GameLanguages.h @@ -5,9 +5,11 @@ * The languages each game can be played in, as dropdown databases for a * program's language option. A program offers its game's set, so a user * can't pick a language the game doesn't have. Every language a game ships - * in is listed, tested on console or not: code that needs the language - * (reading text) takes this option, never assumes one, and says so where - * it has no reader for a language. + * in is listed, tested on console or not. Code that reads text takes this + * option and never assumes a language. With no reader for the chosen + * language, a name lookup throws InternalProgramError ("No data loaded for + * this language.") and a story step falls back to positions, digits and the + * screen. * */ @@ -33,7 +35,7 @@ const EnumDropdownDatabase& Gen8ToGen9Languages_Database(); // German, Spanish. On Switch each language is a separate version with no // in-game language option (Nintendo of America sells English, French and // Spanish, the latter two in their European form), so the user picks the -// version they own. The same six as upstream's FRLG programs. +// version they own. const EnumDropdownDatabase& FireRedLeafGreenLanguages_Database();