Skip to content

Queries with no results return a null array #283

Description

@sudo-gab

Hello!

This library allows you to query via StatementBuilder. When you run a query that returns no results, the XYPage#getResults() returns null. On my side, this has only been confirmed to be true with InventoryServiceInterface#getAdUnitsByStatement(), however it would be right to assume it is true for other query implementations as well.

Returning null arrays is an anti-pattern. Can this be fixed to return empty arrays instead? This has already been mentioned in #214.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions