From 7b9b4a44ec806e7ebfa032760d555cea4bf05bc5 Mon Sep 17 00:00:00 2001 From: Iko Date: Sat, 12 Sep 2026 20:05:51 +0700 Subject: [PATCH 1/3] fix(builder): correct PR template test command, alerts, branch scopes - Test command ran 'python -m pytest -q -k "not adapter"', silently skipping 21 adapter tests including the SSE wire-contract test; use the canonical 'python3 -m pytest tests/ -q' (integration tests self-skip without hermes-agent). - Bare [!IMPORTANT]/[!WARNING] markers render as literal text; use the blockquote alert form so GitHub renders the callouts. - Branch prefixes contradicted the AGENTS.md scopes (bugs/, feature/ are not scopes; feat/ was missing); align to feat/fix/sec/refactor/ test/docs/chore. --- .github/pull_request_template.md | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 10d88df..e3ed4ca 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -14,24 +14,26 @@ Briefly describe the change and why it is needed. ## Branch -This PR was opened from a branch using one of: +This PR was opened from a branch using one of (matching a Conventional +Commits-lite scope in `AGENTS.md`): +- `feat/…` - `fix/…` -- `bugs/…` -- `feature/…` -- `chore/…` -- `docs/…` -- `test/…` -- `refactor/…` - `sec/…` +- `refactor/…` +- `test/…` +- `docs/…` +- `chore/…` -[!IMPORTANT] Branch must use the Conventional Commits-lite prefix matching the PR scope. +> [!IMPORTANT] +> Branch prefix must match the PR's scope. ## Checklist -- [ ] Tests pass: `python -m pytest -q -k "not adapter"` +- [ ] Tests pass: `python3 -m pytest tests/ -q` - [ ] `verify.py` is green - [ ] No raw tokens/secrets in code, logs, or tool output - [ ] Adapter stays loopback-only unless an explicit guard is added - [ ] Updated docs/README if user-facing behavior changed -[!WARNING] Do NOT merge if `verify.py` reports a secret leak. This is a hard gate. +> [!WARNING] +> Do NOT merge if `verify.py` reports a secret leak. This is a hard gate. From 4ec5f97a23e447fb48a1eac57910443c30abc2e6 Mon Sep 17 00:00:00 2001 From: Iko Date: Sat, 12 Sep 2026 20:16:13 +0700 Subject: [PATCH 2/3] fix(builder): map feat/ and docs/ branch prefixes to labels MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The PR template documents feat/ branches, but the auto-label workflow only knew fix/bugs/feature — feat/ PRs got no label. Add feat/ (plus docs/ -> documentation); keep feature/ and bugs/ as tolerated aliases. All target labels exist, so addLabels cannot 422. --- .github/workflows/pr-label.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr-label.yml b/.github/workflows/pr-label.yml index c207da3..29ab0ca 100644 --- a/.github/workflows/pr-label.yml +++ b/.github/workflows/pr-label.yml @@ -18,7 +18,9 @@ jobs: const labels = { 'fix/': 'bug', 'bugs/': 'bug', - 'feature/': 'enhancement' + 'feat/': 'enhancement', + 'feature/': 'enhancement', + 'docs/': 'documentation' } const mapping = Object.entries(labels).find(([prefix]) => branch.startsWith(prefix)) if (!mapping) return From 06503364fc154d4dd5bbb6df9f388380760b1be3 Mon Sep 17 00:00:00 2001 From: Iko Date: Sat, 12 Sep 2026 20:22:54 +0700 Subject: [PATCH 3/3] docs: template references Conventional Commits types, not scopes --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index e3ed4ca..65ac7ec 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -15,7 +15,7 @@ Briefly describe the change and why it is needed. ## Branch This PR was opened from a branch using one of (matching a Conventional -Commits-lite scope in `AGENTS.md`): +Commits type in `AGENTS.md`): - `feat/…` - `fix/…` - `sec/…`