From 59645d3f05eaae967dc60f8b88c301dcc0862d3b Mon Sep 17 00:00:00 2001 From: jake1025 Date: Fri, 31 Jul 2026 15:58:31 -0400 Subject: [PATCH] Stop hardcoding a real-world system ID in test_services.py 'ABU' (ADCB Bikeshare) was asserted as a known-good system ID, but that kind of magic string goes stale whenever upstream systems.csv changes - same class of bug as #8. Assert against whatever the first row's system ID actually is instead, so the test stays valid regardless of upstream churn (including the automated refreshes from #14). Co-Authored-By: Claude Sonnet 5 --- gbfs/tests/test_services.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gbfs/tests/test_services.py b/gbfs/tests/test_services.py index be59cd1..a9d0e5f 100644 --- a/gbfs/tests/test_services.py +++ b/gbfs/tests/test_services.py @@ -15,6 +15,7 @@ def test_system_discovery_service(): assert ds.systems assert ds.system_ids assert len(ds.systems) == len(ds.system_ids) - assert ds.get_system_by_id('ABU') + first_id = next(iter(ds.system_ids)) + assert ds.get_system_by_id(first_id) assert ds._instantiate_client(os.path.join(package_tests_fixtures_dirpath, 'gbfs.json'), 'en', json_fetcher=LocalJSONFetcher())