From 32e81d482654c25a121af78da3db9a5e2a67e75a Mon Sep 17 00:00:00 2001 From: Kristof Lemmens Date: Tue, 17 Nov 2026 08:48:33 +0100 Subject: [PATCH] ci: run release-please from the shared reusable workflow The release-please job now calls release-please.yml of klconsultancy/workflows (pinned to main), with the same GitHub App credentials. The npm publish job stays in release.yml, where the trusted publisher expects it. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/release.yml | 31 +++++++++++-------------------- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 0027913..b9eb197 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -13,28 +13,19 @@ permissions: contents: read jobs: + # release-please as the klconsultancy release GitHub App (its token, not GITHUB_TOKEN, + # so the release PR it opens triggers CI), from the shared reusable workflow. The App and + # its credentials live at the klconsultancy organization level. release-please: - runs-on: ubuntu-latest - permissions: - contents: write - pull-requests: write - outputs: - release_created: ${{ steps.release.outputs.release_created }} - tag_name: ${{ steps.release.outputs.tag_name }} - steps: - # A GitHub App token instead of GITHUB_TOKEN, so the release PR it opens - # triggers CI (events from GITHUB_TOKEN start no new workflow runs). The App - # and its credentials live at the klconsultancy organization level. - - uses: actions/create-github-app-token@v3 - id: app-token - with: - client-id: ${{ vars.RELEASE_APP_CLIENT_ID }} - private-key: ${{ secrets.RELEASE_APP_PRIVATE_KEY }} - - uses: googleapis/release-please-action@v5 - id: release - with: - token: ${{ steps.app-token.outputs.token }} + permissions: {} # it acts as the app + uses: klconsultancy/workflows/.github/workflows/release-please.yml@c9502596494c47704b890d5cc66de73c06ba93d8 # main + with: + app-client-id: ${{ vars.RELEASE_APP_CLIENT_ID }} + secrets: + RELEASE_APP_PRIVATE_KEY: ${{ secrets.RELEASE_APP_PRIVATE_KEY }} + # Stays here, not in the reusable workflow: npm's trusted publisher is bound to this + # workflow file (release.yml) and the `npm` environment. publish: needs: release-please if: needs.release-please.outputs.release_created == 'true'