Skip to content

Commit 4fd4ace

Browse files
committed
fix(play): the site's player box, single padding, the status announced, the README row whole (#86)
1 parent 4f90749 commit 4fd4ace

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ The site of the [missing-elements](https://github.com/missing-elements) web comp
99
| `/` | The project list, the tools (the build page first, with its how-to), and a footer of links | [src/index.njk](src/index.njk); the lists are in [src/_data/site.js](src/_data/site.js) |
1010
| `/pdfjs-viewer/` | The docs of `<pdfjs-viewer-element>`, with a live preview | [src/pdfjs-viewer/](src/pdfjs-viewer/) |
1111
| `/h5p/build/` | The build page, for people: what it makes, a sample that plays, and the build of a chat's source into a `.h5p`, in the visitor's browser | [src/h5p/build/](src/h5p/build/) |
12-
| `/h5p/play/` | The play page: the activity in a link's `#source=`, built in the visitor's browser as the build page builds it, and played with nothing else beside it but its download, for a chat app to show in its reply (h5p-toolkit#210); no page links to it | [src/h5p/play/](src/h5p/play/) |
12+
| `/h5p/play/` | The play page: the activity in a link's `#source=`, built in the visitor's browser as the build page builds it, and played with nothing beside it but its download and a link to the build page, for a chat app to show in its reply (h5p-toolkit#210); no page links to it | [src/h5p/play/](src/h5p/play/) |
1313
| `/h5p/create-with-ai/` | The how-to, for people: installing the skill, asking a chat, the prompts to start from, the types, and what to do when something goes wrong | [src/h5p/create-with-ai/](src/h5p/create-with-ai/) |
1414
| `/h5p/skill/` | The skill as zips to install: `h5p-author.zip`, installed once in a chat's place for skills, or attached to the message in each new chat where it has none, and `h5p-author-chatgpt.zip`, the same skill laid out as a plugin; and a page that lists them and the bundles' addresses, each in full, which no page links to | [src/h5p/skill/](src/h5p/skill/); the zips written by [vite.config.ts](vite.config.ts) |
1515
| `/h5p/bundles/` | The skill's build tool and a library bundle per content type, for a chat that runs Node but cannot reach npm; and `h5p-author-build.tar.gz`, the tool and every library in one archive, for a person to attach to a chat whose code can download nothing | written by [vite.config.ts](vite.config.ts) |

‎src/assets/site.css‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1089,6 +1089,7 @@ pre.prompt { white-space: pre-wrap; overflow-wrap: anywhere; font-size: 0.9375re
10891089

10901090
/* The play page, /h5p/play/: the activity alone, for a chat app's frame. */
10911091
.play { padding: 0.5rem; }
1092+
.play .player-box { margin: 0; }
10921093
.play-status { margin: 0 0 0.5rem; color: var(--muted); font-size: 0.9rem; }
10931094
.play-status[data-state="error"] { color: inherit; font-weight: 600; }
10941095
.play-status[data-state="ready"] { display: none; }

‎src/h5p/play/index.njk‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
layout: base.njk
33
title: "Play an H5P activity"
44
description: "An H5P activity an AI chat wrote, built and played in your browser, with its .h5p file to download. Nothing is sent to a server."
5-
bodyClass: play
65
# Not a page to land on from a search: it is opened with an activity's source in its link.
76
eleventyExcludeFromCollections: true
87
# As the build page's policy: packages it built play in the player's frame, under the policy the
@@ -12,8 +11,8 @@ csp: "default-src 'self'; script-src 'self'; style-src 'self'; img-src 'self' da
1211
{#- The player alone, for an activity's source in the link (#source=, as the build page takes it),
1312
so that a chat app can show the activity in its reply: play-page.ts builds it and plays it. -#}
1413
<main class="play" id="main">
15-
<p class="play-status" id="status" data-state="building">Building the activity in your browser…</p>
16-
<div class="play-box">
14+
<p class="play-status" id="status" role="status" data-state="building">Building the activity in your browser…</p>
15+
<div class="player-box">
1716
<h5p-player id="player"></h5p-player>
1817
</div>
1918
<p class="play-actions">

0 commit comments

Comments
 (0)