From 551eeb64f7ee8105bcdd01cfe654fcbfe977e61d Mon Sep 17 00:00:00 2001 From: Kyungrae Kang <148605113+kyungrae2002@users.noreply.github.com> Date: Mon, 7 Sep 2026 19:25:14 +0900 Subject: [PATCH] sqlite: use cached strings for property keys Signed-off-by: Kyungrae Kang --- src/node_sqlite.cc | 24 ++++++------------------ 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/src/node_sqlite.cc b/src/node_sqlite.cc index f52f7e4f9b9c..d94093d02754 100644 --- a/src/node_sqlite.cc +++ b/src/node_sqlite.cc @@ -1653,9 +1653,7 @@ void DatabaseSync::Prepare(const FunctionCallbackInfo& args) { Local options = args[1].As(); Local return_arrays_v; - if (!options - ->Get(env->context(), - FIXED_ONE_BYTE_STRING(env->isolate(), "returnArrays")) + if (!options->Get(env->context(), env->return_arrays_string()) .ToLocal(&return_arrays_v)) { return; } @@ -1670,9 +1668,7 @@ void DatabaseSync::Prepare(const FunctionCallbackInfo& args) { } Local read_big_ints_v; - if (!options - ->Get(env->context(), - FIXED_ONE_BYTE_STRING(env->isolate(), "readBigInts")) + if (!options->Get(env->context(), env->read_bigints_string()) .ToLocal(&read_big_ints_v)) { return; } @@ -1687,10 +1683,7 @@ void DatabaseSync::Prepare(const FunctionCallbackInfo& args) { } Local allow_bare_named_params_v; - if (!options - ->Get(env->context(), - FIXED_ONE_BYTE_STRING(env->isolate(), - "allowBareNamedParameters")) + if (!options->Get(env->context(), env->allow_bare_named_params_string()) .ToLocal(&allow_bare_named_params_v)) { return; } @@ -1706,10 +1699,7 @@ void DatabaseSync::Prepare(const FunctionCallbackInfo& args) { } Local allow_unknown_named_params_v; - if (!options - ->Get(env->context(), - FIXED_ONE_BYTE_STRING(env->isolate(), - "allowUnknownNamedParameters")) + if (!options->Get(env->context(), env->allow_unknown_named_params_string()) .ToLocal(&allow_unknown_named_params_v)) { return; } @@ -4603,10 +4593,8 @@ static void Initialize(Local target, db_tmpl, FIXED_ONE_BYTE_STRING(isolate, "isTransaction"), DatabaseSync::IsTransactionGetter); - SetSideEffectFreeGetter(isolate, - db_tmpl, - FIXED_ONE_BYTE_STRING(isolate, "limits"), - DatabaseSync::LimitsGetter); + SetSideEffectFreeGetter( + isolate, db_tmpl, env->limits_string(), DatabaseSync::LimitsGetter); Local sqlite_type_key = FIXED_ONE_BYTE_STRING(isolate, "sqlite-type"); Local sqlite_type_symbol = v8::Symbol::For(isolate, sqlite_type_key);