From b82a951c6b034454b2689c7c727cd25d5235291b Mon Sep 17 00:00:00 2001
From: Yegor Bugayenko <yegor256@gmail.com>
Date: Fri, 2 Oct 2026 15:11:29 +0300
Subject: [PATCH] fix(#1526): skip cactus-named attributes in
 excessive-visibility

A private constant written with "!" carries its local name two levels
below the attribute, so the "not(@local)" guard missed it and the lint
asked to obfuscate an attribute that was already obfuscated. The rule
now skips every attribute whose name holds the cactus, the same guard
unoptimizable-recursion uses.
---
 .../eolang/lints/design/excessive-visibility.xsl   |  2 +-
 .../allows-already-private-constant.yaml           | 14 ++++++++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)
 create mode 100644 src/test/resources/org/eolang/lints/packs/single/excessive-visibility/allows-already-private-constant.yaml

diff --git a/src/main/resources/org/eolang/lints/design/excessive-visibility.xsl b/src/main/resources/org/eolang/lints/design/excessive-visibility.xsl
index 59968b52b..05a76d898 100644
--- a/src/main/resources/org/eolang/lints/design/excessive-visibility.xsl
+++ b/src/main/resources/org/eolang/lints/design/excessive-visibility.xsl
@@ -23,7 +23,7 @@
           only hide a value other files may legitimately read.
           -->
           <xsl:variable name="literals" select="('Φ.number', 'Φ.string', 'Φ.bytes', 'Φ.true', 'Φ.false', 'Φ.tuple')"/>
-          <xsl:for-each select="o[@name and @base and @base != '∅' and not(@base = $literals) and @name != 'φ' and not(@local) and not(eo:test-name(@name))]">
+          <xsl:for-each select="o[@name and @base and @base != '∅' and not(@base = $literals) and @name != 'φ' and not(contains(@name, '🌵')) and not(eo:test-name(@name))]">
             <xsl:variable name="attr" select="@name"/>
             <!--
             A test refers to a sibling method either by calling it on
diff --git a/src/test/resources/org/eolang/lints/packs/single/excessive-visibility/allows-already-private-constant.yaml b/src/test/resources/org/eolang/lints/packs/single/excessive-visibility/allows-already-private-constant.yaml
new file mode 100644
index 000000000..b5f6f371f
--- /dev/null
+++ b/src/test/resources/org/eolang/lints/packs/single/excessive-visibility/allows-already-private-constant.yaml
@@ -0,0 +1,14 @@
+# SPDX-FileCopyrightText: Copyright (c) 2016-2026 Objectionary.com
+# SPDX-License-Identifier: MIT
+---
+sheets:
+  - /org/eolang/lints/design/excessive-visibility.xsl
+defects: 0
+input: |
+  [x] > app
+    y.times > @
+      x.plus 1 >> y!
+
+    eq. ++> can-square-the-successor
+      app 1
+      4