From 7c8c11ea2e4cf3505af444d2ab631df7ffb0f4bf Mon Sep 17 00:00:00 2001 From: Marcel Ebert Date: Mon, 14 Sep 2026 17:13:48 +0200 Subject: [PATCH 1/5] chore: Allow clippy::manual_inspect in orml-currencies-allowance-extension The lint (new in clippy 1.81) fires inside the #[pallet::pallet] macro expansion, which this crate does not control; under #![deny(warnings)] it has failed every clippy run since the toolchain bump. --- pallets/orml-currencies-allowance-extension/src/lib.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pallets/orml-currencies-allowance-extension/src/lib.rs b/pallets/orml-currencies-allowance-extension/src/lib.rs index 2b9de820a..7caa02057 100644 --- a/pallets/orml-currencies-allowance-extension/src/lib.rs +++ b/pallets/orml-currencies-allowance-extension/src/lib.rs @@ -1,4 +1,8 @@ #![deny(warnings)] +// `manual_inspect` (clippy 1.81) fires inside the `#[pallet::pallet]` macro +// expansion, which this crate does not control; with `deny(warnings)` that +// failed every CI run since the toolchain bump. +#![allow(clippy::manual_inspect)] #![cfg_attr(not(feature = "std"), no_std)] use frame_support::{dispatch::DispatchResult, ensure}; From 385204c7015d185f76a6d57c9d5b544e5853793b Mon Sep 17 00:00:00 2001 From: Marcel Ebert Date: Mon, 14 Sep 2026 17:13:48 +0200 Subject: [PATCH 2/5] ci: Ignore the archived substrate-docs link in the markdown link check GitHub rate-limits the checker on that blob URL (HTTP 429), failing the job on every PR for a link that is not dead. --- .github/workflows/mlc_config.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/mlc_config.json b/.github/workflows/mlc_config.json index 48bfb36da..ff97d9678 100644 --- a/.github/workflows/mlc_config.json +++ b/.github/workflows/mlc_config.json @@ -2,6 +2,9 @@ "ignorePatterns": [ { "pattern": "^https://crates.io" + }, + { + "pattern": "^https://github.com/substrate-developer-hub/substrate-docs/" } ] } From feb397b8f9b34926926cba7c82aacbada0876e49 Mon Sep 17 00:00:00 2001 From: Marcel Ebert Date: Tue, 15 Sep 2026 14:59:14 +0200 Subject: [PATCH 3/5] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- .github/workflows/mlc_config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/mlc_config.json b/.github/workflows/mlc_config.json index ff97d9678..2d224792c 100644 --- a/.github/workflows/mlc_config.json +++ b/.github/workflows/mlc_config.json @@ -4,7 +4,7 @@ "pattern": "^https://crates.io" }, { - "pattern": "^https://github.com/substrate-developer-hub/substrate-docs/" + "pattern": "^https://github.com/substrate-developer-hub/substrate-docs/blob/314e9cd3bd0ca9426bbfd381b79c3ef4d06b49c2/static/assets/tutorials/cumulus/chain-specs/rococo-custom-2-raw\\.json$" } ] } From 5095768da924107053613e7837ff5f60c1d356db Mon Sep 17 00:00:00 2001 From: Marcel Ebert Date: Wed, 16 Sep 2026 09:08:53 +0200 Subject: [PATCH 4/5] ci: Allow clippy::manual_inspect once, on the clippy command line `manual_inspect` (clippy 1.81) fires inside the `#[pallet::pallet]` expansion of our polkadot-sdk fork. Three pallets carry `deny(warnings)`, so allowing it per crate would need three copies; a CLI `-A` overrides the crate-level deny for all of them at once. Drops the per-crate allow again. --- .github/workflows/clippy-checks.yml | 4 +++- pallets/orml-currencies-allowance-extension/src/lib.rs | 4 ---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/clippy-checks.yml b/.github/workflows/clippy-checks.yml index 80f0b335e..e17d68e5f 100644 --- a/.github/workflows/clippy-checks.yml +++ b/.github/workflows/clippy-checks.yml @@ -20,7 +20,9 @@ jobs: uses: actions-rs/cargo@v1 with: command: clippy - args: --release --all-features -- -W clippy::all -A clippy::style -A forgetting_copy_types -A forgetting_references + # `manual_inspect` (clippy 1.81) fires inside the `#[pallet::pallet]` expansion of our + # polkadot-sdk fork; the `deny(warnings)` pallets cannot allow it from the outside. + args: --release --all-features -- -W clippy::all -A clippy::style -A clippy::manual_inspect -A forgetting_copy_types -A forgetting_references - name: Clippy -- All Targets (except integration) uses: actions-rs/cargo@v1 diff --git a/pallets/orml-currencies-allowance-extension/src/lib.rs b/pallets/orml-currencies-allowance-extension/src/lib.rs index 7caa02057..2b9de820a 100644 --- a/pallets/orml-currencies-allowance-extension/src/lib.rs +++ b/pallets/orml-currencies-allowance-extension/src/lib.rs @@ -1,8 +1,4 @@ #![deny(warnings)] -// `manual_inspect` (clippy 1.81) fires inside the `#[pallet::pallet]` macro -// expansion, which this crate does not control; with `deny(warnings)` that -// failed every CI run since the toolchain bump. -#![allow(clippy::manual_inspect)] #![cfg_attr(not(feature = "std"), no_std)] use frame_support::{dispatch::DispatchResult, ensure}; From 047d38fda99c633f445ba8155e3eb9c65e232cda Mon Sep 17 00:00:00 2001 From: Marcel Ebert Date: Wed, 16 Sep 2026 09:08:54 +0200 Subject: [PATCH 5/5] chore: Remove the dead `experimental` cfg from the runtimes No runtime declares an `experimental` feature, so the cfg-gated `SlotDuration` line was always compiled out. Rust 1.81's `unexpected_cfgs` now rejects it under `-Dwarnings`, which broke the test-code job. --- runtime/amplitude/src/lib.rs | 2 -- runtime/foucoco/src/lib.rs | 2 -- runtime/pendulum/src/lib.rs | 2 -- 3 files changed, 6 deletions(-) diff --git a/runtime/amplitude/src/lib.rs b/runtime/amplitude/src/lib.rs index 36da8f5b0..107f97840 100644 --- a/runtime/amplitude/src/lib.rs +++ b/runtime/amplitude/src/lib.rs @@ -606,8 +606,6 @@ impl pallet_aura::Config for Runtime { type DisabledValidators = (); type MaxAuthorities = MaxAuthorities; type AllowMultipleBlocksPerSlot = ConstBool; - #[cfg(feature = "experimental")] - type SlotDuration = ConstU64; } parameter_types! { diff --git a/runtime/foucoco/src/lib.rs b/runtime/foucoco/src/lib.rs index a5c9e5958..c776fe2aa 100644 --- a/runtime/foucoco/src/lib.rs +++ b/runtime/foucoco/src/lib.rs @@ -582,8 +582,6 @@ impl pallet_aura::Config for Runtime { type DisabledValidators = (); type MaxAuthorities = MaxAuthorities; type AllowMultipleBlocksPerSlot = ConstBool; - #[cfg(feature = "experimental")] - type SlotDuration = ConstU64; } parameter_types! { diff --git a/runtime/pendulum/src/lib.rs b/runtime/pendulum/src/lib.rs index e98cd0841..493a0b33e 100644 --- a/runtime/pendulum/src/lib.rs +++ b/runtime/pendulum/src/lib.rs @@ -611,8 +611,6 @@ impl pallet_aura::Config for Runtime { type DisabledValidators = (); type MaxAuthorities = MaxAuthorities; type AllowMultipleBlocksPerSlot = ConstBool; - #[cfg(feature = "experimental")] - type SlotDuration = ConstU64; } parameter_types! { pub const LaunchPeriod: BlockNumber = 5 * DAYS;