Skip to content

Commit 1276dde

Browse files
authored
Merge pull request #20 from pkgdiff-dev/gsd/quick-261027-contributing-flow
docs(contributing): issue-first flow with linked PRs and issue templates
2 parents c5ae986 + a034cfc commit 1276dde

6 files changed

Lines changed: 93 additions & 5 deletions

File tree

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
---
2+
name: Bug report
3+
about: A package whose release notes are wrong or missing, or anything else that misbehaves
4+
title: 'bug: '
5+
labels: bug
6+
---
7+
8+
<!-- Security problems do NOT go here — use SECURITY.md. -->
9+
10+
## What happened
11+
12+
<!-- What you saw, and what you expected instead. -->
13+
14+
## Where
15+
16+
- Registry: <!-- nuget / npm / pypi / pub.dev / maven / packagist -->
17+
- Package:
18+
- Versions compared: <!-- from -> to -->
19+
- URL (if any):
20+
21+
## Steps to reproduce
22+
23+
1.
24+
25+
## Notes
26+
27+
<!-- Logs, screenshots, anything else. A pull request that fixes this should link it with "Closes #". -->

‎.github/ISSUE_TEMPLATE/chore.md‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
---
2+
name: Chore
3+
about: Maintenance, tooling, CI, dependencies, docs or process — no user-facing behaviour change
4+
title: 'chore: '
5+
labels: chore
6+
---
7+
8+
## What
9+
10+
<!-- The maintenance task: what changes and where. -->
11+
12+
## Why
13+
14+
<!-- Why it is worth doing now. -->
15+
16+
## Done when
17+
18+
- [ ]
19+
20+
<!-- A pull request for this chore links back with "Closes #". -->

‎.github/ISSUE_TEMPLATE/config.yml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
blank_issues_enabled: false
2+
contact_links:
3+
- name: Security report
4+
url: https://github.com/pkgdiff-dev/pkgdiff/security/policy
5+
about: Report a security problem privately through SECURITY.md — never a public issue.
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
---
2+
name: Feature request
3+
about: A new capability or a larger change — agree the approach here before any code
4+
title: 'feat: '
5+
labels: enhancement
6+
---
7+
8+
## Problem
9+
10+
<!-- What is missing or painful today, and for whom. -->
11+
12+
## Proposed approach
13+
14+
<!-- How you would solve it. For a larger change, enough that we can agree on the approach before
15+
a pull request is opened. -->
16+
17+
## Alternatives considered
18+
19+
<!-- Or "None". -->
20+
21+
## Scope / out of scope
22+
23+
<!-- What this does and does not cover. A pull request implementing it links back with "Closes #". -->

‎.github/pull_request_template.md‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44

55
## Why
66

7-
<!-- The problem it solves. Link the issue (Fixes #123) or name a package and versions that show it. -->
7+
Closes #
8+
9+
<!-- Replace the number above with the issue this pull request closes. Every pull request links an
10+
issue; if one does not exist yet, open it first. -->
811

912
## Changes
1013

@@ -16,6 +19,7 @@
1619

1720
## Checklist
1821

22+
- [ ] This pull request is linked to an issue (`Closes #NNN` above)
1923
- [ ] The pull request targets `develop` and is about one thing
2024
- [ ] Commit messages follow Conventional Commits (`feat(scope): ...`, `fix(scope): ...`)
2125
- [ ] CI is green (backend tests, frontend build and tests, dependency gate)

‎CONTRIBUTING.md‎

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,12 @@ and pull requests are all welcome.
55

66
## Before you start
77

8-
- For a bug, open an issue with the registry, the package, the two versions and what you expected.
9-
- For a larger change, open an issue first so we can agree on the approach.
10-
- Security problems go through [SECURITY.md](SECURITY.md), not through an issue.
8+
Every change starts with an issue. Open one first — a bug, a registry quirk, a feature or a chore —
9+
using the matching issue template, so the work has a tracked rationale before any code is written.
10+
11+
- For a bug, include the registry, the package, the two versions and what you expected.
12+
- For a feature or a larger change, describe the approach in the issue so we can agree on it first.
13+
- Security problems go through [SECURITY.md](SECURITY.md), never a public issue.
1114

1215
## Setting up
1316

@@ -16,7 +19,13 @@ a PostgreSQL and Redis you can reach on `localhost`.
1619

1720
## Branches and pull requests
1821

19-
- Branch from `develop` and open the pull request into `develop`. `master` only receives releases.
22+
We work issue-first, with the pull request opened alongside the issue rather than at the end:
23+
24+
- Once an issue exists, branch from `develop` and open the pull request into `develop` early — a
25+
draft is fine — so the work is visible while it is still in progress. `master` only receives
26+
releases.
27+
- Link the pull request to its issue with a closing keyword (`Closes #123`) so merging the pull
28+
request closes the issue. A pull request without a linked issue will be asked to add one.
2029
- Keep a pull request about one thing and fill in the pull request template, in English. CI
2130
(backend tests, frontend build and tests, dependency gate) must be green.
2231
- Commit messages follow Conventional Commits: `feat(scope): ...`, `fix(scope): ...`, `docs: ...`.

0 commit comments

Comments
 (0)