From dc205c889ea0a40b95b4d0a15463ee380d117ab7 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 12 Nov 2026 00:40:59 +0000 Subject: [PATCH] fix(mutation): the Messaging gate filters out the S3 differential run, so the nightly finishes (#562) Since #526 the S3 differential run (BusDifferentialTests, Category=Differential: every conformance fact again on both engines, on real containers) sat in the test set of stryker/Goldpath.Messaging.json, so Stryker ran it against every mutant. Nightly 42789231201 was cancelled at the job's 300-minute timeout with no score (216 tests found, 441 mutants to test, a 7.8-minute initial run, against 155 / 348 / 3.6 the night before). The config's test-case-filter now also excludes Category=Differential. The differential run compares engine outcomes; it is not the unit-level killer set, and ci.yml's conformance step still runs it on every pull request. Threshold, timeout and concurrency unchanged. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_018AFdNd6h1NzwmonTGq2k4V --- CHANGELOG.md | 7 +++++++ stryker/Goldpath.Messaging.json | 2 +- stryker/README.md | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1d213cab..cf25e76b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -936,6 +936,13 @@ Format: [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) · Versioning: are closed here with that reason. ### Fixed +- **The nightly Messaging mutation gate gave no verdict: it hit the job's 300-minute timeout (#562).** Since the S3 + differential run joined `Goldpath.Messaging.Conformance` (#526), Stryker ran `BusDifferentialTests` (every conformance + fact again on both engines, on real containers) against every mutant: 216 tests found instead of 155, 441 mutants to + test instead of 348, and an initial test run of 7.8 minutes instead of 3.6. Nightly 42789231201 was cancelled at 300 + minutes with no score. `stryker/Goldpath.Messaging.json` now also filters out `Category=Differential`. The differential + run compares engine outcomes; it is not the unit-level killer set, and it still runs on every pull request in `ci.yml`. + The threshold (break 70), the timeout and the concurrency cap are unchanged. - **Generated apps with an AppHost failed restore on an Aspire advisory published 2026-11-10 (GHSA-f7vh-h5g3-7jrh, CVE-2026-120006, high: Aspire elevation of privilege, fixed in 13.6.5).** `Aspire.Hosting` and `Aspire.Hosting.AppHost` below 13.6.5 are affected. Under TreatWarningsAsErrors NU1903 is a restore failure, so every golden-manifest shape with an diff --git a/stryker/Goldpath.Messaging.json b/stryker/Goldpath.Messaging.json index 29d7b1d0..ba8d5f41 100644 --- a/stryker/Goldpath.Messaging.json +++ b/stryker/Goldpath.Messaging.json @@ -6,7 +6,7 @@ "../../tests/Goldpath.Messaging.Conformance/Goldpath.Messaging.Conformance.csproj", "../../tests/Goldpath.IntegrationTests/Goldpath.IntegrationTests.csproj" ], - "test-case-filter": "FullyQualifiedName!~Goldpath.Tests.Integration.|FullyQualifiedName~Goldpath.Tests.Integration.OutboxAtomicityTests.", + "test-case-filter": "(FullyQualifiedName!~Goldpath.Tests.Integration.|FullyQualifiedName~Goldpath.Tests.Integration.OutboxAtomicityTests.)&Category!=Differential", "target-framework": "net10.0", "reporters": [ "progress", diff --git a/stryker/README.md b/stryker/README.md index 9e2b5b7a..781dddec 100644 --- a/stryker/README.md +++ b/stryker/README.md @@ -38,7 +38,7 @@ borrow exactly those — not every container-backed story that happens to pass t | Data | `Goldpath.MultiTenancy.Tests` | The tenant guard's ordering (`Guard_messages_teach_the_fix_and_the_contributor_runs_first`) asserts `SaveContributors` and the filter composition in `QueryFilters` (2 mutants). | | MultiTenancy | `Goldpath.Auth.Tests` | `Binding_can_be_disabled_for_gateway_owned_tenancy` / `Binding_rejection_body_names_the_problem` assert the tenant-to-principal binding MultiTenancy registers (1 mutant). | | MultiTenancy | `Goldpath.IntegrationTests` | `Http_tenant_survives_middleware_stamp_outbox_broker_and_consumer_stamp` is the tenant's journey through the outbox and a real broker, which no unit suite can host (2 mutants). The rest of the suite is filtered out: under solution mode it also killed 3 header-name string mutants INCIDENTALLY, through the campaign pacer bench (75.58 %); the deliberate tests alone score 72.09 %. Borrowing the whole suite cost 130 minutes (nightly 39388961885) and did not even kill those 3 — the bench fails under Stryker's instrumentation. | -| Messaging | `Goldpath.Messaging.Conformance` | The seam's own conformance suite (ADR-0013): `S2_1_exactly_once_…` is the outbox's exactly-once contract (1 mutant). | +| Messaging | `Goldpath.Messaging.Conformance` | The seam's own conformance suite (ADR-0013): `S2_1_exactly_once_…` is the outbox's exactly-once contract (1 mutant). The S3 differential run (`BusDifferentialTests`, `Category=Differential`) is filtered out: it runs every conformance fact again on both engines against real containers to compare their outcomes, which makes it an engine-parity check, not a mutant killer, and with it the nightly run could not finish inside 300 minutes (#562). It still runs on every pull request in `ci.yml`'s conformance step. | | Messaging | `Goldpath.IntegrationTests` | `Committed_transaction_delivers_exactly_once` and `Rolled_back_transaction_publishes_nothing` prove the outbox registration against real Postgres + RabbitMQ (3 mutants). | | Locking | `Goldpath.IntegrationTests` | `Exactly_one_competitor_holds_the_lock_and_release_hands_it_over` and `Tenant_scoped_names_do_not_contend_across_tenants` contend for a real lock; the unit suite has no second holder (1 mutant). | | Locking.Oracle | `Goldpath.IntegrationTests` | `OracleLockNameTests` is the package's only unit-level suite: it composes `AddGoldpathOracleLocking` and reads each lock's name back without opening a connection, so it needs no container. The package has no test project of its own, and the filter keeps the Oracle-container facts out of the run (all 24 mutants). |