diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..61ddf9b 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -7,8 +7,7 @@ * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" +import { useDebounce } from "@e2e/utils" import { formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +27,5 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +// Re-export the debounce hook +export { useDebounce as useSearchDebounce } diff --git a/bunfig.toml b/bunfig.toml index 3258d71..1cb73b3 100644 --- a/bunfig.toml +++ b/bunfig.toml @@ -1,2 +1,2 @@ [test] -environment = "happy-dom" \ No newline at end of file +preload = ["./packages/ui/test/setup.ts"] \ No newline at end of file diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..b37e842 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -17,13 +17,10 @@ type Props = { /** * Button component. * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. - * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. + * Icon-only buttons render without visible text, so an `aria-label` is required + * to give them an accessible name (WCAG 2.2 SC 4.1.2 Name, Role, Value). + * When `iconOnly` is set without an `aria-label`, a fallback name is applied and + * a development-only warning is emitted. */ export function Button({ children, @@ -34,13 +31,30 @@ export function Button({ onClick, "aria-label": ariaLabel, }: Props) { + // An empty or whitespace-only aria-label provides no accessible name, so it is + // treated the same as a missing one (WCAG 2.2 SC 4.1.2 Name, Role, Value). + const hasAriaLabel = Boolean(ariaLabel?.trim()) + + if (process.env.NODE_ENV !== "production" && iconOnly && !hasAriaLabel) { + console.warn( + "Button: `aria-label` is required when `iconOnly` is true — icon-only buttons have no visible text and fail WCAG 2.2 SC 4.1.2 without an accessible name.", + ) + } + + const accessibleName = iconOnly + ? hasAriaLabel + ? ariaLabel + : typeof children === "string" + ? children + : "Button" + : ariaLabel + return (