diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..b0121b5 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -1,14 +1,8 @@ /** * API client utilities for the web app. - * - * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to - * `useDebounce`. This causes a TypeScript error and a runtime crash. - * - * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" +import { useDebounce } from "@e2e/utils" import { formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +22,5 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +// Re-export the debounce hook +export { useDebounce as useSearchDebounce } diff --git a/bunfig.toml b/bunfig.toml index 3258d71..8e14e5a 100644 --- a/bunfig.toml +++ b/bunfig.toml @@ -1,2 +1,6 @@ [test] -environment = "happy-dom" \ No newline at end of file +# Bun has no `environment` setting — a DOM must be registered explicitly. +# packages/ui/test/setup.ts registers happy-dom via GlobalRegistrator, so it is +# preloaded here to make `document` available to the React component tests when +# `bun test` is run from the repository root. +preload = ["./packages/ui/test/setup.ts"] diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..8885148 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -17,13 +17,11 @@ type Props = { /** * Button component. * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. - * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. + * An icon-only button has no visible text, so it must expose an accessible + * name via `aria-label` to satisfy WCAG 2.2 SC 4.1.2 (Name, Role, Value). + * When `iconOnly` is set without an `aria-label`, the component warns in + * development and falls back to any string children, or a generic label, so + * the control is never left without an accessible name. */ export function Button({ children, @@ -34,13 +32,24 @@ export function Button({ onClick, "aria-label": ariaLabel, }: Props) { + let label = ariaLabel + + if (iconOnly && !label) { + label = typeof children === "string" ? children : "Button" + if (process.env.NODE_ENV !== "production") { + console.warn( + "Button: `iconOnly` requires an `aria-label` for screen reader users " + + `(WCAG 2.2 SC 4.1.2). Falling back to "${label}".`, + ) + } + } + return (