From 087315be69afb257a69ddee52b43873a032dd34b Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Thu, 3 Sep 2026 16:25:15 +0000
Subject: [PATCH] fix: repair cross-package imports, en-AU dates, a11y label
 and sort toggle

- api.ts: import/re-export useDebounce (was stale useThrottle after rename)
- date.ts: use dateStyle 'short' for en-AU so day is unpadded (D/M/YY)
- Button: apply aria-label for icon-only buttons (WCAG 2.2 SC 4.1.2), with
  dev-only warning + fallback label when omitted
- DataTable: use functional setState to fix stale-closure sort toggle
- bunfig.toml: preload happy-dom setup at root so document is defined for
  UI tests under a root `bun test` run (Bun has no `environment` option)
- tsconfig.json: add bun-types so `bun:test` module resolves

All 13 tests pass; tsc --noEmit is clean. No test files modified.
---
 apps/web/src/lib/api.ts                       | 12 +++------
 bunfig.toml                                   |  6 ++++-
 packages/ui/src/components/Button/Button.tsx  | 27 ++++++++++++-------
 .../ui/src/components/DataTable/DataTable.tsx | 12 +++------
 packages/utils/src/format/date.ts             | 14 +++-------
 tsconfig.json                                 |  1 +
 6 files changed, 33 insertions(+), 39 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..b0121b5 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,14 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
+import { useDebounce } from "@e2e/utils"
 import { formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
@@ -28,5 +22,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook
+export { useDebounce as useSearchDebounce }
diff --git a/bunfig.toml b/bunfig.toml
index 3258d71..8e14e5a 100644
--- a/bunfig.toml
+++ b/bunfig.toml
@@ -1,2 +1,6 @@
 [test]
-environment = "happy-dom"
\ No newline at end of file
+# Bun has no `environment` setting — a DOM must be registered explicitly.
+# packages/ui/test/setup.ts registers happy-dom via GlobalRegistrator, so it is
+# preloaded here to make `document` available to the React component tests when
+# `bun test` is run from the repository root.
+preload = ["./packages/ui/test/setup.ts"]
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..8885148 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -17,13 +17,11 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * An icon-only button has no visible text, so it must expose an accessible
+ * name via `aria-label` to satisfy WCAG 2.2 SC 4.1.2 (Name, Role, Value).
+ * When `iconOnly` is set without an `aria-label`, the component warns in
+ * development and falls back to any string children, or a generic label, so
+ * the control is never left without an accessible name.
  */
 export function Button({
   children,
@@ -34,13 +32,24 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  let label = ariaLabel
+
+  if (iconOnly && !label) {
+    label = typeof children === "string" ? children : "Button"
+    if (process.env.NODE_ENV !== "production") {
+      console.warn(
+        "Button: `iconOnly` requires an `aria-label` for screen reader users " +
+          `(WCAG 2.2 SC 4.1.2). Falling back to "${label}".`,
+      )
+    }
+  }
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={label}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..d93f969 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -16,22 +16,16 @@ type Props<T extends Record<string, unknown>> = {
 /**
  * DataTable with client-side sorting.
  *
- * BUG: The sort handler has a stale closure — it captures `sortDir` at the
- * time the handler is created, so toggling sort direction does not work
- * correctly after the first click. The second click always sorts in the same
- * direction as the first.
- *
- * Fix: use the functional form of setState — `setSortDir(prev => ...)` —
- * so the toggle always reads the current value.
+ * Sort direction is toggled with the functional form of setState so the
+ * handler always reads the current value rather than a stale closure capture.
  */
 export function DataTable<T extends Record<string, unknown>>({ data, columns }: Props<T>) {
   const [sortKey, setSortKey] = useState<keyof T | null>(null)
   const [sortDir, setSortDir] = useState<SortDir>("asc")
 
-  // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
     if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+      setSortDir((prev) => (prev === "asc" ? "desc" : "asc"))
     } else {
       setSortKey(key)
       setSortDir("asc")
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..99d5a67 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,20 +1,12 @@
 /**
  * Date formatting utilities.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * Uses `dateStyle: 'short'` with the `'en-AU'` locale so the day precedes the
+ * month (D/M/YY) and the day is not zero-padded.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
   return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
-    day: "numeric",
-    year: "numeric",
+    dateStyle: "short",
   }).format(date)
 }
 
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..8e00ae0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]