From d28b10eb01028c5474c78581dafaa574aad7e48b Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Wed, 9 Sep 2026 04:41:18 +0000
Subject: [PATCH] fix: repair DOM test env, date locale, hook rename and
 icon-button label

- bunfig.toml: replace invalid 'environment' key with 'preload' so happy-dom
  registers and DOM globals exist under bun test (fixes 'document is not defined')
- tsconfig.json: add 'bun-types' to types so 'bun:test' resolves (fixes TS2307)
- utils/date.ts: format day-first with no leading zero on day via formatToParts
- web/api.ts: rename removed useThrottle import to the current useDebounce export
- ui/Button.tsx: apply aria-label for icon-only buttons; guard process.env and
  avoid masking the a11y defect with a bogus fallback label
- ui/DataTable.tsx: use functional state updater for sort direction toggle
---
 apps/web/src/lib/api.ts                       | 13 ++------
 bunfig.toml                                   |  2 +-
 packages/ui/src/components/Button/Button.tsx  | 33 ++++++++++++++-----
 .../ui/src/components/DataTable/DataTable.tsx | 11 +------
 packages/utils/src/format/date.ts             | 25 +++++++-------
 tsconfig.json                                 |  1 +
 6 files changed, 44 insertions(+), 41 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..8a635e5 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,15 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
-import { formatDate, formatAUD } from "@e2e/utils"
+import { useDebounce, formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
 
@@ -28,5 +21,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook
+export { useDebounce as useSearchDebounce }
diff --git a/bunfig.toml b/bunfig.toml
index 3258d71..1cb73b3 100644
--- a/bunfig.toml
+++ b/bunfig.toml
@@ -1,2 +1,2 @@
 [test]
-environment = "happy-dom"
\ No newline at end of file
+preload = ["./packages/ui/test/setup.ts"]
\ No newline at end of file
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..cf9edc3 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -17,13 +17,10 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * An `iconOnly` button renders no visible text, so it must carry an
+ * `aria-label` to have an accessible name (WCAG 2.2 SC 4.1.2). Callers that
+ * omit one get a dev-mode warning and no substituted name, so the missing
+ * label surfaces in accessibility tooling rather than being masked.
  */
 export function Button({
   children,
@@ -34,13 +31,31 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  const isDev = typeof process !== "undefined" && process.env?.NODE_ENV !== "production"
+
+  if (iconOnly && !ariaLabel && isDev) {
+    console.warn(
+      "Button: `iconOnly` buttons require an `aria-label` so screen reader users get an accessible name (WCAG 2.2 SC 4.1.2).",
+    )
+  }
+
+  // Text buttons get `undefined` so React omits the attribute entirely and the
+  // accessible name comes from visible text (avoids overriding it — SC 2.5.3).
+  //
+  // Icon-only buttons prefer an explicit `aria-label`, then string children. If
+  // neither exists there is no honest name to use, so we emit an empty
+  // `aria-label` rather than inventing one: per the accessible name computation
+  // an empty/whitespace `aria-label` is skipped, so the button is correctly
+  // reported as unnamed by axe/Lighthouse instead of silently passing.
+  const accessibleLabel =
+    ariaLabel ?? (iconOnly ? (typeof children === "string" ? children : "") : undefined)
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={accessibleLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..e6ba613 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -15,23 +15,14 @@ type Props<T extends Record<string, unknown>> = {
 
 /**
  * DataTable with client-side sorting.
- *
- * BUG: The sort handler has a stale closure — it captures `sortDir` at the
- * time the handler is created, so toggling sort direction does not work
- * correctly after the first click. The second click always sorts in the same
- * direction as the first.
- *
- * Fix: use the functional form of setState — `setSortDir(prev => ...)` —
- * so the toggle always reads the current value.
  */
 export function DataTable<T extends Record<string, unknown>>({ data, columns }: Props<T>) {
   const [sortKey, setSortKey] = useState<keyof T | null>(null)
   const [sortDir, setSortDir] = useState<SortDir>("asc")
 
-  // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
     if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+      setSortDir((prev) => (prev === "asc" ? "desc" : "asc"))
     } else {
       setSortKey(key)
       setSortDir("asc")
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..cd893ce 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,21 +1,24 @@
 /**
  * Date formatting utilities.
+ */
+
+/**
+ * Format a date as D/MM/YYYY for Australian locale — e.g. 1/03/2024, 15/06/2024.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * Note: `en-AU` silently upgrades `day: "numeric"` to `"2-digit"` via its
+ * format-matching table, which would yield 01/03/2024. Property order is
+ * irrelevant to Intl — field order comes from the locale, and `en-AU` is
+ * already day-first. So the day's leading zero is stripped explicitly via
+ * `formatToParts` rather than by requesting `day: "numeric"`.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
+  const parts = new Intl.DateTimeFormat("en-AU", {
     day: "numeric",
+    month: "2-digit",
     year: "numeric",
-  }).format(date)
+  }).formatToParts(date)
+
+  return parts.map((part) => (part.type === "day" ? String(Number(part.value)) : part.value)).join("")
 }
 
 export function formatDateTime(date: Date): string {
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..8e00ae0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]