From a6e7e82bc834602c00713003fbc9a716d2de5a4f Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Wed, 9 Sep 2026 07:07:35 +0000
Subject: [PATCH] fix: repair cross-package bugs so tests and typecheck pass

- bunfig.toml: preload happy-dom setup so DOM globals exist for root `bun test`
  (the prior `environment = "happy-dom"` key is a no-op in bun)
- apps/web api.ts: import/re-export renamed hook useDebounce (was useThrottle)
- Button: forward aria-label and provide accessible name for icon-only buttons
  with a dev warning when unlabelled [WCAG 2.2 SC 4.1.2]
- DataTable: collapse sort key/dir into one state object to fix stale-closure
  bug on second-click descending sort
- date.ts: de-pad the day part so en-AU output is day-first single-digit
- tsconfig.json: add explicit "types": ["bun-types"] for bun:test resolution

No test files, package.json, or lockfile modified; no dependencies added.
---
 apps/web/src/lib/api.ts                       | 13 ++-------
 bunfig.toml                                   |  2 +-
 packages/ui/src/components/Button/Button.tsx  | 23 +++++++++------
 .../ui/src/components/DataTable/DataTable.tsx | 29 +++++++++----------
 packages/utils/src/format/date.ts             | 21 +++++++-------
 tsconfig.json                                 |  4 +++
 6 files changed, 45 insertions(+), 47 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..56c1c04 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,15 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
-import { formatDate, formatAUD } from "@e2e/utils"
+import { useDebounce, formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
 
@@ -28,5 +21,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under the app-facing name
+export { useDebounce as useSearchDebounce }
diff --git a/bunfig.toml b/bunfig.toml
index 3258d71..0b64f7c 100644
--- a/bunfig.toml
+++ b/bunfig.toml
@@ -1,2 +1,2 @@
 [test]
-environment = "happy-dom"
\ No newline at end of file
+preload = ["./packages/ui/test/setup.ts"]
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..8beac96 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -17,13 +17,11 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * When `iconOnly` is true the button renders no visible text, so an
+ * `aria-label` is required for an accessible name (WCAG 2.2 SC 4.1.2).
+ * An explicit `aria-label` is always forwarded to the element; if one is
+ * missing on an icon-only button a generic fallback is applied and a warning
+ * is logged outside production.
  */
 export function Button({
   children,
@@ -34,13 +32,20 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  if (iconOnly && !ariaLabel && process.env.NODE_ENV !== "production") {
+    console.warn(
+      "Button: `iconOnly` buttons must be given an `aria-label` to satisfy WCAG 2.2 SC 4.1.2 (Name, Role, Value).",
+    )
+  }
+
+  const accessibleName = ariaLabel ?? (iconOnly ? "Button" : undefined)
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={accessibleName}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..22fc22b 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -16,26 +16,23 @@ type Props<T extends Record<string, unknown>> = {
 /**
  * DataTable with client-side sorting.
  *
- * BUG: The sort handler has a stale closure — it captures `sortDir` at the
- * time the handler is created, so toggling sort direction does not work
- * correctly after the first click. The second click always sorts in the same
- * direction as the first.
- *
- * Fix: use the functional form of setState — `setSortDir(prev => ...)` —
- * so the toggle always reads the current value.
+ * Sort key and direction are held in a single state object and updated via the
+ * functional form of setState, so a click always toggles from the current
+ * direction — including when multiple clicks are batched into one render pass.
  */
 export function DataTable<T extends Record<string, unknown>>({ data, columns }: Props<T>) {
-  const [sortKey, setSortKey] = useState<keyof T | null>(null)
-  const [sortDir, setSortDir] = useState<SortDir>("asc")
+  const [sort, setSort] = useState<{ key: keyof T | null; dir: SortDir }>({
+    key: null,
+    dir: "asc",
+  })
+  const { key: sortKey, dir: sortDir } = sort
 
-  // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
-    if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
-    } else {
-      setSortKey(key)
-      setSortDir("asc")
-    }
+    setSort((prev) =>
+      prev.key === key
+        ? { key, dir: prev.dir === "asc" ? "desc" : "asc" }
+        : { key, dir: "asc" },
+    )
   }
 
   const sorted = sortKey
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..86c8ce5 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,21 +1,20 @@
 /**
  * Date formatting utilities.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * formatDate returns Australian day-first dates with an unpadded day and a
+ * zero-padded month (e.g. "1/03/2024", "15/06/2024"). The day padding is
+ * stripped explicitly because the en-AU short pattern widens a "numeric" day
+ * to two digits.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
+  const parts = new Intl.DateTimeFormat("en-AU", {
     day: "numeric",
+    month: "2-digit",
     year: "numeric",
-  }).format(date)
+  }).formatToParts(date)
+  const part = (type: Intl.DateTimeFormatPartTypes) =>
+    parts.find((p) => p.type === type)?.value ?? ""
+  return `${Number(part("day"))}/${part("month")}/${part("year")}`
 }
 
 export function formatDateTime(date: Date): string {
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..687d9c0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,10 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    // bun-types does not live under node_modules/@types/, so it must be listed
+    // explicitly. NOTE: setting "types" disables automatic inclusion of all
+    // other @types/* packages — add any further ones to this array.
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]